From nobody Wed Oct 23 13:51:27 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XYVnr0XpBz5bFdS; Wed, 23 Oct 2024 13:51:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XYVnr04SSz4k6T; Wed, 23 Oct 2024 13:51:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729691488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nv+EivXlS4ykE2K3eCglbaGgdnkClCl/dfJyti8Ogas=; b=cmVowdXg5rCMuwai5IzjZbKf3Av6P2qKaaHiYzCB17jI/9UvsJOB09cgB9uWTnpc5rdfJw XExgalp4Bml5RSHK2lvGPYFqgAEhbcBUXyfvkSgl/rQVeuY6lcj0VsObeK/nz67zIKcegc Mza2w3lBIPbtxElnqcQHgNsYpFuHuN0/aRDp6bFyWoPQvC9H5GokCn6CDzYEA4c7P1qmEI 4iuq9vfYhKp1zGocfn3KOV4c57JtXYCiAL5D6SfVJGpmfIOdoIHa1oC+k8cUXCiQnh0DVe 1Zm5ufKjg4R/siVMhsRQW5p01ByZSoQuxAdwWPb8skHgeAE3PL5ZpekHt7sgeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729691488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nv+EivXlS4ykE2K3eCglbaGgdnkClCl/dfJyti8Ogas=; b=ab6lf0be7HSeWZscCUSIQJY+DH+KFB93y8DZL9PTucrN+K+0UctmweOC4t5qbiWmuJRYVU UsbK6QnEMh2WpFdLaKkZiE+Cw8HGC8OJsutqpNbusoyEayfjotgcmYiaTBI9o47oWvcWG1 q52MO+o9vKL8JvAMz4+I9BjDDz3DQUTpGEQzSuY8elQn7d9uuAckVk0i8xmJao5L8RppeQ OP71TDcGWPL7Vf/M5ChatwBKN6SzNRN8/E3J4FVzu1MUEeBw1AY6lvqiaByz1KpKr4VnAI 13UDeA/izJNWicm+iIBLxc9/xgz5GDpTTSUlbcOt77iYU/SdwMdNNnOpYC+wOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729691488; a=rsa-sha256; cv=none; b=NFa1FVwsShD28QVVThS7aFmiBo7QhoXtJXHHp04U9L6a+uUBa3AmTtgCxX8ZV0aeiRRNHD MTa053n2fstlrtsprzPn5oo73FMdwZ96p/pZQc0QVJ4lHafANPQMAdzKw3/1FOIY1EPWVC FMsxTlUpCuq/hyAv4hDKXkkx0lwQS7i28NIf5Vl9DHKmXQ1hmsOVmUMiF1ojNiMxwsLlRV yW7UoCs+7PxYdRaOJyEE82V3TZEhzoFCUDHTMwGMd9HLOls2p1p1c1R/Hx6A3p6GVXV2Ri qFp/xTR5Idx8NmCPuwonEYW0AU59ZB1jD+hHgiGjfHozPeoylCh/wDmDgEqyFw== Received: from [IPV6:2601:5c0:4200:b830:41c2:e465:68f5:36e1] (unknown [IPv6:2601:5c0:4200:b830:41c2:e465:68f5:36e1]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XYVnq5766zjlP; Wed, 23 Oct 2024 13:51:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <1b16aaec-e586-4e5c-a764-0e1eed7c9611@FreeBSD.org> Date: Wed, 23 Oct 2024 09:51:27 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 419249c1cacc - main - Revert "LINT: Add mac_do" Content-Language: en-US To: Baptiste Daroussin , Li-Wen Hsu Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202410230740.49N7efYQ065894@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/23/24 03:47, Baptiste Daroussin wrote: > On Wed 23 Oct 07:40, Li-Wen Hsu wrote: >> The branch main has been updated by lwhsu: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=419249c1cacca2cfdf5128ead2873a9fd57f112e >> >> commit 419249c1cacca2cfdf5128ead2873a9fd57f112e >> Author: Li-Wen Hsu >> AuthorDate: 2024-10-23 07:40:14 +0000 >> Commit: Li-Wen Hsu >> CommitDate: 2024-10-23 07:40:14 +0000 >> >> Revert "LINT: Add mac_do" >> >> This reverts commit 91b7b225b2ce577381aae989c361b9b5b6dd1500. > > It would be interesting to get the why in the commit log here, to understand > what needs to be fixed. I was about to reply with the same thought, that in general we should try to add the "why" when reverting a change and not just use the raw generated log from git revert. -- John Baldwin