From nobody Mon Oct 21 18:18:23 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XXNps2Ylzz5ZbZ3 for ; Mon, 21 Oct 2024 18:18:29 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from sonic322-56.consmr.mail.ne1.yahoo.com (sonic322-56.consmr.mail.ne1.yahoo.com [66.163.189.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XXNpr2HShz4Cbw for ; Mon, 21 Oct 2024 18:18:28 +0000 (UTC) (envelope-from pfg@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=mX42J68E; spf=softfail (mx1.freebsd.org: 66.163.189.31 is neither permitted nor denied by domain of pfg@freebsd.org) smtp.mailfrom=pfg@freebsd.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1729534706; bh=ZnUHvfpPOeXwjkMCG7jqKH/HOLS/R+7CxSd+mtt+fuk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=mX42J68EYDlSwtcnrB+IgjY5H1Xzu5KB+637Yxb0XgF6A6/9qv/gLBKN0q88K6jhin+WQpVSjxXaIW4EjPA32CE8EDRF1iZQJ4QK7V0OsDY9JFD6ijaNgplHGdoprlxS0yNFiH276SQZHCoHgOYbf8NCuSgGqbjadVQsLDDxFA0XxK/jPKnbuwvlhg7NMr2Zfwh3f2ZqDaoSBfs5WDktniHNRBflojJFtS+fwcj4MO45k6qsl9mbslJij/EWh3S9LUqOYwafnBXGByBobY0mZOw4NdaA+kx0Cn02wjmacokDp7BPMgxClaneKwTwtV9b1LrfQW09q/wA4ttVWWaPYg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1729534706; bh=COuYO2IMOiGWdDCuJ/pv4Nkjw8MAMazTU6Ds0IMXE2N=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=O1a3xrJIGUSv0FWKHUntZsfg3Eb5qX4fF9cGgem2PhI4vIor4qe6+XfzTvmLiT6Z3PHZe3NI5l55c97Mmf8jCz7VTFwFC5u+x1gFWxIWXHDPvkokeji2W9wSyeXAnGuj9dA+NUVw5HynYUS47RHoi+sOwVTCZNO3Mi42M2IE2dkpp/27wJMWHE8s2eKA8mIa8FvjcDannlMhw3ZWRrVC9Kq8pjFgX574o62rEc698TDv1PZZn+GzlmHqPd4JWLLdfTlx7S2wwYRABsM+PW6r/B9J/qfRbqqlc6BrSHlLoXi1E8uaSwjgvInHpxZOVLluPCQ6zsPi2p9HnKSVDFQ76g== X-YMail-OSG: HAfTTBcVM1niQOQ3sY5niWWYuf1lt9X3NPsez4IU8nVR517_2sT6snOrAgiEfQY escppGEZuaF_f.9EQ3aU0nRWSnhHt5PcMQBF6nbiYw_qq.oUnJV73nL45hMC73dMNvANq_rCG.wX pQWoGZo6PwCs1sd.z0eSVePbEqv5vkVY1hmXpIA8Kwwqgs11vHpzH6i_StUb5HX7fUMGYiNQVDcV Lw3gwJLDurwW8s4ea3zr54WYl4KoLvEE_QiBhPfEOwcoDd6cAGNcIxF9s96dCTBEJ0I7ePbWOGFu pnfoQxGvnhVlpaoehyoFw29zvYdOI1UusRPaI5BI7HZILHJ2CO61TdP8YVMvDRSpmUQfMTZJTewS xr1QeOA606.VEwmfiIYarBRFTQVxor8fNYs7NrGBXwWSqcfrm8Bnr8EA1tRA9d8B0_XnimLzZGuV XByuTLCVDZGkhtQiS9v6giR_zj4eRdgcEY160JR.vcyQA9mTr7rB3T0_uCf0LTTGDICopdtXqj2H usOoSf811lfgRSrBxoH_DRi4.ad_rQUQ8R3ycgKaGDL2CqStyqVeWyJAx.FjNRLBfoqcGOWL_Az. kr.ZryIiadG.BWvMnS7Ti1Gs_dWRO.02xpCRs2rjoXPSA0u2Zk7RhgOlkAsnN4d6F_nPKrqLlCOZ Dekzv.mvr1THfyFTusfEU3EoY88Zt9y98TDMhg0mSltG2wIO5oRspfosr_1Qkq0PQK0HNxHrzPZv yK2W2fDcFbg2L4REccnz.LCDKRcGQe8GDdMJn0o0z0ufP34txPEFiE_MUmkwMrR02zUdae3_EmSW 9pLFCZwY99U10vXXoE3Yc4TQLJGt2JWlUZyOC2iu0cI0OK4xtGTgEvjTxLZxXX.R1qptTk3DGV06 aLKcHVZ..K1.1glVU19QOxF1wwaes3SPDE.dfv5hDDTT0HLWITt81MBJZoFWZX7xzGfzCzvdOc4c 6ZKIQMqSuJEl27_rLshdX4LFYKOg4OkfFR6p7rzKTZoad_U1p0ClPM0eskycIEt4wE1dvEXIVaYC 18cLOVCM1orkoszIrreHVhpUiS1OwIQ6Rxg5bu.rINd6lWmjg2emPO0spYhPrxDY63uadmFGVp1g T0bjjzQuPmfdx5uP3BKASescPlwvRY_3LRSEz49y9fEuZ4a_xPOqBcchBgwUAWlhlLcxMX8vmsIp 3VBrt4J.IUhr3ljoGiJVZh0.ZbfzyQjsHMfHtz0NJMkIw6L79ls9dcJ9yYrksnSKl2_1neuAEZRg wqnhYkKqTJwMyUMp0KN.20Ado59Lx33q0NSSMrgC7jN7MwotaSfF45yiib_2vwnLVd8fQvBw1qkM 0U.q2IWidh3gXN2EOE8ku5DR9H2UG5JyaUh0YZzWbF973minZ4c.q2qwIbnLF9wx0Na2twbuxttw wsZlgo_TiZGHeht1CYPVDD0sHaxdLlFmsVhuSdhqbLgkzEHcbRfILytV0oqdQg8TWPoyrrh3_vrk MrcTjRdSP7gM2cYyjRBXjmnjTEBQc6zQzMTuniaZDHfjUB_iN0cQRz.Sz37qEdFdy31iJqv5kZrp qpLJLZASNoVxdA0KFoE1Tumjnl6IhqcfJGiU6D5ZL2fEkOlf1tgv7BrGot.jcvWBrbT7nG2YKWTq lRZgIkFyZx5qZWom_FG7zgrzk2GcCCc9Oo48iYuZ2a9KdfWXsWmcfJJmAk9yUHcJ0tYso5d10xPm KzznakaGbSU0fgX5hs5YvaREvP8qUbfgYi5_LOqjrjc_M16mXeFIDGYVnbmAeqaykgsj8dLMpbeB AFg5FuBeb1Wzj4abSFSuiPT_Cx912KUgTC5lnNMdd6dK2_BQxlV8uYO1SimDRYs2pCT8Pb3lPmRB wchXbXNbDeH3BzxkQg25foeA8AVDhWNLAKP6i9HSi5xzMxOhaE2zu4GWso.nmUB7zlGFH6Y1S83V 1jsOIpyxcIMtJ8DZsRWdVjNRFKTOhlfxjdnI6JSoqOECH62apSodQ8OAsJx04bizQhaRRRayiew5 _1IDTF7Lv_qbiGwUPBWVpHliHX0f552BnyfXyK3hjXlKKlV73UO9f8VlmIWABeYy73z5BXEh5lRl gnP_CWJs_zSCIksZNaUS.1zcjSntYln_5mfPdA_.S3jVQvFOOWPPknbp0MnI2kun96AhT6KfDJ79 zD4N0otehy2ibwucqbMPeYgyTWajHmXdgqM5P3DaaNQN0lGrEH4ZjSm3S5s7qbgxKkW.Y9nw2vtx aUjbikR1Iw9vf2msm X-Sonic-MF: X-Sonic-ID: d0dcd9e7-ffa8-4b78-891d-626e07def985 Received: from sonic.gate.mail.ne1.yahoo.com by sonic322.consmr.mail.ne1.yahoo.com with HTTP; Mon, 21 Oct 2024 18:18:26 +0000 Date: Mon, 21 Oct 2024 18:18:23 +0000 (UTC) From: Pedro Giffuni To: "maxim@freebsd.org" Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-ID: <1791968192.4471640.1729534703845@mail.yahoo.com> In-Reply-To: <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru> References: <202410161840.49GIe8CR000407@gitrepo.freebsd.org> <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru> Subject: Re: git: b88df1e893c4 - main - Reapply "sbin/ping: allow normal users to specify larger packets" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_4471639_1666353488.1729534703844" X-Mailer: WebService/1.1.22806 YMailNorrin X-Spamd-Result: default: False [-3.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, DKIM not aligned (relaxed),none]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:36646, ipnet:66.163.184.0/21, country:US]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[66.163.189.31:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FREEFALL_USER(0.00)[pfg]; RWL_MAILSPIKE_POSSIBLE(0.00)[66.163.189.31:from]; FROM_HAS_DN(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+] X-Rspamd-Queue-Id: 4XXNpr2HShz4Cbw X-Spamd-Bar: --- ------=_Part_4471639_1666353488.1729534703844 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sorry ... I completely missed this was causing any trouble. My filters threw the repl= y into a folder that I don't look at regularly. Thanks to markj@ for backing it out.=C2=A0 Pedro. On Friday, October 18, 2024 at 02:41:12 PM GMT-5, maxim@freebsd.org wrote: =20 =20 Hi Pedro, Unless you have a plan to address this issue please backout this code as it is clearly wrong. Thanks, Maxim On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote: > Hi Pedro, > > No, this is not right.=C2=A0 Let me clarify: > > (1) I never told that there are any issues with the tests.=C2=A0 I just > mumbled that the tests should catch such regression though I never > checked if they actually did. > > (2) The MAXPAYLOAD calculation in the code below is not fully correct. > > It should be > > 65535 - 20 (ip header) - 8 (icmp part) =3D 65507 without IP options > > OR > > 65535 - 20 (ip header) - 40 (ip options) - 8 (icmp part) =3D 65467 with > IP options, ie. whenever you run ping -R. > > The code below hardcoded the latter value which is simply wrong. > > I wouldn't rely on the fact that you get it from other BSD flavours > and would recommend to have this code reviewed before committing it. > > Maxim > --=20 Maxim Konovalov =20 ------=_Part_4471639_1666353488.1729534703844 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sorry ...

= I completely missed this was causing any trouble. My filters threw the repl= y into a folder that I don't look at regularly.

Thanks to= markj@ for backing it out. 

Pedro.

=20
=20
On Friday, October 18, 2024 at 02:41:12 PM GMT-5, m= axim@freebsd.org <maxim@freebsd.org> wrote:


=20 =20
Hi Pedro,

Unless you have a plan to address this issue please backout this = code
as it is clearly wrong.

Thanks,

Maxim
On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote:
> Hi Pedro,
>> No, this is not right.  Let me clarify:
>
> (1) I never told that there are any i= ssues with the tests.  I just
> mumbled that the = tests should catch such regression though I never
> ch= ecked if they actually did.
>
> (= 2) The MAXPAYLOAD calculation in the code below is not fully correct.
>
> It should be
>= ;
> 65535 - 20 (ip header) - 8 (icmp part) =3D 65507 w= ithout IP options
>
> OR
>
> 65535 - 20 (ip header) - 40 (ip optio= ns) - 8 (icmp part) =3D 65467 with
> IP options, ie. w= henever you run ping -R.
>
> The = code below hardcoded the latter value which is simply wrong.
>
> I wouldn't rely on the fact that you get it= from other BSD flavours
> and would recommend to have= this code reviewed before committing it.
>
> Maxim
>

--
Maxim Konovalov
<= /div>
------=_Part_4471639_1666353488.1729534703844--