From nobody Fri Oct 18 21:01:18 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XVcZP729Fz5YxDl for ; Fri, 18 Oct 2024 21:01:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XVcZP26W7z4LrP for ; Fri, 18 Oct 2024 21:01:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-37d6a2aa748so1668741f8f.1 for ; Fri, 18 Oct 2024 14:01:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729285292; x=1729890092; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4seM3F9JepdhIH1EB+H6nbrqWlRvydsibLjPqLeUEp0=; b=r6wOmrTMB7nml1heHKhxNmHrY6Dn8yqcjYEzWh2EAXBACGFatA0Odf1qyjO/d5G5mN NfiuQ0JrMySHXDycq4j8/rfPQ3nlZqjpysinhKP7gFJipiRlbkSE3M++XUYZOQrrqHRO R2vffM4F4kry6lxkhC8h4mvL9q7eCsPzcJBp3GOA72CHIFM4/o6nXhQGl4owmZAsfAO5 Ch58OerW2VXjt8jFVrjK+5CRQQf9EECcRlREFzC5HqFEw7owdZAotsTopKCgx7Y+SIKZ 8QAWAN1fQ1zYDdnrXStNTPeBUJ2yOWukKAy7Xsmb2qWjWGqtqCubiu1rSz6Y28c7BnxA ZmVw== X-Forwarded-Encrypted: i=1; AJvYcCVYt55bsRhhpJ6CkZAzSbcqH8Vy1WZMdPDFNLDjeMMFAYf+1L2nnRB3g1wNPHBYt0brLqVsiNZETa3dBRixbLTuD5ij+A==@freebsd.org X-Gm-Message-State: AOJu0Yx2sZz5XEAaq1e+I534OyUUwiTf+cPo7xg181mhmjRktWwO/T9s utdzeHcMXHr+GODc7aNh6fRdsMFna2Y/LVhJFaiZOxKXd5iGUqhfAh98wB7O2qc= X-Google-Smtp-Source: AGHT+IHvjKI+ep/i8LfTX2T53+sh+BCbGpWrrlI0m0b9oitTQY/F/IJLv3FYQMol/n2VVKfug0heSA== X-Received: by 2002:adf:f490:0:b0:37d:48ee:d6fc with SMTP id ffacd0b85a97d-37ea2137158mr2330655f8f.7.1729285291247; Fri, 18 Oct 2024 14:01:31 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4316068d08dsm36609365e9.15.2024.10.18.14.01.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2024 14:01:30 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: git: 4f2ca36c7bec - main - arm64: Disable coverage sanitization of `pmap_update_strided` From: Jessica Clarke In-Reply-To: <202410111653.49BGrin3091045@gitrepo.freebsd.org> Date: Fri, 18 Oct 2024 22:01:18 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <92030090-11B4-484B-8FD4-6B92F34FD717@freebsd.org> References: <202410111653.49BGrin3091045@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Spamd-Result: default: False [-2.40 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEFALL_USER(0.00)[jrtc27]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_HAS_DN(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.51:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.51:from] X-Rspamd-Queue-Id: 4XVcZP26W7z4LrP X-Spamd-Bar: -- On 11 Oct 2024, at 17:53, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D4f2ca36c7becd20b21ce5ef7256bbd42= f732dafe >=20 > commit 4f2ca36c7becd20b21ce5ef7256bbd42f732dafe > Author: Zhuo Ying Jiang Li > AuthorDate: 2024-10-11 16:41:49 +0000 > Commit: Mark Johnston > CommitDate: 2024-10-11 16:52:53 +0000 >=20 > arm64: Disable coverage sanitization of `pmap_update_strided` >=20 > The break-before-make update invalidates PTEs, including the PTE > pointing to curthread, causing a fault in `trace_pc`. This > addresses a similar issue in > 01bb9a2a3557bc9389f628d301cd691e08266f1d. This broke* GitHub Actions due to the use of Clang 12 (newest Clang in Ubuntu 20.04 LTS which isn=E2=80=99t EOL until April 2025) which = doesn=E2=80=99t support this sanitiser. Probably the easiest thing to do is to leave the relevant __nosanitizefoo defined to nothing unless that sanitiser is actually enabled (via __has_feature), as it=E2=80=99s not necessary = outside of that, and if it=E2=80=99s enabled then you know it=E2=80=99s = supported? Jess * Masked by the OpenZFS import breaking it earlier in both commit history and build order