From nobody Fri Oct 18 08:44:49 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XVJDK1hmQz5YwB3; Fri, 18 Oct 2024 08:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XVJDK1Ftpz4mB2; Fri, 18 Oct 2024 08:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729241089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zMIDAsymj+dluVkiOt9L53o8Bg4lLPyQk7O4Kt1fuWw=; b=ZJXE+C8Srp0TKc2IMC2ZezuEuir2MArrSTzfolJ6uufZbutTv86EX5FUXzQMyPs59D4TeW i39JCW9tmzZsn79nGcaNAIJqK9oCRp6qlHjPV2FQUzTx9yefa4fyCU5hff/r5Jpul7cwsw nwJRW3pBYavCxXUmBTEQIYfj+6tSgLHX++XeYuoQ2WMJtnCinecG/0ql7M4oTOpkEJ5sTr zL6985p9Okb0xsfIEi4onhyxwmMtoBbhZ6gb37PFPPozX0AyV6rbdRQxzcfy7mr1G4Y5oh pBLQ06fYA8q08Lv6CgasJao6jrqRABFYhiq+cjXDEOBk1OMdF4s/VX4mY5rp9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729241089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zMIDAsymj+dluVkiOt9L53o8Bg4lLPyQk7O4Kt1fuWw=; b=C6zgQspFNVrQ/ZV2Mq7lERBOyfzaUwKPspJaNvUwWolsrPDqD3mZIOOizcCxV6jNJk9dUq L2wNyHySjDsvHrMzllR4BcB3WPOJo3YjDPozfGl03amznXK93sSMhZ/jS2irqMCVYZIwZk Xy7A84cDJ50XvFaVGn6iPm7y06ms2C67r5U2cl0wvoOt2w0rO4wWPihsZTdvXUgCJS5j1H m/Csh0x+vcesGi9bhp+YrHy49o7iIfUwup65p/BnbxiUhU8jhB24xOpQ9Pe0ogn6wgBWId 1V/E2H/a+KqEmnxQw2cHkkX9rxNmI761MjqJsCgw6gW9nhPkaTug2bGS3kG7og== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729241089; a=rsa-sha256; cv=none; b=osvPjs4PLWvVjKjn/44DTXqRQK3+SM5ZimGySnMo4In8hMI7BB4uPbbf2CsTsdQj/v3Ml5 gy7Tyku7wdVhNRaSGF8oCNqDBx9q4FTreknjtqaCQdUY/6/gybcfb7pNfJyCVNO1BgVUxY m/02Hq+snvSiVH8RV0ZZZHtgGf5jL/2utEaNFkSiQn7hwSwQ5eQeBquZk0e0sRMnTCT5Xe pYnXiU2Ql+zWWxw6iyiUS6AKYx7ATZe1KxcvwdDmkG8H1H00rQE6C8gO8q8gg4iwPhJVnu BjscuUb1+BHOc2GSxTpmbirB4ku54xJLcnLS0H3pf3BGEK+etZSRf2pc/AU0aQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XVJDK0rx2zRgt; Fri, 18 Oct 2024 08:44:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49I8in7N087636; Fri, 18 Oct 2024 08:44:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49I8inCX087633; Fri, 18 Oct 2024 08:44:49 GMT (envelope-from git) Date: Fri, 18 Oct 2024 08:44:49 GMT Message-Id: <202410180844.49I8inCX087633@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 998de46c5145 - main - sound: Remove KASSERT from vchan_setnew() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 998de46c51452b046ecd9ba8ed592dd7c4f79f51 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=998de46c51452b046ecd9ba8ed592dd7c4f79f51 commit 998de46c51452b046ecd9ba8ed592dd7c4f79f51 Author: Christos Margiolis AuthorDate: 2024-10-18 08:38:31 +0000 Commit: Christos Margiolis CommitDate: 2024-10-18 08:38:31 +0000 sound: Remove KASSERT from vchan_setnew() This check is not really useful, and can in fact break things, if sysctl_dev_pcm_vchans() calls vchan_setnew() with a value that will not satisfy the KASSERT condition. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, emaste Differential Revision: https://reviews.freebsd.org/D46545 --- sys/dev/sound/pcm/vchan.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/sound/pcm/vchan.c b/sys/dev/sound/pcm/vchan.c index fa4fa2023b71..c1ad9b9ec2ba 100644 --- a/sys/dev/sound/pcm/vchan.c +++ b/sys/dev/sound/pcm/vchan.c @@ -945,9 +945,6 @@ vchan_setnew(struct snddev_info *d, int direction, int newcnt) return (EINVAL); if (newcnt > vcnt) { - KASSERT((newcnt - 1) == vcnt, - ("bogus vchan_create() request newcnt=%d vcnt=%d", - newcnt, vcnt)); /* add new vchans - find a parent channel first */ ch = NULL; CHN_FOREACH(c, d, channels.pcm) {