From nobody Wed Nov 27 20:41:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XzBDh4rg6z5flSx; Wed, 27 Nov 2024 20:41:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XzBDh4MFGz4LTX; Wed, 27 Nov 2024 20:41:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732740084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qolai6++Mw6X6VQwZIbcBIOGdSdaStSVHx5LunH+s+k=; b=rnxxB1vcLmbMVhHB+tnUmycb0XjwjtwGFzGmXCWVLzPMiBX4N4PP6dAwATKFtyPq5qKEFN 7a3DGxaB0F9cfhHDMIWnG/jL23Dl8kjUjEJa/cz3E//1Yu+Ivks0i6Jpr236ZhjpiKfhPW M4R0My5dVCrQGLwgzG2+0FMFdfHctLPTOXY2wuaSwh1nDOm7gnyN52YPJgUkAnhn3Gzse9 Dpk7w6VBppkzYYl3Acf+fzXTBYxzEu1XiFgTu2i5ho9cjzJPkoTNobawGKoytIAWT9rhyf ZYhExmWxFneAdopXTSc7kiGHbZ6ecj0QtHJYIZxeOtDRnoaW+o/Tq/9NBTx6bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732740084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qolai6++Mw6X6VQwZIbcBIOGdSdaStSVHx5LunH+s+k=; b=tFIG8iRhLvL3iCDh206DKln/AHv1eHMlEnhDN/9PllyIVLkua+q3pIU5k6avLXEw4yK5+S gYGludyOtsArysRJ1aAI9zl9CD+SnVw16CSfqlSjmIbY6pw/EYtsB44OJzIr3rj9K2jmOc kbUxwWUso+aNmvnWyWAe0lOZsRKNnuLElL2Zn5Avr0/72v+he2+plnuDbi+7zYfL3DTY21 TZLIP2WYc/DqObBG7VVoO2dfGfupGXucCbkHGEblyODYheJwbAsR0k+0axW3TQstdgGrx1 Na7LsaWWds+nHoxgzQz1XvyxjTP7ssqQQ5fbg3PDHmuui62SdVnW9pHk2500Fg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732740084; a=rsa-sha256; cv=none; b=B1ik9Q8BQ0fCMLESGNAh1aSmafxe09ysiAN2n8hVhnASjq+hnoPNRHpYDg+xzZzPkuZRIj x+/jJNpIwCkVKty+MY0cM0LtlVsdnz1EJxMSe8yCVicJVjA7kA3sgH4wRe2IxAQyqGG716 Jxfm7DlHwgoHUDSx0FuNR9cgwrIeoTNDhK5dH21KjqjweAlb8LaIt+cqU9MKCFL2H5Wg6x mtWCmLUKqyX4FdaQ5J3flm7k51GLUJVcfcLY5JCMiJtS7z1TqElqe+WkOMNLktccrH0CyA sWQKB02PYRFnarCMpKRU7/7/e0huhS/cqYciei7Vusc6HnPI7WpjM1KoNzby/Q== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XzBDh34l4zNcT; Wed, 27 Nov 2024 20:41:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 1BD861E5EA; Wed, 27 Nov 2024 21:41:22 +0100 (CET) From: Kristof Provost To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 45d108ee147c - main - pf_route6(): one more __sdt_used annotation Date: Wed, 27 Nov 2024 21:41:19 +0100 X-Mailer: MailMate (1.14r5937) Message-ID: <9D315CFB-35BD-43FD-AAED-3FFF5E6B13E6@FreeBSD.org> In-Reply-To: References: <202411271431.4AREVRbs047403@gitrepo.freebsd.org> <5F91DA38-12C0-412C-9430-7632A0BBB763@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27 Nov 2024, at 16:25, Konstantin Belousov wrote: > On Wed, Nov 27, 2024 at 04:10:21PM +0100, Kristof Provost wrote: >> On 27 Nov 2024, at 15:31, Konstantin Belousov wrote: >>> The branch main has been updated by kib: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D45d108ee147cc8776a6595= 78da585b31a0ba5643 >>> >>> commit 45d108ee147cc8776a659578da585b31a0ba5643 >>> Author: Konstantin Belousov >>> AuthorDate: 2024-11-27 14:26:53 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2024-11-27 14:30:52 +0000 >>> >>> pf_route6(): one more __sdt_used annotation >> >> Thanks! >> >> I thought I=E2=80=99d fixed that when you reported the initial problem= , but clearly I missed one. >> >> I wonder if we shouldn=E2=80=99t remove options KDTRACE_HOOKS from at = least one kernel config to improve the odds of catching mistakes like thi= s one pre-commit. >>> From MINIMAL maybe? > > Perhaps it should be removed from LINT. > Initial idea around it was that LINT should complement options > in other kernels configs, I believe. https://reviews.freebsd.org/D47821 I=E2=80=99ve also created https://reviews.freebsd.org/D47822 because it t= urns out that removing only KDTRACE_HOOKS doesn=E2=80=99t actually build.= Best regards, Kristof