From nobody Mon Nov 25 22:22:22 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xy0Z84s8Yz5fJ1X; Mon, 25 Nov 2024 22:22:24 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xy0Z84PHNz4Jkt; Mon, 25 Nov 2024 22:22:24 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732573344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IFQ0BxzEug7tdKG0NOXlZTPMNeVvVVzyHhkhp2T3q88=; b=lvSJYg4saLYJnmpp3+6y6RjDUPazH3vG+9Emc5WFvtqz2pVFAu0PpXDlTPgqlbDEcJvSfg 64lYc29OxFxUOpMtjB+B33rj9POU/ozorbeH6Ji8NHWWK8bvkA5CXbreBaMXXg7DI+Ktbx kBvhkf2RS3gF1ZPjdeeJWBLDovxXuhnVkJdWS3TR8fJn6wwSbhcbfy+SSqsbOsWdnWQ9tI hiZGIpkC3ENKsx4eKQxgaSSpHItp22ekse9EUbgDY/0qGWps9aHGVZZg9YxvWxBrz01eYQ vp4+mgUN2wDa3XwvFevr132YNULSw0MopN6anmfCvxvMoWGxF2g5Ahf5ySLmtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732573344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IFQ0BxzEug7tdKG0NOXlZTPMNeVvVVzyHhkhp2T3q88=; b=LFbX0Scvt0CXSuQd4vhtDPFXKppBjAsdVQdxLihv1SlGqpToDn5awZvjmpHVg0eGrRICpn 84HCSNVEo+3x85rNlT3cARvjf0+ro8qewYLjWXMeX4yAu+nGJUe7GGCvJBm1WO6mtuOY0m v2Tfvp8dRKXd64QEBTOLz81eLU3cwkEpkNCPypK3OSBa/Qrj+ZwWOGtn2qiIEcluTAoceP e+i0HPQwip/7Uxgp/kt5mC0NRDgyz0+gbZEniWw8pxZP+dwiErxE7lM5QqzL5dDjkMoN0x 4dCgJqsC1X5g4Kf5wIFLlfZAhyhjH7Pd+RF8jqQbG5C+cGUmw0bNqNWg7gd+vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732573344; a=rsa-sha256; cv=none; b=QoQq5maXAvNjCAHHW91myX/5pV4AOooupbZM8s44HU+1XVGcfUP4ig71In1ioH7NyuLGO0 bSblyF0FqVvBzAk85p9ykgrR2X34ryx9DUeyZxuC7ld/iYG9dDGsp+66f5aVzisONy20k4 YNSwM9IBFhLDD8U4f5ObJhYOY8deC6nKVvky4MbNixRgUctvIDoV+OA88Ai00C53IoNU+Y H/vb+1SSBFwUVaMovHlE3JDwWkpLYqLNMw9oxbD3bjvCqn6aWYTChJp+eqCT35Wj3SPXcz YLDGQVvSYPePIPCzo/n+78s337o9roDe1n2RobJ91Yv1+xHm6Bfd4T2E6gAWaA== Received: from [192.168.119.155] (p5dc83ef4.dip0.t-ipconnect.de [93.200.62.244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xy0Z76hvHzNrG; Mon, 25 Nov 2024 22:22:23 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <4808a71f-a12b-4e70-ad51-a7979f5dff08@FreeBSD.org> Date: Mon, 25 Nov 2024 23:22:22 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: =?UTF-8?Q?Stefan_E=C3=9Fer?= Subject: Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> <86r06zcnb7.fsf@ltc.des.dev> Content-Language: de-DE, en-US Autocrypt: addr=se@FreeBSD.org; keydata= xsBNBFVxiRIBCADOLNOZBsqlplHUQ3tG782FNtVT33rQli9EjNt2fhFERHIo4NxHlWBpHLnU b0s4L/eItx7au0i7Gegv01A9LUMwOnAc9EFAm4EW3Wmoa6MYrcP7xDClohg/Y69f7SNpEs3x YATBy+L6NzWZbJjZXD4vqPgZSDuMcLU7BEdJf0f+6h1BJPnGuwHpsSdnnMrZeIM8xQ8PPUVQ L0GZkVojHgNUngJH6e21qDrud0BkdiBcij0M3TCP4GQrJ/YMdurfc8mhueLpwGR2U1W8TYB7 4UY+NLw0McThOCLCxXflIeF/Y7jSB0zxzvb/H3LWkodUTkV57yX9IbUAGA5RKRg9zsUtABEB AAHNJ1N0ZWZhbiBFw59lciAoRnJlZUJTRCkgPHNlQGZyZWVic2Qub3JnPsLAlAQTAQoAPgIb AwULCQgHAwUVCgkICwUWAwIBAAIeAQIXgBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJmvl9B BQkTLNNOAAoJEEfrte9a/fVEV1oH/jt+SjRqTHci6d1LiFDfbY0E2rfobZw5BhcQuCqxahS7 pcE1oLpUaoqWYPHslxhGTl7QSD2twMWcHLonZ1lgTJluMZqgTX9uvqEYDUtiH6G+IF7Qacat eUsAvwdycItPOr3p7WBt8U54GbnQdxpSUQ0OpD4twy7KAt/MPNLofVQSEea5DNQOH2dXILrf iRsNfFPsfTASOUXOTRyTYwm6Ys76LIdL9GA2iR5qw8G43FB02fiX76WQSjg+yKN9iP9racGg Pc8qkSPwHJr0s3OwJC4ndbCuSiaXddDbgOvdrqfSO0XCjo3ylyEBhmMVMpwkj8pLCKVGS73n Ncs6OujZXAzOwE0EVXGJEgEIALEj9qCXMZVucjpcd3QxM/TlUr98m5viEd1z4tCnPUyRWcIC EVtj2h5xMH+2iB0q1+KWhq+NsWtvScmEmfHnsr7dJ1K677OdpDhKVaJk61eeRulFY1R4yb6C 1MMxK+WgYB+vvpG0UeyR0M4uBewcPvRsq4yGUHFQKtLAbMdoPTSryJA+ElnmK1vdY+rPcHgi OIMBZM7ahsPXC0C9K4e5SP9clGyIoMpbfHXdx9q+Rp3zVtlbhyk3BS/xccu/+9pk9ICXL6GR js2sNnJ0wxdU1DsAlC59a5MnSruwiZFwRnkQhr3x6wk97Lg7sLS9jjTnCN7LGlVmSmpOEMy6 uq1AWfUAEQEAAcLAhgQYAQoAJgIbDBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJmvl9BBQkT LNNOABQJEEfrte9a/fVECRBH67XvWv31RCrvCACY7fjahcGj/57peFu0oIb4X9X78H6mgrAZ D5HCCCb2vWdNtSDTYQoYnKP2Fz9RUG8ETT9a6CtymYqQc72/dzjJmakRTlbYhliKJDZXGAYU g34VirGXCjYgWH7l+0CupOtt55R/ASnrnXX9R/7PLO+akObn9Cz/bNBnIbYnTjLNs7GMMQL4 uNSyqIByQ3LVsVDaCq3408fYKC0dtlv2VNQQzcXXwOgecwpS2UeqMflrSA7UfPh15WgkpnrN AnKCtS66eU1w2kTCsVEjGQEgLI5pP1HMNRHjnHncAFSpOfs1EZn0MfhiyB+4T+lrccGI8EZu ay791Tx4QdDKkdZGaV9A In-Reply-To: <86r06zcnb7.fsf@ltc.des.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 25.11.24 um 17:04 schrieb Dag-Erling Smørgrav: > Stefan Eßer writes: >> The branch main has been updated by se: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=8ea6c115409450ff58a8c6b5e818319d181c6bff >> >> commit 8ea6c115409450ff58a8c6b5e818319d181c6bff >> Author: Stefan Eßer >> AuthorDate: 2024-11-24 21:38:23 +0000 >> Commit: Stefan Eßer >> CommitDate: 2024-11-24 21:38:23 +0000 >> >> usr.bin/bc: remove OpenBSD derived bc and dc commands >> >> In 2020, an improved implementation of the bc and dc commands >> developed by Gavin D. Howard has been imported into FreeBSD. >> It has replaced the OpenBSD-derived versions of these commands >> in all currently supported FreeBSD releases. >> >> The OpenBSD versions could still be built using the WITHOUT_GH_BC >> option. There have been no reports of problems or unexpected >> deviations from the OpenBSD version for some time, therefore >> keeping the OpenBSD version is no longer required in FreeBSD. >> >> This commit removes the option to build the OpenBSD version and >> corresponding source files from -CURRENT. No MFC is planned, all >> currently released FreeBSD versions should retain the build option. >> >> The WITHOUT_GH_BC option is no longer accepted and will cause >> make buildworld to fail. >> >> Reviewed by: des, emaste >> Approved by: des >> Relnotes: yes >> Differential Revision: https://reviews.freebsd.org/D46876 > > I appreciate your efforts but this is incomplete, as was pointed out in > review. I was not aware that the review was incomplete (but have learned about the missing removal of tests/usr.bin/dc, meanwhile). The diffs where not all with full context, but this did only affect files like ObsoleteFiles.inc, which had to be regenerated with an updated date for the commit of these changes, anyway. Are there any outstanding issues you know about? Regards, STefan