From nobody Mon Nov 25 16:03:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xxr8S0zBxz5dpw4; Mon, 25 Nov 2024 16:03:04 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xxr8S0Tk5z47fT; Mon, 25 Nov 2024 16:03:04 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732550584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dk1F2UeQEiVk6yP7jvaxpbjcBpBKpFORYrYDCHSJ9Jw=; b=xCe438S9oWl/ZarkltTHZbnofmfJOUxVcGqUxC6TEIYFXM9XmDXerqOLUQwOJXHbxap8PL 3ojLxsiu5j/ysY9gJybOnt2QiON/PGpApfm9hoprZBgl8B7roqRx/CPs2AKO2vShaWl3B+ qEWuzHCjl4+mLzW+1GKL0Pientpp9Rdom5zNmLfeN1VUU31IWXJMAf5ulwmkICfCmpy4+m UF16k9ESCkskAwi1BdD8Tx04HZvAHtSTPRo/eifKBCX7KCmiegbyh9xAw+C60VsmDGGq3O sbHs4qBAbFVItYNOcgx51vxWs7S7uhoX1z9tHk7IRNznlSHMLd9dOc7+ykz73g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732550584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dk1F2UeQEiVk6yP7jvaxpbjcBpBKpFORYrYDCHSJ9Jw=; b=Ue1E6BVzN/g4etlpbbbe4R8sekwC3w1h3u2wTQCesytdY7b/LCkJgTUGxqo0vFp/BrBifH WoHyTiHsNoLQVshMpzoab6SLDtKaa2WfzZBwtdgYVm1UUjdnanlRgY9wyxK7XTTqjf74gX vUhOwV8aLzcNy3kLqoB3xe8mrfvSunj/iz7P8TainIl0sxozQSpIjMM/tCUKEkITaP9yiB gWOgqBwwKmJpouLgW5AwvnkhJqa8kJKUEaI2llDATF7r5aJplp8F5CL1qHRbZvI1L6/eAf eHVHQ8ugy3zUPnskGd7SpgjvRsd0UEqoxkIVieZflXKm3k8vwCjG3YFDnx3iOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732550584; a=rsa-sha256; cv=none; b=PiIcTFdrz5cl6xG56eoNIWhgqyu1w1Gf9JSLoOnB7FUaomud2/qHrpl/VNcjzvf7TPr7gS eGLihCckeEsrmhBCxfIxA0G6zuow5MsU+Gl8bVnVj1sHl20eoJkLdm8l9i1zqhxczZSAEG 0JLfQdkvV8xEnMHVb0eO6PAHScgsq1mja8ebB6r/42lAKolFZ/0c0yx4GMMGVAFoHvbk5g q6d8ITj+Dp60T61gDVMKqLpJPwfbGEbr2tyZbmNzZkPGx3UiW53G9cxLqFo1RTH3nA9+oC AP7HVbFR6jV1WdMcK7imZu8xCu39fV1sSF05z7I4QzwYb1ikQusW69ugI+d9nA== Received: from [192.168.119.155] (p5dc83ef4.dip0.t-ipconnect.de [93.200.62.244]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xxr8R2j5lzF0D; Mon, 25 Nov 2024 16:03:03 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <0ebd8c52-77f5-418d-8244-d9abaccb7e6c@FreeBSD.org> Date: Mon, 25 Nov 2024 17:03:02 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: =?UTF-8?Q?Stefan_E=C3=9Fer?= Subject: Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands To: Kyle Evans , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> <7c698cf4-ed41-4b15-8388-8d826b380ec2@FreeBSD.org> Content-Language: de-DE Autocrypt: addr=se@FreeBSD.org; keydata= xsBNBFVxiRIBCADOLNOZBsqlplHUQ3tG782FNtVT33rQli9EjNt2fhFERHIo4NxHlWBpHLnU b0s4L/eItx7au0i7Gegv01A9LUMwOnAc9EFAm4EW3Wmoa6MYrcP7xDClohg/Y69f7SNpEs3x YATBy+L6NzWZbJjZXD4vqPgZSDuMcLU7BEdJf0f+6h1BJPnGuwHpsSdnnMrZeIM8xQ8PPUVQ L0GZkVojHgNUngJH6e21qDrud0BkdiBcij0M3TCP4GQrJ/YMdurfc8mhueLpwGR2U1W8TYB7 4UY+NLw0McThOCLCxXflIeF/Y7jSB0zxzvb/H3LWkodUTkV57yX9IbUAGA5RKRg9zsUtABEB AAHNJ1N0ZWZhbiBFw59lciAoRnJlZUJTRCkgPHNlQGZyZWVic2Qub3JnPsLAlAQTAQoAPgIb AwULCQgHAwUVCgkICwUWAwIBAAIeAQIXgBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJmvl9B BQkTLNNOAAoJEEfrte9a/fVEV1oH/jt+SjRqTHci6d1LiFDfbY0E2rfobZw5BhcQuCqxahS7 pcE1oLpUaoqWYPHslxhGTl7QSD2twMWcHLonZ1lgTJluMZqgTX9uvqEYDUtiH6G+IF7Qacat eUsAvwdycItPOr3p7WBt8U54GbnQdxpSUQ0OpD4twy7KAt/MPNLofVQSEea5DNQOH2dXILrf iRsNfFPsfTASOUXOTRyTYwm6Ys76LIdL9GA2iR5qw8G43FB02fiX76WQSjg+yKN9iP9racGg Pc8qkSPwHJr0s3OwJC4ndbCuSiaXddDbgOvdrqfSO0XCjo3ylyEBhmMVMpwkj8pLCKVGS73n Ncs6OujZXAzOwE0EVXGJEgEIALEj9qCXMZVucjpcd3QxM/TlUr98m5viEd1z4tCnPUyRWcIC EVtj2h5xMH+2iB0q1+KWhq+NsWtvScmEmfHnsr7dJ1K677OdpDhKVaJk61eeRulFY1R4yb6C 1MMxK+WgYB+vvpG0UeyR0M4uBewcPvRsq4yGUHFQKtLAbMdoPTSryJA+ElnmK1vdY+rPcHgi OIMBZM7ahsPXC0C9K4e5SP9clGyIoMpbfHXdx9q+Rp3zVtlbhyk3BS/xccu/+9pk9ICXL6GR js2sNnJ0wxdU1DsAlC59a5MnSruwiZFwRnkQhr3x6wk97Lg7sLS9jjTnCN7LGlVmSmpOEMy6 uq1AWfUAEQEAAcLAhgQYAQoAJgIbDBYhBKNx6mWcC+zIK3FTE0frte9a/fVEBQJmvl9BBQkT LNNOABQJEEfrte9a/fVECRBH67XvWv31RCrvCACY7fjahcGj/57peFu0oIb4X9X78H6mgrAZ D5HCCCb2vWdNtSDTYQoYnKP2Fz9RUG8ETT9a6CtymYqQc72/dzjJmakRTlbYhliKJDZXGAYU g34VirGXCjYgWH7l+0CupOtt55R/ASnrnXX9R/7PLO+akObn9Cz/bNBnIbYnTjLNs7GMMQL4 uNSyqIByQ3LVsVDaCq3408fYKC0dtlv2VNQQzcXXwOgecwpS2UeqMflrSA7UfPh15WgkpnrN AnKCtS66eU1w2kTCsVEjGQEgLI5pP1HMNRHjnHncAFSpOfs1EZn0MfhiyB+4T+lrccGI8EZu ay791Tx4QdDKkdZGaV9A In-Reply-To: <7c698cf4-ed41-4b15-8388-8d826b380ec2@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 25.11.24 um 15:25 schrieb Kyle Evans: > On 11/24/24 16:08, Stefan Eßer wrote: >> The branch main has been updated by se: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=8ea6c115409450ff58a8c6b5e818319d181c6bff >> >> commit 8ea6c115409450ff58a8c6b5e818319d181c6bff >> Author:     Stefan Eßer >> AuthorDate: 2024-11-24 21:38:23 +0000 >> Commit:     Stefan Eßer >> CommitDate: 2024-11-24 21:38:23 +0000 >> >>      usr.bin/bc: remove OpenBSD derived bc and dc commands >>      In 2020, an improved implementation of the bc and dc commands >>      developed by Gavin D. Howard has been imported into FreeBSD. >>      It has replaced the OpenBSD-derived versions of these commands >>      in all currently supported FreeBSD releases. >>      The OpenBSD versions could still be built using the WITHOUT_GH_BC >>      option. There have been no reports of problems or unexpected >>      deviations from the OpenBSD version for some time, therefore >>      keeping the OpenBSD version is no longer required in FreeBSD. >>      This commit removes the option to build the OpenBSD version and >>      corresponding source files from -CURRENT. No MFC is planned, all >>      currently released FreeBSD versions should retain the build option. >>      The WITHOUT_GH_BC option is no longer accepted and will cause >>      make buildworld to fail. > > What does this mean?  It's not clear from the diff; it looks like you just > removed the option, which generally doesn't mean 'make buildworld' will fail if > the knob is exercised -- just that the knob doesn't do anything.  Was this just > supposed to mean that it's no longer accepted because it would have caused > buildworld to fail? Hi Kyle, I must have been wrong about WITHOUT_GH_BC now causing build errors. I suspect there was a problem with this option in /etc/src.conf while I was preparing the patch, but I don't remember any details. I wanted to warn that this option was a possible cause of build failures, but it seems that warning was unfounded. > > [... snip ...] > > >> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >> index 1378d6b6dcfa..5362ba0e5955 100644 >> --- a/ObsoleteFiles.inc >> +++ b/ObsoleteFiles.inc >> @@ -51,6 +51,13 @@ >>   #   xargs -n1 | sort | uniq -d; >>   # done >> +# 20241124: library and tests of OpenBSD dc >> +OLD_FILES+=usr/share/misc/bc.library >> +OLD_FILES+=usr/tests/usr.bin/dc/Kyuafile >> +OLD_FILES+=usr/tests/usr.bin/dc/bcode >> +OLD_FILES+=usr/tests/usr.bin/dc/inout >> +OLD_DIRS+=usr/tests/usr.bin/dc >> + >>   # 20241119: rewrite mv tests >>   OLD_FILES+=usr/tests/bin/mv/legacy_test > > This seems to have missed removing the associated mtree entry in ^/etc/mtree/ > BSD.tests.dist. Thank you for pointing this out! I have removed creation of tests/usr.bin/dc in commit aa308b49e3a1. Best regards, STefan