From nobody Mon Nov 25 14:25:38 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xxp0563MYz5dgxX; Mon, 25 Nov 2024 14:25:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xxp054Xmrz58Fb; Mon, 25 Nov 2024 14:25:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732544741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bbJ+R42U51QP3Fs+YR+FXmUxeF0Dc81BtTW7tkmYzJw=; b=xVPx/YpyhmVwQMKEHh/leL/l86DxTrtyudbfBpbV0Ufkxig12VQhTIvzsah4Q+9Er/xNox zSt1byoEIgEkm2XE7gq8jFxSR/XR+N90iFfN5OI9yPNcFr+dgddQ3Q/UiZZhQipEpvlnsC MrMXzMYhN10cuNn6QsaYQdCNcRwnM3ptPddKImnFcQGbpkldy5QeGvGtGN+Y7ZkIPf8vyO 0ykVaNSMhZJWDjVs6Sk8deN9IzKoOxujcHFGs1TIMkQEwJOR/Wek3iN3qCOJwnYFf77708 N+ZnS/EpnLoNCqdRMPPw6uiKqE6/B9RJ9SinwCP+s+TFCKnvQRGvXGrtoHtKhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732544741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bbJ+R42U51QP3Fs+YR+FXmUxeF0Dc81BtTW7tkmYzJw=; b=xAp6BIH0peczxOrEjPV7q0EPiqTkK2C8KjxJCWi818tZJMU+A0irOL97SzSTexF30O8xtm re/bO+hdaHT8C7JA5ysLs+k1esOeVH7oSxmros0DGrgpqI8WVFARwYp/WA1CWcGsvDywJ8 Bd6Ret6xY1njwvdQPGGPLFQWk6Sopjd2Jh/ibc004bxKXob40W6yRwImbASdf7SUN1s7+g NsU1Pq7PBAjVRwC+Go8PO72Lb1og+q48zAQp/g1WGAAqW4Ft+l77zhhfi2WUl0LeROKySh aloB8wnoKbcsFRFMddPEKOK9dA81+UyTNOzKSAYEuvbOuPqgFNdJfYHq8Qq1Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732544741; a=rsa-sha256; cv=none; b=RRJFOgpXUsCaRTqcMfQeTKmGeMszCRW8q+xAg+kA/XHHE5+PKfa4BO0bCNvxNHK0dUN2r3 u0iK2lHbVVegbA4qk9iEDFaN35am39BbV9QEogcr0SWNyrkhJBAh6OXyyc+uphpslGBwTd O0IwRkhA88BO3o+Qs6PNvUK0dP5HXNbrgQhmsF6Hc+uLFdbLBotuxAqxKDElJmIVokO/C+ 2p97XrD8b44dflorVeDGiSRkqrTBDS6sgPq6F5bnCd7g/VEqVoy1JUH1ye+WSLn3i23DNU Ve+NhGjpZinlW9qV/vyNKLPWwt97CSq9FFCtX2YqNcZoxbz+/qGCy8TI0TYU/g== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xxp0517Xzz1S2X; Mon, 25 Nov 2024 14:25:41 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <7c698cf4-ed41-4b15-8388-8d826b380ec2@FreeBSD.org> Date: Mon, 25 Nov 2024 08:25:38 -0600 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands To: =?UTF-8?Q?Stefan_E=C3=9Fer?= , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> Content-Language: en-US From: Kyle Evans In-Reply-To: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/24/24 16:08, Stefan Eßer wrote: > The branch main has been updated by se: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8ea6c115409450ff58a8c6b5e818319d181c6bff > > commit 8ea6c115409450ff58a8c6b5e818319d181c6bff > Author: Stefan Eßer > AuthorDate: 2024-11-24 21:38:23 +0000 > Commit: Stefan Eßer > CommitDate: 2024-11-24 21:38:23 +0000 > > usr.bin/bc: remove OpenBSD derived bc and dc commands > > In 2020, an improved implementation of the bc and dc commands > developed by Gavin D. Howard has been imported into FreeBSD. > It has replaced the OpenBSD-derived versions of these commands > in all currently supported FreeBSD releases. > > The OpenBSD versions could still be built using the WITHOUT_GH_BC > option. There have been no reports of problems or unexpected > deviations from the OpenBSD version for some time, therefore > keeping the OpenBSD version is no longer required in FreeBSD. > > This commit removes the option to build the OpenBSD version and > corresponding source files from -CURRENT. No MFC is planned, all > currently released FreeBSD versions should retain the build option. > > The WITHOUT_GH_BC option is no longer accepted and will cause > make buildworld to fail. > What does this mean? It's not clear from the diff; it looks like you just removed the option, which generally doesn't mean 'make buildworld' will fail if the knob is exercised -- just that the knob doesn't do anything. Was this just supposed to mean that it's no longer accepted because it would have caused buildworld to fail? > [... snip ...] > > diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc > index 1378d6b6dcfa..5362ba0e5955 100644 > --- a/ObsoleteFiles.inc > +++ b/ObsoleteFiles.inc > @@ -51,6 +51,13 @@ > # xargs -n1 | sort | uniq -d; > # done > > +# 20241124: library and tests of OpenBSD dc > +OLD_FILES+=usr/share/misc/bc.library > +OLD_FILES+=usr/tests/usr.bin/dc/Kyuafile > +OLD_FILES+=usr/tests/usr.bin/dc/bcode > +OLD_FILES+=usr/tests/usr.bin/dc/inout > +OLD_DIRS+=usr/tests/usr.bin/dc > + > # 20241119: rewrite mv tests > OLD_FILES+=usr/tests/bin/mv/legacy_test > This seems to have missed removing the associated mtree entry in ^/etc/mtree/BSD.tests.dist. Thanks, Kyle Evans