From nobody Wed Nov 20 16:03:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtmPT6YFTz5dRZD for ; Wed, 20 Nov 2024 16:03:41 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-24.consmr.mail.gq1.yahoo.com (sonic303-24.consmr.mail.gq1.yahoo.com [98.137.64.205]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtmPS5hGYz4FLl for ; Wed, 20 Nov 2024 16:03:40 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=XMo6WGTM; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.205 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1732118618; bh=3Uw/gTqzJjkAkwezit2XqrWV1Rk3RjnkvwJE2YjeETA=; h=From:Subject:Date:Cc:To:References:From:Subject:Reply-To; b=XMo6WGTMQHu8CHgsdnVeLufTkLBltiyDCVAEE6MZDIVW2D9jH8WtYZcZ7BMKoN0tGSEVdwyAFSLbktqA2VUS4Luiaja+30iZFTTe7nxissbsWBuKu9XythScLyLtTBJkpcndWPPYXLlfg0J2w65g5a3Zlqioct4uH84JWZkqelFlaL4vqezG+9925oeVl771TAsV62NARndbRFSu9+l6KRO8npqE9ToGCvJIu5c7R104doEOypgey+7ixTNJ0A/1iUSB2EuAGLdyOWqzNcgXA1uKNvjTictGXCPYYBmTG+oMnfyUkLu5EiLh3VcCrlJOyX1KYdb2z0Jn0z6AtNs8xQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1732118618; bh=jF7E8AG/ZJHfsRLNgAAnb928XrzoVOAI2NOX71d/8Ie=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=DalW8lvy8RWvU7n+nxP13Lgz6s1Cy4TiiWyHf8j/diKt01WHVtCEr/wZ/JgevPT7M7/rc654DWADNBpuj5vLyo6VlubMjloSeIg6VNUiHL/u1FbVFVjAvQ/okxENUr22SegqGNsiUWpPyGkVbQ39xT5qoP/rCiaZobxiKz1kQ+YGUMYV1ohQHFMVyhahr92koP0TVoAH+eFDbYmT8etvSPRDC7X6EVvjeAbakHwwyZD+vTj5imh/kWymf3+vTYxuR7Fc6tVSxH2JaS1f0MJyh62wMwsqDxCKSwnRPjpVveptcQGaytHKGSsy/XC1ct5dNd5e21Rj8UkzBksIDj4C1w== X-YMail-OSG: vBeZCIUVM1nGWG37Nh029GulhXylwEU49lITHkovsFDjijCw9K1GualtxkL9hXF mXwjOaWrWFDp5ZdMD3MWjiKiVS0AwLC9IRyrAGK73UF7KgTlecGjr5Qg.n4GaFV8vm9cseZ8rEPt dV2tKRNq8nAnhf6ePWUh1laLwr1YRvRwcGo2qhUOU3o3tesW_4I_CcKQmgjyDXU.HZX8t0UbNb34 6f_gFlvnETctQpwEwwgRrE2Pg4pYBkTHtrjgD6.v54WLBIsJ9vaoO_mir91uGQ3V3KPNJMXLOGJK xbsOmU4c7cw7i_0DmYAW4pg5F3z.7UfYYnN8B_sjVhUNsgpP4oKNXtK9SmqH35sje4P3M0pQia9Q OK4WLgam_bT_9bV.qDfgYCE8ICT3cHWuxUi0BDmaoCjj7skyLajNV8JgUjhumnav5D888qe1EdOq LP0l4oKUmb0X7wiJJPQw1uQXpmebRA1g76mVmPUcebf3z6vl6y7TbQDVzf2Vg23shwafmSMd6w84 BsA0bIPF9HifCwETljtkZv47dSdif1NxL4Kgh3V3OOq3lTYkxeRB4sFJV4GaatBVwiy5C0yEibYf ULuursPqIGruU3h4Qn1OAbo1Kcfg7pjR.baRlVGi7Z2ElosMhHVX8NCAf0CH8str0jHxsYOp4fVV 1uub.0iPhkKujIdM61gcWt05Pe4_lYAkYpEqERqfmuHGy2SUi1CjtIHS1aCMtbRB9JyDEAjAXhZu JkLfqL5E9BKP2Z0W5QYNJK0rVuO97FrvFnZX3g3BofiBXHYlk1a_a1YzvHVO1qfrurhI4af_3w6a .YxkCvzR9FCQTr432vsdv3xp5kkKpKVfPoqIwzu5fywml.JeV.kQYWsr2QSkYay5MKCzMBKyR8Hz TM7YIc9MsYcaAvzZVtllYxrkAY2dFvxzDTxAn0FN9STIjZ9_nwD.kKqEZANA7qfE24Fn9LVDzLz3 OeX5ZGZ6WRJL3MdH_j6P8kDmFlXoi67EFoo1EzyOGTUI8kNsae3OXuZE83HmQeRXe2BBpliEz1HV dhp0kN8ctYR5mTCBeqIY41naOYeeekK8qkXWyk3Z7prKOyfAA99VfZKNJZUYTvzyCEufVVgCjHnc 7Mcu0hYIsbbAtU_j8U.7oPxfMHu36C8T3Dr1GXylgqNR2xjVANwv.j5BAib9tdexdO4oqUc3ruJj EW4T_jEAi2j3Cf0fAs2nsRnlBKxEVSg1ke34S0i.A158k76MRsyZpN0ovlu3hj4sz35IGkdlzsxc g6jcCaeZIDWXMGquHiv52SGGrLX1tmsGh_JNz4WAkj83hEUjtb7MphBFJSqw7JptMi2pyc_tippZ FYBt4s7nVz_ypL1lhkqI7Ai9lWk1KCEdXmHTtpq6d2dP.GCwUKLQx5YWW8y0IT3PfCQHEFADzCT8 JPfESHiKIdL5m.kam0IfNN9M9YnqPyn12bnjmrKhdmey7znrSXKkNoprbLejlt6e3x.R02F4PyEE 1lgn5q3AkdCwIBUxS_ASRJNA2DmYpOUkRbphhSywK5L6EEvD046txsxCgAltOFDFobLe1hFL7Sp6 bvwDzfJCEwxC_M_M.m2AVim.SL0fBLqnE1nrS7geYe72OKxulfhHwgrtmOy_AjS6wgvmwN9BOKTo _yQW_oDE8Vf3eHnMW8oyqGcNda00Di3bRApDJYjqJJ6DFzOKEC0ghdoH8puHlSkFBzz4iCQ2wU0I 10V07dSzeaHwPWXugQO05_uL5aCuFiLsX7k0OVafzkMAFgchuekN_67tFLWHzHcM5T2r3DNCBN3j GUwzfKV35dHOalKWEBpyOuFDFjwRIr_hElCTr.wTSgixwgWbXTdGlZp98VXkcRk5vKHuasF7Ciwn MTgCJuF5tOKQjDQcrp5AG0foUJQ375b.mQJeY96wgjqKFQuVaTAEDYF9K7hq4B1B4Kdgsf6TYaQx xAXBkNVSqwUwII_Y2VywjsRBqZg1QBS5yxsoOldfXHTwZpSkKmyrMQ5zBQwpkhvgtgcDZ8hICT2I DFTqcKTcqFs0mOIYc9Mok_y.t_2ciqNxMm7MwT_JkH32H63.MTQM2cTHz4i2ls4I9yXlZR3S8Ulz dzKcIclm2rwnLGVY188_GaC.1UXxZUunST2_KFWCzhJ2TCmPZp1STKq15RhojlL12vwcaFbAPpLT lHd1y3p2kzcV1g7sWKBHfd75oifuWVZ1TfxhPbHmgoz97VZzTYiu.2iFotsVhW0XTGNdf7DhXS1S 6uP5GV66R0NkkOLsBzeWyNPBckXFO0AVvQ6uymTEyK9dqWhR4eF4kXIZxSOB9lKF5krLGzstT7p0 jtIy8nTuxXxyOQxAoQX1WyPuGXmiApjtH X-Sonic-MF: X-Sonic-ID: a13115e1-e2ff-4bd6-9229-fe5ebc0f6732 Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Wed, 20 Nov 2024 16:03:38 +0000 Received: by hermes--production-gq1-5dd4b47f46-fhdpd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c685bfad4d02753d7cfcb430130fa249; Wed, 20 Nov 2024 16:03:35 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: b882d21558f3 - main - arm: link all .rodata variants into one output section Message-Id: <6088B065-8BA0-4D0B-8E08-706B634D5D91@yahoo.com> Date: Wed, 20 Nov 2024 08:03:24 -0800 Cc: Warner Losh To: mmel@freebsd.org, John Baldwin , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3776.700.51) References: <6088B065-8BA0-4D0B-8E08-706B634D5D91.ref@yahoo.com> X-Spamd-Result: default: False [-3.30 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.994]; NEURAL_HAM_MEDIUM(-0.81)[-0.806]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; SUBJECT_ENDS_SPACES(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FREEMAIL_FROM(0.00)[yahoo.com]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.205:from]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.205:from] X-Rspamd-Queue-Id: 4XtmPS5hGYz4FLl X-Spamd-Bar: --- John Baldwin wrote on Date: Wed, 20 Nov 2024 14:52:06 UTC : > On 11/19/24 08:02, Michal Meloun wrote: > >=20 > >=20 > > On 19.11.2024 16:15, John Baldwin wrote: > >> On 11/17/24 03:36, Michal Meloun wrote: > >>> The branch main has been updated by mmel: > >>> > >>> URL: https://cgit.FreeBSD.org/src/commit/? > >>> id=3Db882d21558f37e6a565694ac9b8f2a519e5b86fa > >>> > >>> commit b882d21558f37e6a565694ac9b8f2a519e5b86fa > >>> Author: Michal Meloun > >>> AuthorDate: 2024-11-17 11:28:47 +0000 > >>> Commit: Michal Meloun > >>> CommitDate: 2024-11-17 11:35:55 +0000 > >>> > >>> arm: link all .rodata variants into one output section > >>> MFC after: 1 week > >>> --- > >>> sys/conf/ldscript.arm | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/sys/conf/ldscript.arm b/sys/conf/ldscript.arm > >>> index d9edcfac9f78..7cf904ce39ff 100644 > >>> --- a/sys/conf/ldscript.arm > >>> +++ b/sys/conf/ldscript.arm > >>> @@ -17,7 +17,7 @@ SECTIONS > >>> _etext =3D .; > >>> PROVIDE (etext =3D .); > >>> .fini : { *(.fini) } =3D0x9090 > >>> - .rodata : { *(.rodata) *(.gnu.linkonce.r*) } > >>> + .rodata : { *(.rodata*) *(.gnu.linkonce.r*) } > >>> .rodata1 : { *(.rodata1) } > >> > >> Is this line now spurious or do linker scripts prefer more exact = matches? > >> > >>> .interp : { *(.interp) } > >>> .hash : { *(.hash) } > >> > > Right hit. I want write { *(.rodata) *(.rodata.*) = *(.gnu.linkonce.r*) } > >=20 > > Warner already tried to tell me the same thing, but I didn't get it = :( > > Btw arm64 has the same problem. > >=20 > > This gives me another question. Who generates the .rodata1 section? = This > > section appeared in gnu ld three decades ago, with no real = description. > > Do we still need it? >=20 > I have no idea if we still need .rodata1 (or why it exists), I was = just > reading the diff of the linker script. Looking around at examples on the web I'm seeing mostly the likes of the following for analogous text: .rodata : { *(.rodata .rodata.* .gnu.linkonce.r.*) } .rodata1 : { *(.rodata1) } (and somewhat similarly for .data.*) I saw some examples of *(.rodata.str1.4) for examples that lacked use of .rodata.* , giving some idea what would be expected to match the .* part of the pattern. =3D=3D=3D Mark Millard marklmi at yahoo.com