From nobody Tue Nov 12 03:28:17 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XnX1Y4Z83z5d3Wy; Tue, 12 Nov 2024 03:28:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XnX1Y1Pb8z45wx; Tue, 12 Nov 2024 03:28:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731382097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dvoj1v3xQeAVQZh/CLDDj+u8RODXAFlh+P6IskXWKAM=; b=IaJvwkvsmJKnoZf73odChFb9fRwbt5YgbELUEn5rMm1k8AsFIziegLBcg0RNJRhGi2Wr/t mDLsTzdYmE411D0XR1TDcS0pXuCtkt8vhl8yADAMS4r411dJOnnWLFG8NLVJo8A9Y0zi0n A+W4EvY0y5x1R8870ZA0i8SBIPzbOGnvc0rwc2YbRG7kgTj08zLAF03dInfAZYSvrrFxTE GcuunwxS268Yj02ev83g0UGda/oLruzSzBboTUTot5kKCAM0ZB3Sk4BSgv3i27fOlhQeHv ZiPFv96ea2ooBxA0okKoLIxheQBCNZ/0D0EGT81I3RgaM2YLf8AgX/1J1hfkNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731382097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dvoj1v3xQeAVQZh/CLDDj+u8RODXAFlh+P6IskXWKAM=; b=AdHDO/M9gbAjJWHpJ/q9Qmm0xBiU8bBHmDYq6N+U7491OuM15FNh7wIV/8iXk2bE3C6v19 4QiYuENm9BOZBE2d+dGRuboiQ+au893Nj3ByjSnIZCEEioBEeoAvu+O3ICLBBh+TM+AwbS 2UgniFiqtajrkR6SCWXwJraMRRKSaH7iSZ28L92RT0cgigXzmecwM05d3GCx2Y4ydNe/LM j/1k/1QOQVoBoLoR4nPftl40yWnIS3sESSTwWGJbhu1Qm/06lOiyrN0EGH9Haes2k3wBcB zaucNhYgX45xoz3gZcLENxT92eEIPkBxJ8xisj+xRhLc1rDzCfra2lyHoK8Y6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731382097; a=rsa-sha256; cv=none; b=gtcVN4tgSTHtUQuI0iP4QbisSOaNxObrivx/qnuh+F9yZJ9NY+AwnfgOs97yGRfd+n3C/e 9DZN5pq6Kblo8uALURTFyEosn8F1VrjVWuz1E3EyP3D8IQc3Bv+V+6CRjvoiWDLl92eH68 dnJSEk8vq2ekMpv1YK2y1UsYApeFs1MXjMe4P/7LxEPKaBJGMzmgT4cEsphmGfPbHei6bu VJ2aB5JyY8jqyGGRtDmuvkJSYWQZnIom0cwNOfBQc7aSLy8izv9V7iyR5t6znqe2YO9l/u 4qaoC6ik30BbmdvNWOQCkmySwAuHKuWaRKWpYY9BFunziDIc4oEDbrsGiteP9A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XnX1Y0z4nztQw; Tue, 12 Nov 2024 03:28:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AC3SH8q078035; Tue, 12 Nov 2024 03:28:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AC3SHgq078032; Tue, 12 Nov 2024 03:28:17 GMT (envelope-from git) Date: Tue, 12 Nov 2024 03:28:17 GMT Message-Id: <202411120328.4AC3SHgq078032@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: 8aae4220d766 - main - ipfilter: Print the hash name when adding a hashnode fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8aae4220d76602f22291d7567ba0c61b9aa8c188 Auto-Submitted: auto-generated The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=8aae4220d76602f22291d7567ba0c61b9aa8c188 commit 8aae4220d76602f22291d7567ba0c61b9aa8c188 Author: Cy Schubert AuthorDate: 2024-11-07 15:51:12 +0000 Commit: Cy Schubert CommitDate: 2024-11-12 03:18:08 +0000 ipfilter: Print the hash name when adding a hashnode fails As with when printing errors for failed poolnodes, printing the hash node (IP address) only leads to speculation which hash pool the failed add occurred. This is especially useful when the same IP address is listed in multiple hash pools. MFC after: 1 week --- sbin/ipf/libipf/load_hashnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/ipf/libipf/load_hashnode.c b/sbin/ipf/libipf/load_hashnode.c index 11525dc96e35..bf22edb9be87 100644 --- a/sbin/ipf/libipf/load_hashnode.c +++ b/sbin/ipf/libipf/load_hashnode.c @@ -55,7 +55,7 @@ load_hashnode(int unit, char *name, iphtent_t *node, int ttl, if (!(opts & OPT_DONOTHING)) { char msg[80]; - snprintf(msg, sizeof(msg), "%s node from lookup hash table", what); + snprintf(msg, sizeof(msg), "%s node from lookup hash table(%s)", what, name); return (ipf_perror_fd(pool_fd(), iocfunc, msg)); } return (0);