From nobody Tue Nov 05 01:33:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xj9pf2QSdz5cqRN; Tue, 05 Nov 2024 01:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xj9pf0Ww1z4tLG; Tue, 5 Nov 2024 01:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730770426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KGI3G7YsDxTymlgnA50ELe9wzCPa8pVwOKPwwRmQQwM=; b=IuNr5BmJ83eoeVsfXJ8tkvu3JWeZPUNRjhPXexMQtb0PW4jKTAhEDQWJLyxoEiQZ8uudx7 yAfIvvvVk8yh+pwQOW//z6jsD4hQqeCgYnpEk6B6QBcfbE9Jnjcn3UHYI8YBkyIrVg81Br UyMtZ7+84X4fjvT30lG1Elzmis3noGi5KRyYJ7udwtC+3qfpp7+hKynCOL77B0EzDEi7v0 WIYEMvIUP4zkHNRmKM/ClYizhyNeucqOF6RkL0HKqI2ciwPa3+f4lSRECP3v8k+JlC+52K 5j6/KtZ/SZd8+F6nS0Zn/Hf0sz8CC/e/NNnLZM9OL/AIs1XjJ+DqhdhJ9STMTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730770426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KGI3G7YsDxTymlgnA50ELe9wzCPa8pVwOKPwwRmQQwM=; b=IIo0msa2afDBczSOZSgiy4Zye/iJVkgQzJBvAnHEy1dvAfuI+h4ENexHK7QZ9IvUbWjOzG Xnxiit8zYqLsS9lEj+voNvg28CZIrz+pkXX1CJ9vLmN540C5Q4jNvxMY7ncYtJvJuN5P5g FQAssagoiWL4HrVI35dz6hw+knP/MyuWfpMeAKgz2uAGph3AEWz7AZ4ZupPKMF/pCNWMu8 sb/fKIfozCJR/iomyJu1DuImgZEqFwPGLSq5RtznjacadYMKqFfKHJ+eaIlNb0vOOEz1s7 L32fYa0IXSmn24uoEg7aOtIDy7qSdNpd/ax5I4Aa5bey+7oiCN/kIKBz/a0CKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730770426; a=rsa-sha256; cv=none; b=uyVYHwIp6MSf0wdWoCqrAlaS/ZM4pgZSsOkVcXFpDCPKglQArksk7+fQzeZeuRQD3a+9O6 onGJC6XvKU4vxokF30WBS6fS/t8J58AX6nDeS/U5Y8uIM0wG0/leJwWKSITDP1Kt50qzTv D8ZBa5AGqFgps5Yxx5vKbVlIULlSOm2eTIeLLJanGVTxe1QRB59j5oc8SsPFlDl/XKDM4A sbeP3i5mr0lwsuY8lBg/xumeSCWmSB2i3JwLov55nMg7Y1y3I15G5zOKelFpouGAw0+1Ki lZGd+vTkE8RSZs9ySfq6nu9Trn89MjWe+u0+X0YS0QETYc7w4hQp5KoLgftetw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xj9pf07n5zx5Z; Tue, 5 Nov 2024 01:33:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A51XjM6049230; Tue, 5 Nov 2024 01:33:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A51Xjia049227; Tue, 5 Nov 2024 01:33:45 GMT (envelope-from git) Date: Tue, 5 Nov 2024 01:33:45 GMT Message-Id: <202411050133.4A51Xjia049227@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 7ebc7d1ab76b - main - Remove bogus detach routines List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7ebc7d1ab76b9d06be9400d6c9fc74fcc43603a1 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=7ebc7d1ab76b9d06be9400d6c9fc74fcc43603a1 commit 7ebc7d1ab76b9d06be9400d6c9fc74fcc43603a1 Author: John Baldwin AuthorDate: 2024-11-05 01:31:16 +0000 Commit: John Baldwin CommitDate: 2024-11-05 01:31:16 +0000 Remove bogus detach routines These drivers are not bus drivers, and would need proper detach routines that tore down state stored in the softc. Better to just fail detach outright instead of an incorrect success. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47389 --- sys/dev/gpio/gpiomdio.c | 1 - sys/dev/sff/sfp_fdt.c | 1 - 2 files changed, 2 deletions(-) diff --git a/sys/dev/gpio/gpiomdio.c b/sys/dev/gpio/gpiomdio.c index deb9a25bd290..dc43b2783bc5 100644 --- a/sys/dev/gpio/gpiomdio.c +++ b/sys/dev/gpio/gpiomdio.c @@ -213,7 +213,6 @@ static device_method_t gpiomdio_methods[] = { /* Device interface */ DEVMETHOD(device_probe, gpiomdio_probe), DEVMETHOD(device_attach, gpiomdio_attach), - DEVMETHOD(device_detach, bus_generic_detach), /* MDIO interface */ DEVMETHOD(miibus_readreg, gpiomdio_readreg), diff --git a/sys/dev/sff/sfp_fdt.c b/sys/dev/sff/sfp_fdt.c index 7430282ede70..e566d8ced78c 100644 --- a/sys/dev/sff/sfp_fdt.c +++ b/sys/dev/sff/sfp_fdt.c @@ -138,7 +138,6 @@ static device_method_t sfp_fdt_methods[] = { /* Device interface */ DEVMETHOD(device_probe, sfp_fdt_probe), DEVMETHOD(device_attach, sfp_fdt_attach), - DEVMETHOD(device_detach, bus_generic_detach), /* SFF */ DEVMETHOD(sff_get_i2c_bus, sfp_fdt_get_i2c_bus),