From nobody Sun Nov 03 13:17:58 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhFXP1KBnz5c66r; Sun, 03 Nov 2024 13:18:13 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhFXN63Drz4qTC; Sun, 3 Nov 2024 13:18:12 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a9a1b71d7ffso586581866b.1; Sun, 03 Nov 2024 05:18:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730639889; x=1731244689; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ducdZoK2Zhf4X5R048aYL/z418Y//iMl5mnDtpTsxAw=; b=kLTU2Z9bGySJ1zPNb3MCWt6IC7XjBzdTAqT2pPjYTvViLds2FpoExnUc1YNswSOPUi ZNEed8iLyu/BlZeZ0434wPxpxixxKhqWdMp9jPvm4fgleaidfDK6Of509vmuPTeE42i0 ANq8J+1yKVue10rPMTP3Y6WLuTYXgNjxwQgAhomDwZ6JBv664+YD0XyYOw1gKruKWas2 PNn/XwEbQcWm3GLV9wNmLX6Z9hdXaC1kzRbseJ3beHa/vU+BKsd7WlU1HBUmLbhQEI9O Tn0R6a30lb520HeHwXEKYQpsssf26I3AfFHGyyBsl+QPZ542u5Xhjp0GAri4SrT5PqD3 89Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730639889; x=1731244689; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ducdZoK2Zhf4X5R048aYL/z418Y//iMl5mnDtpTsxAw=; b=edgKBDDFjoEe+VzMEeEw8K/BXiZ2stUcnxLFVZ24UUOzC+gtF1UR3HcNKdYCBBxfsI 4cOChZs3e9J/6U5Ta+lF+8037NAtwLCJbhicQNMKBnXuwUsurw8+ES+mAAr02XUL2MyE zqzDKuCu0fNkMdFWGwZRo97G40emu35fIYkpH34ll1q7WhmZ52eyn5n2x9lpYYS9fa5D 9DlReJItfm81ZNz3MNNW0hBQXU6GUTELVLB8F7e1ze3HZkp0TffDoLoyzrWCm+Hpsc49 jHYBQhBMouLKD8tXBFjCu231GSM3ijKp/NfQQ0rNNsFlYp+iOi8w33PvEqTH4KxVcbT2 3tUw== X-Forwarded-Encrypted: i=1; AJvYcCWDZIkaZJhUhTOitrPp/EZ2KxJ1UwM8c6WpD2iCkVnpggCZFUqiwpid0EwupAtMbCBUXeiwxPa0obihRgyMwTtA4wSBEco=@freebsd.org, AJvYcCWoEu4YogJX2buLO9cTCAinvR5WSjHF3rTccnJH9PjKiKVzjV1sQ3ggrFrOas6GwLjZOR+bUxCm6vNIacUu7vU=@freebsd.org, AJvYcCXQdU6N0WI1/tJ4Psre5snrkzuq57jj7TWWwl2WaJrqhUtuHbhglhuVU1lO/BP/3lzhAH8m7opGBw==@freebsd.org, AJvYcCXZTNKWrMb8nsHk+cTKlBfSVx/qaRK1OVshbPhyF7zALGcdLTbxlIKSFPLHUKyHF/tvPuqk5BgV4mE/ehCe8uToOs1u@freebsd.org X-Gm-Message-State: AOJu0YwTm/T1HFcRXRLbtdPGg6B7OKHr3HDe6ZWl7cXvp1EL0R5GCWWs Jw5cMgIXYebIM9JBQKBVaUwghhbfFAFj12zTszH4okE0viTHxylwmNYhfyTxGfQWXiwaAuMMe/r YkYsPQx6eHsU29gWg+Z8XM3SvZptA4bU= X-Google-Smtp-Source: AGHT+IHLerKRNYRPxVlA6PE9nn/AKjgFKBQlg7LlFrXwirukLidLy1RdyiKfzFuvm12GQnx0GkhNiitIKgYBPBTOeOM= X-Received: by 2002:a17:906:6a12:b0:a99:f746:385 with SMTP id a640c23a62f3a-a9e3a573d11mr1832164566b.1.1730639889289; Sun, 03 Nov 2024 05:18:09 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202411022039.4A2KdbAE046580@gitrepo.freebsd.org> <9307D0CC-6D10-4F86-AE3B-43E7D6DA19A9@panasas.com> <20241103065704.4377C114@slippy.cwsent.com> <3070589.hHqAuc6tWs@ravel> <20241103113308.D6D6B77@slippy.cwsent.com> In-Reply-To: <20241103113308.D6D6B77@slippy.cwsent.com> From: Rick Macklem Date: Sun, 3 Nov 2024 05:17:58 -0800 Message-ID: Subject: Re: cfbe7a62dc62 - main - nfs, rpc: Ensure kernel credentials have at least one group To: Cy Schubert Cc: Olivier Certner , Ravi Pokala , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4XhFXN63Drz4qTC X-Spamd-Bar: ---- On Sun, Nov 3, 2024 at 3:33=E2=80=AFAM Cy Schubert wrote: > > CAUTION: This email originated from outside of the University of Guelph. = Do not click links or open attachments unless you recognize the sender and = know the content is safe. If in doubt, forward suspicious emails to IThelp@= uoguelph.ca. > > > In message <3070589.hHqAuc6tWs@ravel>, Olivier Certner writes: > > --nextPart2434776.THHZn3L5Ee > > Content-Transfer-Encoding: 7Bit > > Content-Type: text/plain; charset=3D"UTF-8"; protected-headers=3D"v1" > > From: Olivier Certner > > Date: Sun, 03 Nov 2024 11:35:53 +0100 > > Message-ID: <3070589.hHqAuc6tWs@ravel> > > In-Reply-To: <20241103065704.4377C114@slippy.cwsent.com> > > MIME-Version: 1.0 > > > > I now probably know what is going on and will post a patch soon (to fix= both > > MINIMAL build and your panics). > > > > Is your "BREAK" kernel configuration omitting INET or NFSD? > > No. All it does is allow me to hit break (ctrl-e c l 1 using > comms/com-console on serial console) to break to debugger any time while > the server is running. Since the nfscommon can be loaded as a module (ie. not always present), I think you'll need to use UID_NOBODY and GID_NOGROUP instead of nfsrv_XXX outside of the nfs code. There is also the issue of it being NFSD_VNET(), which sho= uld not be used outside of the NFS code. It is currently just a VNET variable, but bz@ was thinking of changing that someday. Sorry I didn't spot this during the review, rick > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=3D0 > > >