From nobody Fri Nov 01 01:06:17 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfjP642dYz5bHHG for ; Fri, 01 Nov 2024 01:06:34 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-25.consmr.mail.gq1.yahoo.com (sonic312-25.consmr.mail.gq1.yahoo.com [98.137.69.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfjP55gL0z4JN4 for ; Fri, 1 Nov 2024 01:06:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=J7xMNTZz; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1730423192; bh=UmYij+ioayi039JJrcKav3Hcfd2bWYheW07l4HDIuG8=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=J7xMNTZzpdctP1yxaLIf/+iX6Oq/bi3CGObVuYCideZg2jCcOdeSh7nMm7s/YgDJIn1GkdTh1D0wM6EG8i9IX/UEusp2XU5UmE4yEQygAAm/Yh3MHFl03BHqi+L5UkRKlUUs9G4JjtbKWAUOE4J0l9pS3YvGHYJCwKLrXV3NNhTQqdc4oQUaWbNM/uUiwzpHXnbLt8SAWpK87vSBMXfMe0k7Dipm/U8WEpp4+UJGNWqE+6rwOVnKjW8XFgIih13nTqlBIjiXg5I08BX0ag95Bu9dIGMn/xJ8uV1VlAbv6zalgY+Bypy9cQJSjkEv0txiKq0//5kQXt+G2jCzJ9LSPA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1730423192; bh=WcK36ZD6PEBN0xCfWoODgh/gEbiEO+AKquoB8SK3ZDD=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=bi94CbhhiTb/6/xBnKL3gTru+OTeQtt9aHYcgMNK/WElo/V09pW8jQXGbRh2m0nQ88Bv8oFx3g3uIaCzpSqJ09hq+Xiq3pnGFfS/F3ITgrsSoH7W1ld6I8LPdNht78WVLIhcVewoOPX6iacxiBEvcgwDSKDA+t0DmgDNWMi7KTVPV421PHsFjd9Ib2rDwrPPFKFnYGwQyC8p6aZm0EYe9ZAVZY87LsmPO0JJLkwNWmqK+OWdZqIA7hlOY1nVTgDCAelwv4ok8hfQLrtFIdg7fs93KpHXjfHhWTdUAStAEIbEpKcbS1Y/CJWmR4SMRBcoVexdcgVvYDsv6F2+030Ivg== X-YMail-OSG: 1eUzRpkVM1lV9xG.oZM3kbPLElcMDDe5mYeq6zDwKKfKwTHfnk3SYJxhXWAMAri aKlAzjQ4WDZsrUyDqkaeLJ7iq4Vkm0aK633kUBLi_sayeRY5rN_Q8CbLURob.w2XdGee4T9ot6vz krszvbTTkePCJr.9.0TAQjFd_UzgVupQ_64HEt8qcxtP2CRKLSN.KTCouJiRf.d1OqpObsIHMqVY pKwXGu4vTEl5kuoKcGBgNl.HhyRn.54ers1Rr8BZb5sGfmETQHR8DLBZrbwGKtyfHzUlGVseZQ37 u.FAXjPJ3L59FdVM_wZntkUc.XjDyVrd6lnCVMNaNyupUSffjz3Nd46mMBKqH3czBW8QWFyKjSaP FjVrYSAEZL1P6se9QBDU4wQlAUsZgHN8pjZSjCq3dbWXovwIPfKO_aa1wsdUZHvjVxaj3zXX5yBM AOofhAWXaxaZPUh6wiXwjHLgVDG5HmJjev38j8Fc2ZUqhHCm_yuP2Zl8Yw2SJvhPtfPWDvjkGCB1 MlskVcwJj_v_5NjEwLHXF0srH0eonSHbCu7wuXDednZHT7vPSRLpkg6FdrJc23ZETVbt9fNPzh.5 bDGDEhQ5tL4_hfOsNxojhX3lCq1Kk8XO0gN_rtGVeDdCFR5gp7LB1djdA9i0Qj2gDPREPQE1t_rh v2C4ZI0cWMpC0jP7lf1BPYNzIo_Od1N9H5eJJ3jJpEb_sf1RbHWsEcR2QPUkxqxFScgy0nrCPoES qiJZrHTuu.gl5xbZyONPHjRTr5S4mi4mFqHXS72ye7M2PKhZKfEhZSDh4kJYJv_llOd53dkKD5gd 05L7ARMCkvk2izArzZ_MamPuSLtO_Igadev76g6Asu31WScEwl5Q.sguTFRBV9X_x6cQQ.HFR9oN V3FD1wwv5P0_m7CWuChsQT796jKngCkQHjCg2NihiaAdjvs0SMDgeqba1vme86pSRVDi8XRy_Spc G01ax3cV25xcDv7oT47ENZ7JTyisOfH47l58Y24zzgblYxHdldVkp0SewTgd2e0oP8N8zN2NoZQq _rPLny3jQVmrhDVgqMkCpD8O4muwtzDJ9seF2b5l3ffMoij.P_xHRkjLunAzXDCTGcQwA8sowdY6 JKO7Rb4mC8ADFCA21KwNtON0baROuWet3kDoDoYS8Ya8ulcEVGiCfAL9J5hEwfpo5IbShHe5EcT. PAY2soFU9mhKshyAMK0Hnp6TeHgJ7Zcd5muLiMb4IlcoRri4q0VUgfMZfnntR_38Zyx0BNpwDmwo CzosgvCDcGLtYNMxiqUltxCK0dlavpLbAEmcKpk.Mz97VG8l3xrjwJYh5xVzjwdWUM.FtOhvSVVB oxr8lbvFb2GhkD5GMhNop1XpiBhx6GPpansXECTVwbrDDfFGWnNKEqJ7DMlakwzoalhW4kHL9axZ ekx_g1SGXfjbO5CcHP6P97c7OZ0V_SGqXqjAujnuz0rAnwbcUU_DwMwbOZt_71HE8Uk9vCA2Q9Eh 9r.mHwskFlXBOB51o.m6_NyHMuybL0HaRe.mtdrzg6laVL0Zvd49vPvdCj0m4mjm1JOPKKt5NUTZ hJMb3.acJZYGtmAJd8ZHDRlHmw9_En9MzWYVN.82kTwVbBmgPzNxfT7YiuX3Na9PrpkPZPlLkl0B Vu_Uc9wJ5nqwGT1.5.eJ0eCqEsJW3bg.xHGOUg3I6GRPIjlg18nsn44H8OpJPELnn8cKf1jBkL6T dx27Yo0_iJocDhImQlE5n5E3_GU.z_N19GZ8mT71hOuIcFzM.DGsSb5ttfo2IeRg2SryEO2Ni04_ 0vQ1e553TT2TqSz9_TiRTHEJUZtVPBvbdHRtJ5jcWIH4hZWpTBzC.EGC6JBlLlfVDt.EKygyJJUP WUzj2NPrsyiThyMW.O467cNtDYXqOmsjcAAQqkg1sM0yQLyvmhHqGuturEZjxp1Tnrf8dFYOVm7D BJBMyens2C9VRcMtOheuMdmwjQssVTTmGLwob.UgC30Pes4qnPuEerXyk0XTXI8FZH8mYTOe24M6 tY.6Cs0rjP6m.alwme9pwLEXHQY_Riw_lzvV44FgIU90k5UGhWkOYHAmw9J7iSUBnzoXsCrxpkMo k_HKIP4ePVI7aOLF5uGLNKGkb_b0E.XQ5rppffI11eFl714v4dKeWO5UiTefNpZBALxHV.f0GjSn CXfiUXXtzXASTu7qp.Jzlzphv2_EtVhjsD8UAibGjkp_AeCfs84TZXV3w7B0Gsv5HrqtvkAkPakc PjxuLNw2fzI3rJu7Hlr.njnQRCSMATiZiFQ.U3d.upjPRT83j0xq7JByXyOS8WfdwiyByAYAQjjW howns8pV4cw-- X-Sonic-MF: X-Sonic-ID: 30932187-f014-4f57-bd7e-78a03966a04b Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Fri, 1 Nov 2024 01:06:32 +0000 Received: by hermes--production-gq1-5dd4b47f46-k4d2j (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ba83ad35e581c67c2d9ab74b0bf42ae5; Fri, 01 Nov 2024 01:06:28 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: cf1aba2857c1 - main - freebsd-update: refuse to operate on a pkgbase system From: Mark Millard In-Reply-To: <22FC2477-98CF-419D-95EF-C999F8841525@yahoo.com> Date: Thu, 31 Oct 2024 18:06:17 -0700 Cc: dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4A23041D-4BDC-4F8E-BB20-2D6C5619A08C@yahoo.com> References: <7FF78752-80EB-47CA-9E60-515607D3CFE5.ref@yahoo.com> <7FF78752-80EB-47CA-9E60-515607D3CFE5@yahoo.com> <22FC2477-98CF-419D-95EF-C999F8841525@yahoo.com> To: Ed Maste X-Mailer: Apple Mail (2.3776.700.51) X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.206:from]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.206:from] X-Rspamd-Queue-Id: 4XfjP55gL0z4JN4 X-Spamd-Bar: --- On Oct 31, 2024, at 17:53, Mark Millard wrote: > On Oct 31, 2024, at 16:37, Ed Maste wrote: >=20 >> On Thu, 31 Oct 2024 at 15:17, Mark Millard wrote: >>>=20 >>>> + # Presence of FreeBSD-* package(s) indicates packaged base. >>>> + if ! pkg -c ${BASEDIR} info -q -x '^FreeBSD' 2>/dev/null; then >>>=20 >>> Slight difference in the comment vs. the code's behavior? : >>>=20 >>> Comment: FreeBSD-* >>> Code: FreeBSD* >>=20 >> The code is a regex ^FreeBSD while I wrote the comment thinking of a >> shell glob - it's fine that they're not identical (except for this >> confusion). >=20 > FYI in case it is not clear: >=20 > I understood the 2 distinct notations. I was only trying to > indicate that the matching text sequences for the 2 > notations used are different. >=20 > FreeBSD-* does not match: FreeBSDPkgBase > ^FreeBSD does match: FreeBSDPkgBase >=20 > Do you want FreeBSDPkgBase to be a match in actual operation? >=20 >> That said there is room for improvement here - we'll want >> to detect pkgbase installs in downstream projects that use a = different >> package naming scheme (e.g. packages starting with CheriBSD). >>=20 >> I'll keep a note of this comment for any potential iteration on this. Hmm. I see another potential issue: # pkg info -x ^FreeBSD FreeBSD-acct-15.snap20241023235252 . . . FreeBSD-zoneinfo-15.snap20241009162208 freebsd-release-manifests-20240809 The capitalization in "freebsd-release-manifests-20240809" matches the existing pkg -x text: capitalization appears to be ignored for -x by itself. Loooking: -C, --case-sensitive Make the standard or the regular expression (-x) matching = against pkg-name case sensitive. So: # pkg info -C -x ^FreeBSD FreeBSD-acct-15.snap20241023235252 . . . FreeBSD-zoneinfo-15.snap20241009162208 avoids the issue. As does: # pkg info -x ^FreeBSD- FreeBSD-acct-15.snap20241023235252 . . . FreeBSD-zoneinfo-15.snap20241009162208 if the "-" is to be required. =3D=3D=3D Mark Millard marklmi at yahoo.com