From nobody Fri Nov 01 00:53:50 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xfj6n2tyhz5bGrT for ; Fri, 01 Nov 2024 00:54:09 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-25.consmr.mail.gq1.yahoo.com (sonic312-25.consmr.mail.gq1.yahoo.com [98.137.69.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xfj6m727rz4Hgv for ; Fri, 1 Nov 2024 00:54:08 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1730422447; bh=ftgYjJrW0ixWp2t7d0HM0gGwzGG9ByzYCIy74OacBDI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=I/hPrlurasxv0/KN7+92IYn8IR3g8l0ZykCsiLHMuDaXo+MpODp4T1CKJu1+XxacD50JqV6J/pA5CMldLHdvh1iGdJZK1M7KsE/lLH2bi/RnW++2hcms38lS8/iwSbb6ql4/7r0uQ/p2xpRmI36fx90w2r3dgdY3paXT9V3Q3Vc6TewNde1EvzyqVwN5izqAZ6OwxqIcSe5+p9A7IRpG64x+Y4RRM1tam2W+yeZlPQHXIglYB54afwMtbM82mofkwBrk9d29K1MuqLATBn/x342RcP+bVuAVLfbLSb4bMeWSCPMy3Dfd7fnfV3PSKQhod6GTekyo8HFPmVViXERt6Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1730422447; bh=stq1tYvDtrh7JM9fQ6F49hhwWXpeGEPTGJk5UMis09n=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=Iuxx+eZVqX+1rVxifa2PDUTa4+k/5jaHZ8H2PIpGE7jADu0HrlQOZCafFPl/bU8eBZS8NrNyT307QoIe59Y6vEgKJGYNcAQvsUlv2N/t2GZeDjBxJL+43EjU9Hos1zysDYeB1r+wLicgcA5YZLDt2YdGPs6OaOjyYDjZD3ISA75BmRDHyqOofU79vz255qt7auibAdknnT7D4hIqiHZlPKIEJThGAw+CboSDQLnGmGhdonNouuhrYtA7Th7wDdMdgVOE8VYZRxhYVOv5aNM0ewLEVVpc5Nf+zkBQcxqKQ9H3wbPO70c+VfeW65FBipoCQVrBM61hDSremZNBnz8obA== X-YMail-OSG: _2gph_sVM1nwysWL_w17_XyZ8oRO.oAQ9aVGp1yQdrKW5cylI0Th9RS3xHTLi8M u5168elwKSk.a3YQ1_ynDmBRd_6pUqZz.h2J.Jy43qfePfc7kFaE6rzGQ7_d_WZ1P9qSXUQH252j Qit_rea3o9meEM3vSr05acxRqA0RXerHRsVBXM6NbBnzndXvmtkpbz5IP_9rDyAcbtsakwBAuEtW P88vSQObZVEMvbFeznlOClZcna8_xyPqeHbplY1d3fPkTU4k9F1oj9CapGvs.Czp0esRtAR8Aqxy 63drq3jHsk2eDeDD0FebvHVAW9a2MGB1OhV0Pk4YWtS3i56Dp34WKKt3pYHsl58wHbZCQ4bZgVz3 0dJ2Iy5YJ8lkmWJKd7Vt1XyEqc0Xd2Fw6VIlggn1MwignR6cYmrHxWgcltO9vqfmD7RW2EVJjuJY BtuGiDUha.k70GzYsX7Ob7biro4yXgYJ6A9Bu2n2vs8S60yq41rCFp1ohX0rzvR1lw3wiHeptnZV viu7wHZb5akMRbtB7VAAFcgQNRxd0y8E6Qk31vOA3oVyYomJcV3HZh9o11kdCRikr0saQU5OE97. wBagsFWMYe4cm.0uwdK.zq2ujbmy_60Me5P9.8vjZy4opZFrJ4omxYq8eP4LJ9fy3XQHWhbM0J6N 2kYqvjnh2.zSagRVpVa2eGznS6pIRrDdrNgvdyq0v5tYpz0a4lk_JYSv5wp_EzQPnBFi1bedFTXv tILoCWamHusrFd4yBPluQNal_TRG.VJWfmMiZlio.tB_bB9BOZbMnMnSn2kPVzm6cmlE5d9l04TF OeLg_ZD7z2WEVcokYvWmiYbNGT8rLlPQav4MdRP97X.JYSx8gi7mShDExSINLpMd4Z3AotKZarXl 2dmyKTA9XFO7SAn28YQ0LpY6lHvURjakNOMdy7ZPiVO7Cf4M.Q1lRm7jN89wjqoUbGaC9kpcB3Q6 HFRe7BmAfKnqpkbP1xFgG.RtUSRP_qM1K0McC2Fu39QHM_u0g1_csNmH5F8R3YLIXU4xSBKQr4Hq NekBzHbF.PxSwDMGU77F.ZjO1w2r_lTXF3YTXeqQE.KSLpHmf88shAoW7OnjATXeiaP7bNleHkiM ew_vpMmOD74NHwajiH75jrCUTNZhQsbvyIB386QNu8y4MX.PQmMA8QMduP9JedXYUhKh8Wqr5nQZ DkGgcD8OljsG.kLwsfFz6Y1hPVc9R6wQKllZYODSY__WuI4M7KbNDSf34RSWRetYr3uU8rdVJtbX LJLYttp0oI_RSW75J3nms4tnDZVn_.NzYzvDEaYhX84GYcM2tfHDSwjWhCKXBt38cxd3pMnbUY__ k.7kwPD3ZOOZ8nqccX5HyaoUc5vMPvB2nQOaUEVcHyrqYuh3NeKl0sAGRVrXcD6ilx9JnugtCD.Y jRfNjzca6HHUchvFgyhY6bkaGqXzli5VYYr2G37n_wOiwLUY4UCC30lBwfV0V2Cxy.4YjwspMB7u 9rqciYD6GLxm1ltxsIsewoOiPO.Kvhi5bA.rGPU2NWqqY97ObtonQOHtBMXOhU74PmaF_7ma3xZY UCpIm__yi7fMDdBPLUuBVdLgk9fqnvMPOYriKrrIonHVMYljP5E27KIImNfZi8PYGLJjG0JEO3j7 h3EAe0h7QzwBPXtF99V7qXA1xjBeu6UVyjsFNWU97fkR9GD.Q.DnDJCJ0ZxpWKZOJxv06C3TpUu1 Ap_q7eWtwEjt1S0bCsVYCWolVNdq0J_9e_N5Nf2FWlt9S_ybCXYjbLDuMy24ezcNOqacAZoA2vvN 1F7GQps.G3hBSHfEYIZbZT_nMjmW7PXELXSrRpwrwqSH33yBA4Iscwonqs_cE1Jh3REJYuszpKHI wiXtkupBPsCcWdygwiS5epdWd2mu_9xz9fGGvkcaj1DD59mNk9aAyZrDBMfMyIuyJqi0hExgjdR4 Ws_a458TZzE.jJhaSPduyqMMEjWRIvnZA85HZeSV4C4GO3vWunVv3nBsndOpyVL8o23pWl8wACtE 4NAdEKWm1v9TLyi0SUGrtPWsR8HRqfHYF1xeWxexNq3_EUyEJ4LvL.sGcKGcyeVWimxyvDlZdlVq L6aLPlURhBKXBdg9hI6nimkpWMl7CilrhRxqFK.kdxKLlOMFrPuy_r7.CZFIauVBZH6djZUQGUhX vJ7_64I6nbmjhksVcPOgmzJROxTvlZZZJxFBOmrAVQrbEQ9kcPoFy_StCpsKTEDC7lZSdxH_KwyS OIPXkLWNCNsNro69PnsKjxjN6v11TEvGnq6pQS4sV0Y3tYgxrE0D6WaRr03JdwSh8Xlae4KDUXCh OKd_m1_bR X-Sonic-MF: X-Sonic-ID: 9f821197-9d34-4c7f-8ba2-5d754d26b33b Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Fri, 1 Nov 2024 00:54:07 +0000 Received: by hermes--production-gq1-5dd4b47f46-bxhh2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 41192b152a6537210961346ff4c58ba7; Fri, 01 Nov 2024 00:54:02 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: cf1aba2857c1 - main - freebsd-update: refuse to operate on a pkgbase system From: Mark Millard In-Reply-To: Date: Thu, 31 Oct 2024 17:53:50 -0700 Cc: dev-commits-src-main@freebsd.org Content-Transfer-Encoding: 7bit Message-Id: <22FC2477-98CF-419D-95EF-C999F8841525@yahoo.com> References: <7FF78752-80EB-47CA-9E60-515607D3CFE5.ref@yahoo.com> <7FF78752-80EB-47CA-9E60-515607D3CFE5@yahoo.com> To: Ed Maste X-Mailer: Apple Mail (2.3776.700.51) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4Xfj6m727rz4Hgv X-Spamd-Bar: ---- On Oct 31, 2024, at 16:37, Ed Maste wrote: > On Thu, 31 Oct 2024 at 15:17, Mark Millard wrote: >> >>> + # Presence of FreeBSD-* package(s) indicates packaged base. >>> + if ! pkg -c ${BASEDIR} info -q -x '^FreeBSD' 2>/dev/null; then >> >> Slight difference in the comment vs. the code's behavior? : >> >> Comment: FreeBSD-* >> Code: FreeBSD* > > The code is a regex ^FreeBSD while I wrote the comment thinking of a > shell glob - it's fine that they're not identical (except for this > confusion). FYI in case it is not clear: I understood the 2 distinct notations. I was only trying to indicate that the matching text sequences for the 2 notations used are different. FreeBSD-* does not match: FreeBSDPkgBase ^FreeBSD does match: FreeBSDPkgBase Do you want FreeBSDPkgBase to be a match in actual operation? > That said there is room for improvement here - we'll want > to detect pkgbase installs in downstream projects that use a different > package naming scheme (e.g. packages starting with CheriBSD). > > I'll keep a note of this comment for any potential iteration on this. === Mark Millard marklmi at yahoo.com