From nobody Wed May 29 17:18:21 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VqGLP6llkz5Msgj; Wed, 29 May 2024 17:18:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VqGLP5vfhz4n1Y; Wed, 29 May 2024 17:18:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717003101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uaUCyigTlVjgwEJywyeWd+pFo01mEycCKF8uLt+e4pE=; b=j18HAUQ4KevR2dv2bM/hWfF10cQyicWOGFK74qTcA6mbb9GS0oX1WL62z25RkW2Q1SxhTg /0/hpwQJg6eZOc+diP7TOMdiOP/+Ne0bAgH6bslB/mXUUgTPqaSTi6rvfkXALQTJWwQRtA K8pBQSMIO5Vtn9tahiKIHdcG5JCG9pQynFgjK6LcWqz53g/X0lN4Tjvy4hFSsAnpXXGjvt j172apX3Ew6XMc85fEMSTne/5Xh1c4nO+1J+w47Cm2S4+NtfPpP1Exisp+VaxzelY8jVpR udtZO7chtItv23wz3C+3xf2XyacdrE3qW72h9glFtiUAMiAbBUMCR83rj0AJMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717003101; a=rsa-sha256; cv=none; b=HR5/KxZbG86MG/MlT1vovCudcy6tJFNhOgLVp3pEPBj7xrOdQgOrTphoGIWOxmVaLB0u6W DUrl/ZUaCdFYf/c0lLYUnyPS9ISTeACY1vFLTiN0DYgyo0Rr02ClCvclaaSLA3k2Ecd2yE 4VDINaGKZGD6CnnRIDYMjsGZHd3ZNyyNagNByLBJkgr4jVHcyrWbKxHDnL4F9Nt5QhNopD mRsiKkGxurgn8SkWnAsIXIrCXhZYwJDl/lJ3+hgDLTX0car/Oe4g5n5/bGCfaYRRzwaorT JGiK5sidotJrgy+wn+A9lkONk5NqAKuOEx6IwE1dqwA6br21PWZoxi/tw/Z+HQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717003101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uaUCyigTlVjgwEJywyeWd+pFo01mEycCKF8uLt+e4pE=; b=LMb9RhvCquzt1UMRCUT1AoFA8nyOw2BAqPKnI5ZwYE89bz8AGxw+Z/938H1pxED182QDUU sZn3Y7T7QtiAr2M9h0ytSclTheU+KIfE0sxMYUNfCVIQCP9KYfYoC27Z4JGVVNL0N7xt+y 2n4iar3UYF/JaGCK+f3IASCDI8cJoiAoyomVJcH+TgMbj6HEBB+y2NVpMxrCY2gXAqpKH7 i3OSprzU8DGCV1/tvFMkAeGEyb6CUPAznA2v30o07cXIenSi2uliXFp7x6qXMOcLgrCejv Jjwqg4XscOK08Vwa0WiK6igHgt0TfPp/kmxp+PJRmTi2hZMa/Aw4w65ZPypa1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VqGLP5Pp6z14ct; Wed, 29 May 2024 17:18:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44THILS9069418; Wed, 29 May 2024 17:18:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44THILvt069415; Wed, 29 May 2024 17:18:21 GMT (envelope-from git) Date: Wed, 29 May 2024 17:18:21 GMT Message-Id: <202405291718.44THILvt069415@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: b661d9e64d73 - main - Revert "checkstyle9.pl: Add check for missing space between ) {" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b661d9e64d73a244873fb2aa6c97e95a988fb758 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b661d9e64d73a244873fb2aa6c97e95a988fb758 commit b661d9e64d73a244873fb2aa6c97e95a988fb758 Author: Warner Losh AuthorDate: 2024-05-29 17:15:24 +0000 Commit: Warner Losh CommitDate: 2024-05-29 17:18:00 +0000 Revert "checkstyle9.pl: Add check for missing space between ) {" This reverts commit 6bad7d2486b373015db5917d7a9641266861c607. Turns out this special case wasn't necessary, and this was already detected and due to another error (running the script got dropped from my experimental scripts), I hadn't noticed. Sponsored by: Netflix --- tools/build/checkstyle9.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index 7c2b2c0f5b5b..24e33712ceda 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1556,11 +1556,6 @@ sub process { } } -# Check for ){ - if ($rawline =~ /^.*\)\{\n/) { - ERROR("Missing space before brace\n". $herecurr); - } - # check for spaces before a quoted newline if ($rawline =~ /^.*\".*\s\\n/) { ERROR("unnecessary whitespace before a quoted newline\n" . $herecurr);