From nobody Thu May 23 21:32:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlhHF3YZfz5LNDR for ; Thu, 23 May 2024 21:33:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlhHF0mdXz49Cp for ; Thu, 23 May 2024 21:33:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a5a5cce2ce6so1074802766b.3 for ; Thu, 23 May 2024 14:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1716499991; x=1717104791; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4oXjtGuMMopfym7B2P+Mcemt3QmJZ+9qmURhj7KilKI=; b=kC1qA8GbGnb/IXqszYgZoWQGSvwIVLLTyuuzR8fovQzTT4gDCT8qOvSrVBlA5/yXCN XNiz5NEjMjfWIQ8RMNbt8zSSlfilMRg3Cq0hpJix2FMpZAh5NQAWSTIDldscKOaaO29l Ud5AWjT2eRGx+eLQw939PXOvvLq4/ByXflVwnvcPFEIXRCHFVITNGmvU1lQiBSf+qPK4 YhY66IClsaXTLSH2fusW/643kUUiz3SBJldliUEWklWTkQPJqDdbObO9bQ+Aitgig7/Y VMlJveBLdgbUTKc01o1woSPXi4orv/FQsGxRzNKujrwqx9CVFeNQFXGco7DSak91mtxL coRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716499991; x=1717104791; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4oXjtGuMMopfym7B2P+Mcemt3QmJZ+9qmURhj7KilKI=; b=kGQpNv0qftLfnU3hKTE7wUkOb77KThdrNrdIQNsIw+qhuqA+ktaBSf3H66ylx9/vv/ W9boO5wwwMx7lYU6pz7Y0+U+QOxQ/+foViPZ8IBxrn91FzYYEkOTp6EAuHrpU3kFZlvb 4bzCuBUO820BVlS2bkUBRaxVEAmf77ERQf8xg7MSUbHaK48P0Fs8ewyTLMDlFw8z0XP7 YCMAAtZqRzAA2sEs/YT6JmmOeLaX/OTIkmE00wQeMfoQ/GTs30xVGkcBC28gCKhyo2S3 +tFxygRJ1XCOjjxo+8pLx2+8a3KQncKe2WglWM1gd+3a56SwR2BENWGG3f2i7wLVns8j R7rg== X-Forwarded-Encrypted: i=1; AJvYcCWnFGLihXhbKaVEHvpRSm/oPTZ4MiTv68b31HDwU2Ym7Z0Whl8Uj4PLxjVkwkJIFo+xujl6Rj9q+JFiMxbzplNla6II9tufUhdh0wpJxae9fA== X-Gm-Message-State: AOJu0YxJqX38WrBOzi5RSJuRAOJ8kVmlVkDY8AYmDaqryXsv+/XSfPlJ GSa7zFwDfXLxNzGNvLLEpT1BOTeyJpgfXKGqNlkJQhxdXtGkugLKzCEtZ131rYpttc1y2WN8CbA 4DAM0Q0BLmVIPNeAeL33jyWhAAfWWgCJc9+CTAw== X-Google-Smtp-Source: AGHT+IFgvXyOJlpZ00yPrMFZLl6uloymiLtw3VxlVlxnvlYdleQgx10qS92XUn2M3+5ESCkhUvbQesLFDq6gwEPdj6M= X-Received: by 2002:a17:906:2b82:b0:a59:c3bb:b83b with SMTP id a640c23a62f3a-a62641b1bbfmr27836366b.1.1716499990792; Thu, 23 May 2024 14:33:10 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202405231800.44NI02TZ002201@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 23 May 2024 15:32:59 -0600 Message-ID: Subject: Re: git: a5f03413aade - main - ci: Redirect output for builds. To: Brooks Davis Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000356b0f061925cc64" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VlhHF0mdXz49Cp --000000000000356b0f061925cc64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 23, 2024 at 12:41=E2=80=AFPM Brooks Davis = wrote: > On Thu, May 23, 2024 at 12:34:03PM -0600, Warner Losh wrote: > > On Thu, May 23, 2024 at 12:24???PM Brooks Davis > wrote: > > > > > On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3Da5f03413aade8f69cf954162151da04= 3d34dd1f5 > > > > > > > > commit a5f03413aade8f69cf954162151da043d34dd1f5 > > > > Author: Warner Losh > > > > AuthorDate: 2024-05-23 17:37:01 +0000 > > > > Commit: Warner Losh > > > > CommitDate: 2024-05-23 17:59:40 +0000 > > > > > > > > ci: Redirect output for builds. > > > > > > > > This target is far too noisy to be at all useful. Save the > output ala > > > > make universe in _. files. Also report where to find errors. > > > > > > If this target is intended to be run in a variety CI system then this > > > won't work in practice as many have no way to preserve the contents o= f > > > the files (jenkins does with sufficient configuration, but then you > > > have to expose it to the world which is a security problem given its > > > vulnerability history.) > > > > > > > This is a developer tool to run CI before committing. It's not going to > run > > in Jenkins. If we want that, it will have to be a different target. It'= s > > way too verbose otherwise to be a useful developer tool... so verbose a= s > to > > not be at all useful. > > I think we have different take on the goal of the project that created > this target. My read was that it would move the core CI functionality > into the tree so developers could run exactly the same things jenkins > does and thus debug issues more easily. > > For reference: > https://freebsdfoundation.org/project/continuous-integration-enhancements= / Yea, I'd helped write the proposal and so maybe my perspective on this is skewing things. The goal was to run the various things that jenkins will run so you'll know whether or not you'll break Jenkins. I'm happy to revert and just go back to using make tinderbox w/o trying to do a smoke boot for landing pull requests. Warner --000000000000356b0f061925cc64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, May 23, 2024 at 12:41=E2=80= =AFPM Brooks Davis <brooks@freebsd= .org> wrote:
On Thu, May 23, 2024 at 12:34:03PM -0600, Warner Losh wrote:
> On Thu, May 23, 2024 at 12:24???PM Brooks Davis <brooks@freebsd.org> wrote:
>
> > On Thu, May 23, 2024 at 06:00:02PM +0000, Warner Losh wrote:
> > > The branch main has been updated by imp:
> > >
> > > URL:
> > https://= cgit.FreeBSD.org/src/commit/?id=3Da5f03413aade8f69cf954162151da043d34dd1f5<= /a>
> > >
> > > commit a5f03413aade8f69cf954162151da043d34dd1f5
> > > Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org&g= t;
> > > AuthorDate: 2024-05-23 17:37:01 +0000
> > > Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org&g= t;
> > > CommitDate: 2024-05-23 17:59:40 +0000
> > >
> > >=C2=A0 =C2=A0 =C2=A0ci: Redirect output for builds.
> > >
> > >=C2=A0 =C2=A0 =C2=A0This target is far too noisy to be at all= useful. Save the output ala
> > >=C2=A0 =C2=A0 =C2=A0make universe in _. files. Also report wh= ere to find errors.
> >
> > If this target is intended to be run in a variety CI system then = this
> > won't work in practice as many have no way to preserve the co= ntents of
> > the files (jenkins does with sufficient configuration, but then y= ou
> > have to expose it to the world which is a security problem given = its
> > vulnerability history.)
> >
>
> This is a developer tool to run CI before committing. It's not goi= ng to run
> in Jenkins. If we want that, it will have to be a different target. It= 's
> way too verbose otherwise to be a useful developer tool... so verbose = as to
> not be at all useful.

I think we have different take on the goal of the project that created
this target.=C2=A0 My read was that it would move the core CI functionality=
into the tree so developers could run exactly the same things jenkins
does and thus debug issues more easily.

For reference:
https://freebsdfoundation.= org/project/continuous-integration-enhancements/

<= /div>
Yea, I'd helped write the proposal and so maybe my perspectiv= e on this is
skewing things. The goal was to run the various thin= gs that jenkins will run so
you'll know whether or not you= 9;ll break Jenkins. I'm happy to revert and just=C2=A0
go bac= k to using make tinderbox w/o trying to do a smoke boot for landing pull
requests.

Warner
--000000000000356b0f061925cc64--