From nobody Thu May 23 12:34:21 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlSKX4GTfz5LdNt; Thu, 23 May 2024 12:34:24 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlSKX3nH5z46g1; Thu, 23 May 2024 12:34:24 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716467664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KyWQ/AfJ5ZSrpuX1fPR9x7QLdQdP5rU7fM00II+8cdo=; b=Yy6+H/7ThawCEs3fgTTL7snK2TT6XTa0DQv2zbEAGIdcwSH5z+tnBOaJG9JM850K7i8nkJ 9B1/j3ASbTxb4FBJvs7QGn+z8DpmrpP0z8QuxmNpmeAUAY3kGdgt7DUERJ6tk4zfMM5Lbq bS8mIHq+GySiAx33TLY9K5SDmAAZG/RjYCAuL08GDEOel4Nll0EIyHmoT0yfmOe3c6JoGU z3fM4jtXI5u+o6Dys4nXyI8BN35RtUnGi3zCh6dlf+Ksk4deJfldDDd/wj9L4aUfA4dt6B CeOcrr6Be6g2jKjkOktpxG9VHAdHwqUcV9aUvo1w4pA0M1j744lcsSw4XAaYhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716467664; a=rsa-sha256; cv=none; b=rAjAaNMTZH4/4lmYS4Ucv/LpSfxgzQ8K0jC5jbwWOTPwwAAVjDDW7EcbLBuxyfPvxiLP2H aBc5lReVXRknWZHhzIeG1TfTBuoj6fmt+jgFwW429Fk9ea7KvNbLooUNNYeIAyuQcyqajm z8YaehqGK+hvRGMgi2BEsaWuCkQCutWYCDY73veuRTad/YakDXz/1XMABpwEB6P7myFuK0 YmBxp7GJUF6FOXyABFpt/tN3iOpsYKXsXGIZfoByRO6oXigEYo+WhniS+RiuEg2DqtvNFL 5ntkZgBCWPXV/Dqr+sAj68nrn/TtBGjwD127aAms3yIbBhKCm8B2kGlO5/Fdmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716467664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KyWQ/AfJ5ZSrpuX1fPR9x7QLdQdP5rU7fM00II+8cdo=; b=ZCvuwk6jon3D13XWPt58FETbyTjVuaRDwdKX0HOgM/TohUoFpD58essS1ABUa4XhQ4CzCm X/aEfthRzm5bCxwSDm2/JFCVsBUKvkS5AByfAyU49gBR3LdNTwPs/ISoBLVjw4U/7fZ0Ly 0k240pMPzXb7rvFNUc+WMXL5hBQxsiW/M4bZvwBysQqV5i90pR66+jnBTjJT6zNHizHs0i kf53tjE6B014bctjcjUfd+srCXSJrEcpRsx6HZAuy6oUpDdAzqi7wklpmEA7rXYu/JC/7o 9mp1qEoFpYK0WvVrJmOVjSrNaC5L/2Pcwf9luW4B78X0pA50iwpDkHrb1DNohg== Received: from [192.168.1.23] (unknown [147.161.168.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: michaelo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VlSKW52Lpz1QZ9; Thu, 23 May 2024 12:34:23 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Message-ID: <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> Date: Thu, 23 May 2024 14:34:21 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() To: Mike Karels , Baptiste Daroussin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> Content-Language: en-US From: Michael Osipov In-Reply-To: <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-05-23 14:10, Mike Karels wrote: > On 22 May 2024, at 10:07, Baptiste Daroussin wrote: > >> On Fri 03 May 07:40, Michael Osipov wrote: >>> The branch main has been updated by michaelo: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=aa48259f337100e79933d660fec8856371f761ed >>> >>> commit aa48259f337100e79933d660fec8856371f761ed >>> Author: Michael Osipov >>> AuthorDate: 2024-04-15 11:05:17 +0000 >>> Commit: Michael Osipov >>> CommitDate: 2024-05-03 07:38:55 +0000 >>> >>> periodic.conf: remove long deprecated security_daily_compat_var() >>> >>> This function is documented to be gone in after 11. Time to remove this >>> compat shim. >>> >>> PR: 275296 >>> Reviewed by: jrm (mentor) >>> MFC after: 1 month >>> Differential Revision: https://reviews.freebsd.org/D44796 >> >> this broke pkg's periodic script, I would have appreciated a heads up to give me >> time to prepare a release compatible prior this commit. >> >> This also breaks some ports. >> >> Bapt > > This produces almost a dozen failure messages in the daily security email. > Given that the deprecated function was still in use, it should not be removed. > Michael, please revert this. Salut Baptiste, Hi Mike, this is surprising that is it still in use although clear marked as deprecated after 11. Though, Baptiste has pushed a new pkg release yesterday [1] and only main is affected, do you still prefer to revert this commit (for now)? @bapt, can you name the affected ports and report a PR, so we can track them? Michael [1] https://github.com/freebsd/pkg/releases/tag/1.21.3