From nobody Wed May 22 19:55:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vl28t0j5mz5Kc3S; Wed, 22 May 2024 19:55:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vl28t07QCz43Cr; Wed, 22 May 2024 19:55:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716407726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJg58uSMvRqat4DB3n49tTIKCHhtrIsCiRUmoJ9pCdE=; b=hik+OTw3hgtru7TFsL2XaBnLWk+uiSnAnbxgeawD3IQu1+6E9dtbrImig3+d+LjjbHyrPi GAPN41uSYC7ZTOFYkWVgVH7K6BECqF5NTvItrYY6kYqQKq13yx60iAoFPoIwx40WTInemz SGvGjPHaqkmn7Ily9z7o2nW3y8JdebNpSVfD4/RbOQO4d2quHFdB5t3P5JtF3Gg1JVixnx lpXX9UEOdziWqZ3dgMnr3BJaoAVmBn/2Lky6y4EhbtASRE1kzB583e3imGvL7xSGA8jxBx Bf7S+4ulgEJowNlW2I8FSrlWKHciSk+Lx2e05WNSmozHXNgNKYKzh4KgAXwaUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716407726; a=rsa-sha256; cv=none; b=rhG83DxWlwTE223GG5ECtnz4eGaaRqstBPHYD8wBrcisLM4hsXt1M1xKZHR4NnJWArnd3l fK53Wxebrqw0pSdM0p62McWLjq2VJ0X46xiJMpuz56Q001+L8kriZXK5I6bAGy0sH51kDz mtKclgWyKGGFuzKKmI3Sv4UwH9U60bp12nCOP6eXJzAjCAreCV53p6yNBvsow0Dj22167U LNiudZWkSB7E9MAil4eBjhxWDYBTEfAj6lPFzhYX5iXO0zttDw/BvW6e71Ym6Z+SdOTYGk AjyN9LPGr52hT9CitCvSn+DxeLj7B6q0fnROKaNnIlgd/OExYE0xSe2oAHGS8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716407726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJg58uSMvRqat4DB3n49tTIKCHhtrIsCiRUmoJ9pCdE=; b=KfCV1ih0qek5kX/A32VnE/eMKHfdxTt+yWViL8Ah6o+qPUa1PVWMbOwS9s6LtneHHUw5Km OAPALFXYiGNzpM5qS80VozHl75WrvSAA2HCpmRaNX/v/1U2SI7qSVgA6w9yleEshyWASWL p1gkc2qR1NKX8LQPnr52BFQNl7CJmkiRRkWSbAtI2owX3A4Fl68d3P4QYjDZO3ovFxvvgC pF+lqIfsK7drB+7symVeVKNLkc3jKQgSMfbzFcMn9DXm0SWPkgzPiqT9hkm/PS/TYOXN9V jLNqcu6e41rVm3+bbqIrYBqDGhFnKwm4Z8kcnAjV6cOzCNZDPGiufoi+zTTABA== Received: from [IPV6:2601:644:937f:4c50:b136:2176:fd7d:9c11] (unknown [IPv6:2601:644:937f:4c50:b136:2176:fd7d:9c11]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vl28s27gNz15Cl; Wed, 22 May 2024 19:55:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <3edabe3b-4b51-401f-ad64-e36c84fd455b@FreeBSD.org> Date: Wed, 22 May 2024 12:55:24 -0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 408957613bc0 - main - Regen Content-Language: en-US To: Dmitry Salychev , Lexi Winter Cc: Mariusz Zaborski , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202405212004.44LK4cBG042804@gitrepo.freebsd.org> <86r0dugmik.fsf@peasant.tower.home> From: John Baldwin In-Reply-To: <86r0dugmik.fsf@peasant.tower.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/22/24 3:36 AM, Dmitry Salychev wrote: > > Lexi Winter writes: > >> [[PGP Signed Part:Undecided]] >> Mariusz Zaborski: >>> The branch main has been updated by oshogbo: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd >>> >>> commit 408957613bc065c4444812c3ae276ace03697ebd >>> Author: Mariusz Zaborski >>> AuthorDate: 2024-05-21 20:02:50 +0000 >>> Commit: Mariusz Zaborski >>> CommitDate: 2024-05-21 20:03:20 +0000 >>> >>> Regen >>> --- >>> sys/compat/freebsd32/freebsd32_sysent.c | 2 +- >>> sys/kern/init_sysent.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> i'm sorry if this is considered accepted practice in FreeBSD (i'm not a >> committer) but could i please request more useful commit messages than >> "Regen" for things like this? >> >> when looking through 'git log', especially 'git log --format=oneline', >> it's really not clear what this commit actually does, meaning if i'm >> looking through the log for commits related to a problem i'm having, i >> have to examine commits like this by hand to see if they're related. >> >> it would save me (and other people, i suppose) a lot of time if the >> commit message could at least mention what it's touching, e.g. "Regen >> sys/compat/freebsd32/freebsd32_sysent.c". >> >> [[End of PGP Signed Part]] > > Looks like it slipped in by mistake. I expected it to be reverted and > re-worded. I don't think it's worth reverting at this point. For `make sysent` I would suggest 'sysent: Regen' as a commit log in the future. We typically use 'src.conf.5: Regen' after running `make makeman`. -- John Baldwin