From nobody Sat May 18 13:10:13 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VhPMB0kpMz5KllQ; Sat, 18 May 2024 13:10:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VhPMB00V4z51Lg; Sat, 18 May 2024 13:10:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716037814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YmnjISzJ7xzrS2xZM8w+HU9S+13IQ1Xj/fhmfCeYlCM=; b=rd+lE4KqB/zRRsynKsFAZ2jAZWOBYdk2kBhdqtphP0pdM/clz/2JZYdwbayLl6qo1OWUOB u3VeWSho31Y3uSILrM/J8PAwv74IsTrPfAxK1VURzwYsb1B1AK8CKLmfpKKlm/i11cvqN+ alM0ygrRe/xCtyUX6w18mPSX9Z4RNQvJbqfHcuGDqTig807AsYx96xIc4ZHv7M7y4tvUwu 0+4dFdbVrxeVftilM5I7OAkPj0CRL6z9krCfAfORji0efQNHBYQEIsPGjOM+BmSkff2z1Y VTUtrctsHdphWS1iphkk06qre94CXIdHx2UqeQCr9mwVBJhz01XAS+2Gr7lr2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716037814; a=rsa-sha256; cv=none; b=o8W1oNm1lyH3PlNeOMlV/ZTewrvcFsYMH/U0JNBmhOaeIyEpPVTfhw4k46BXQEsKJw06gA w0Dnj7FxkYELqixNBVyAV/KhxRk0EcADC/w8aBA3LCAM3RDfuVJrIoENMJ0k8RZhQnx1Ev 9chFaYBhbujFyNUN7WVPFVq1kddWYHL/k2Fsr/oXQWYWQZaWnJkxUSrM5Vr7jSpnBhogn9 NwGmkIn5aqPgO27k9WUaOFx1OnDp7lHxRsL5lHzDrIqdLH1DeUyHcPLdBjpYi070Xon/Rd 0dMbg5NoYoejP9RltKNSN7xSA2jsF8HZfEP1v5LoIml+hlCv45OK45OC7LgtSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716037814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YmnjISzJ7xzrS2xZM8w+HU9S+13IQ1Xj/fhmfCeYlCM=; b=LAZXkVSHTky6s99Pz1jJPIzgjLQqKvqtpNdA22RLITd/xnRpHPt2u0SkwTCvnc5+Er9b0W xejszACeVtMRAlZNTHsVacF8//+AM4nFxc2TSok43D8+3gww1iK0QDatSrMm51o1N1J5kV KS7cViZFhjfCjm2fPhrKHWqPbiuGvbkkrAVY/l4DG8yKVXPfDtHQueCST4bK/FTMdLY3XC 8SySrNpOwRfjJ6ZxymOq9KjsffK2J3svdxUYNN5yVtkdsiPKh/7hwOKQ7zTOcPm39muLbs HkaN+mfDYiUG8Y3wJOaTsVTVVlclvVO0lD9IElHoq4ZRKifRAo1sAuAH/mhliw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VhPM96Q3XzQpN; Sat, 18 May 2024 13:10:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44IDADOp085655; Sat, 18 May 2024 13:10:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44IDADZC085643; Sat, 18 May 2024 13:10:13 GMT (envelope-from git) Date: Sat, 18 May 2024 13:10:13 GMT Message-Id: <202405181310.44IDADZC085643@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 97aedd3395b4 - main - devctl: Disable the boottime optimization of suppressing NOMATCH List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97aedd3395b4e9b017e29823096771aff0835ff0 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=97aedd3395b4e9b017e29823096771aff0835ff0 commit 97aedd3395b4e9b017e29823096771aff0835ff0 Author: Warner Losh AuthorDate: 2024-05-18 13:07:16 +0000 Commit: Warner Losh CommitDate: 2024-05-18 13:07:16 +0000 devctl: Disable the boottime optimization of suppressing NOMATCH The usb bus code (uhub) doens't present the same information to devctl as it does to the NOMATCH events it generats. As such, devmatch fails to find USB devices on boot when NOMATCH events are optimized out. Since the savings of boot time is relatively trivial for all but the most demanding boot environments, disable it by default until this issue is fixed. Fixes: 6437872c1d66 MFC After: 1 minute Sponsored by: Netflix --- sys/kern/kern_devctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_devctl.c b/sys/kern/kern_devctl.c index 0dd05a49c9ad..602b82105525 100644 --- a/sys/kern/kern_devctl.c +++ b/sys/kern/kern_devctl.c @@ -89,7 +89,7 @@ static int sysctl_devctl_queue(SYSCTL_HANDLER_ARGS); static int devctl_queue_length = DEVCTL_DEFAULT_QUEUE_LEN; SYSCTL_PROC(_hw_bus, OID_AUTO, devctl_queue, CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE, NULL, 0, sysctl_devctl_queue, "I", "devctl queue length"); -static bool nomatch_enabled = false; +static bool nomatch_enabled = true; SYSCTL_BOOL(_hw_bus, OID_AUTO, devctl_nomatch_enabled, CTLFLAG_RWTUN, &nomatch_enabled, 0, "enable nomatch events");