From nobody Fri May 17 20:51:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VgzdV5mLrz5K4t4; Fri, 17 May 2024 20:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VgzdV5HJ1z4J9x; Fri, 17 May 2024 20:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715979070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IiVSU2cVa9Ei/AeEuIZoMuXFt9Rb+FWuNS/lJL2e5BE=; b=mc5algdLIW1/t6tzSxacdr8MWYdCuEBTaG/nb59xp5LVWOMYE7crFmnmJ97HDKmaBMW3f/ 0Nahe6sghb2fl/TkQXCN3sJqPReOCWAgfYg58LOEBjdpTLGPy89gWMnKebBMbe/KZPeRHW XBbpd9kmb4nhb3zit8Mpdm7ujmjNxDSIFwKu98WRwMXJT9AC7AOV3yDHUZaT1kwSx3QVBK dQznmpVhTe4l/Pw6iODlZvpW4Yd337Gt/8/QIAnI38l/L2O/J4A5P1yIC9wAiv+JrIARlX EEvsbc9UkSlEKpEpaTNvyl3Ztd6dM5dfOXwljX0bcTZWB0xJSmFX3Yx9fAWl0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715979070; a=rsa-sha256; cv=none; b=QaUgjMgrAXn+ZPldumuar7YdG97YLGbLQmf7xw+iLnyhVJUlwV5moQBqjYCHrTCvCArLBA X2M8hrY/OOCySIkKq65QIImJAvcyMcaOt1lh0BWbE9p/7CydYgUBoe3Ig6nL213/dvCqdd AN3p3OCARQTdF6HmkEG6MXvOPKORUNihrIJevy7ZOw5qOidrjfi5PrtdQhoJUHx9v7FVUS CDRnbVp0TAD22fs3pJNLnOk9EDWLoDY4xYTx2LFUCRCaXtDaHmze3UNkEC3wHQJvXYOvM1 Ww+HDMTN9x2HgEQHWbqexcZ9C/1JF645g1YExWG7lifInopTnpYBY9nsI3MdIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715979070; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IiVSU2cVa9Ei/AeEuIZoMuXFt9Rb+FWuNS/lJL2e5BE=; b=qsNUrrb9H3dvbkOi2CXLiIaV/Yi8OJ9sikj9g6Tk3e0ROKnXSnJsuIUis2qQFHnuJlrPKT xnNF0Z61fdZzVGUnTYJB+9OPQnqzP2lHkt8tdoDWkCM1sIvoEe9ALS6X7aC6DuziVFkEy3 Va1CCqXH4PFils/CJ0q46QIuE86Db3e56xFrftvWPVSUqxgwPg8gXk7zG0pCumuF/AynEq xSKxNQUkhkjzmW5hpIvjwhDjwnSzwiUvcDKjc3EdI6w8Ux0Zy65UviBcFqM5sBWYYRrg7e 2TiZTUA/yAEfS5DEe+6Z/yzzPyYU3dIZjuWUizL7niybEOKxn3PCTiOOCPArCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VgzdV4tjnzy3B; Fri, 17 May 2024 20:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44HKpAFG037640; Fri, 17 May 2024 20:51:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44HKpA1G037637; Fri, 17 May 2024 20:51:10 GMT (envelope-from git) Date: Fri, 17 May 2024 20:51:10 GMT Message-Id: <202405172051.44HKpA1G037637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 1062db307002 - main - libcxxrt: allow build with gcc13 and --no-undefined-version List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1062db30700230a26fdc90088a4e2bdb6b6e4d6d Auto-Submitted: auto-generated The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=1062db30700230a26fdc90088a4e2bdb6b6e4d6d commit 1062db30700230a26fdc90088a4e2bdb6b6e4d6d Author: Brooks Davis AuthorDate: 2024-05-17 20:22:22 +0000 Commit: Brooks Davis CommitDate: 2024-05-17 20:50:57 +0000 libcxxrt: allow build with gcc13 and --no-undefined-version GCC 13 supports _Float16 and __int128 on fewer architectures than clang and thus libcxxrt compiled with gcc13 is sometimes missing related symbols. Hack around this by explicitly appending --undefined-version to LDFLAGS in problematic cases. Reviewed by: theraven, dim Differential Revision: https://reviews.freebsd.org/D45233 --- lib/libcxxrt/Makefile | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/libcxxrt/Makefile b/lib/libcxxrt/Makefile index 6ad89e9da107..7a683ba779f6 100644 --- a/lib/libcxxrt/Makefile +++ b/lib/libcxxrt/Makefile @@ -42,3 +42,13 @@ Version-64.map: Version.map .endif .include + +# gcc13 doesn't support _Float16 on riscv, powerpc64, and x86 or __int128 +# on i386. Disable checks for missing symbols to allow this to link. +# +# XXX: This is a hack that hides an ABI divergence between clang and gcc. +.if ${COMPILER_TYPE} == "gcc" && \ + (${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \ + ${MACHINE_ARCH:Mpowerpc64*} || ${MACHINE_ARCH} == "riscv64") +LDFLAGS+= -Wl,--undefined-version +.endif