From nobody Thu May 16 07:41:26 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vg28l2Cvcz5Kmsm; Thu, 16 May 2024 07:41:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vg28k6lRtz4M78; Thu, 16 May 2024 07:41:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715845286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HBiWpqTFlfEFpEL3kDvEPtDq+Y7n9BHiHsDJAlx3Qus=; b=fYyJlLl9rbxkc1EANr9lycd2CpLyngmV898vKDgt4EF1qOH6jCexUdkzbXhQnmo+rgwXFU yjlBx3at8mc/kzSqSUBgr/CAJ6rQsK+Vr+qyNTyrX3Ul+BNnF2NOT4s6TBmmJETQ18kEe1 y7CswbjIIuERyQMtyeRexb0xRGbmYA0i9S3PLHesohLodEPvokh8vYEbuzndcVm4wScSSY hFSfqh+70HcfPTPJ8vIsVjwRdyscwclrUJKsgSWjP/hzBYyke/qDV3qbeMsbZiUp85P57B 6CNpv1TIkbldrk0RVU9VOITIW55oPZAynq1s5LRfInt0YUCFTpY4w5amw3alJQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715845286; a=rsa-sha256; cv=none; b=enHZZOOwmyWSjWx1/FYECcDDBly7PrfbIJeTWAUOUkQBoU0QXJfHos6OoKLqUA7uhI0g16 vcywKnM/dj6oSb8aKs6hwIilojyC0TazGYhO02bSF2Sh2l182XWLY8SYxoLZzYWaie+u3S AyWd7BfMC0RkfCvJyTuyNDPM2kq96lnOaeproSL9diF0igDqsryjpzD0P1GoI2yYBLWf47 h8BElxDTYsSHXki08bfQrMbVBrd6sQJXzzfH63eYIZOOwGVOkQO5o7a7OTiktMtPPPbP5I VNB9aEykcrenFbNf/DWbwjVWZUFS+6yUugVFis2aBvizmdaMGTGDs5gSdqQkyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715845286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HBiWpqTFlfEFpEL3kDvEPtDq+Y7n9BHiHsDJAlx3Qus=; b=B0o0HoH2FgdpKv6oc+LQdZPcSGYg5GlIqoPcb34AmoMY7ucVZoXA3U8c/Sdkpv8d6sdcuJ VuWqdZiRYdUlcsKOC9vrg2ohLW2L0S5vu0qxuBIQSx2hhoZp4HqnzHcBrOOejJ3IHiekll XihjQrG5ALXkLb5X1GjEDXwNHGlX49i+zagsfkacSEK3kpqyPXqe9iBpeRa6p+BZvxM9ok YBeUEza9WQRQReWyxsPTFpOqC7zJWPag06Nna1Ziuh5dllru9DNHBpjv/8dp1K0IugJvJ/ PqP6Oth5cOL2dirqXK9wZC2tUbuWqGwmEnQS4Zch09ErDmDWdIBIQR2yfbRqoQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vg28k6MY1zqY1; Thu, 16 May 2024 07:41:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44G7fQ4R068115; Thu, 16 May 2024 07:41:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44G7fQMI068112; Thu, 16 May 2024 07:41:26 GMT (envelope-from git) Date: Thu, 16 May 2024 07:41:26 GMT Message-Id: <202405160741.44G7fQMI068112@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: abb1a1340e3f - main - linuxkpi: refcount: Use atomic_t directly List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: abb1a1340e3f0dcdbb81b5c42ad304f02c812e20 Auto-Submitted: auto-generated The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=abb1a1340e3f0dcdbb81b5c42ad304f02c812e20 commit abb1a1340e3f0dcdbb81b5c42ad304f02c812e20 Author: Emmanuel Vadot AuthorDate: 2024-05-15 09:50:51 +0000 Commit: Emmanuel Vadot CommitDate: 2024-05-16 07:40:46 +0000 linuxkpi: refcount: Use atomic_t directly Simply use a typedef for refcount_t on atomic_t, this allow us to use a nativ type and also changing struct kref to directly use a refcount_t like Linux. Reviewed by: bz Sponsored by: Beckhoff Automation GmbH & Co. KG Differential Revision: https://reviews.freebsd.org/D45207 --- sys/compat/linuxkpi/common/include/linux/kref.h | 3 +-- .../linuxkpi/common/include/linux/refcount.h | 23 ++++++++-------------- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/kref.h b/sys/compat/linuxkpi/common/include/linux/kref.h index 47d61c9ee316..b2fba468f7df 100644 --- a/sys/compat/linuxkpi/common/include/linux/kref.h +++ b/sys/compat/linuxkpi/common/include/linux/kref.h @@ -41,8 +41,7 @@ #include struct kref { - /* XXX In Linux this is a refcount_t */ - atomic_t refcount; + refcount_t refcount; }; static inline void diff --git a/sys/compat/linuxkpi/common/include/linux/refcount.h b/sys/compat/linuxkpi/common/include/linux/refcount.h index 61947485945d..02a7eda3f4a9 100644 --- a/sys/compat/linuxkpi/common/include/linux/refcount.h +++ b/sys/compat/linuxkpi/common/include/linux/refcount.h @@ -31,58 +31,51 @@ #include -struct refcount_linux { - atomic_t value; -}; -typedef struct refcount_linux refcount_t; +typedef atomic_t refcount_t; static inline void refcount_set(refcount_t *ref, unsigned int i) { - atomic_set(&ref->value, i); + atomic_set(ref, i); } static inline void refcount_inc(refcount_t *ref) { - atomic_inc(&ref->value); + atomic_inc(ref); } static inline bool refcount_inc_not_zero(refcount_t *ref) { - return (atomic_inc_not_zero(&ref->value)); + return (atomic_inc_not_zero(ref)); } static inline void refcount_dec(refcount_t *ref) { - atomic_dec(&ref->value); + atomic_dec(ref); } static inline unsigned int refcount_read(refcount_t *ref) { - return atomic_read(&ref->value); + return atomic_read(ref); } static inline bool refcount_dec_and_lock_irqsave(refcount_t *ref, spinlock_t *lock, unsigned long *flags) { - if (atomic_dec_and_test(&ref->value) == true) { + if (atomic_dec_and_test(ref) == true) { spin_lock_irqsave(lock, flags); return (true); } return (false); } -/* - * struct kref uses atomic_t and not refcount_t so - * we differ from Linux here. - */ static inline bool -refcount_dec_and_test(atomic_t *r) +refcount_dec_and_test(refcount_t *r) { return (atomic_dec_and_test(r));