From nobody Fri May 10 19:40:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VbfP46SgWz5KJNQ; Fri, 10 May 2024 19:40:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VbfP44z2Jz4QYk; Fri, 10 May 2024 19:40:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715370024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jxWZdQT6YbyxZcycbqPt+mXP79iED4g2/m3HTnhCAwI=; b=vnrQQTsPv+Q8SO5A7GKgGHFS/RqaOgDpuK6wlMKNqeGF553z9gouejiphR0UwhsyUmIqP3 R0I95r6Gd2YUwTPdA7qfzNiTU9PvEGEDVDtD/kCMSQhN4JVJz7nIR6GzZk9vC9CXhhVATs 7zZhzb3nzCNSJ/dOGT+vr08cvFeZqi1JWT+/0WePbakWfgcpUm8V4pKqwua8rbIFIx445o xxtii100bOpzRXOwNjD/VE/r+OpVse9bnlCj7pXC5MjguX2A8PUnZphRugklZn5fgURb/x JS8X1AanjuGOjCkq19tv15aQlMfUbCjXOBcVoJ/+fL6fD5rswDBEaXdKSD1jbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715370024; a=rsa-sha256; cv=none; b=p4gGwsBYOfyBQ0j0jmtjqQMGj9YowiRnA5TD6YajKVmqxG9l8j4Dlm0SdmwOvrBBhjY7rX dC8e3u5qSy5oKVmaxxzvTwGgjKhPSOiOyLj7rCpLP42gZ3zeDJAOjtvQi2JTkImIPxuGHn 03pp7ci7FF0o8ZHga47pWh8bWhu7KpQvbn1qgL4V8Z5/Usg8jl9U5TcPhKhfaaUBhPmSQL AIFK/ny8EO3vky8ruxRq2VsNxw1hDg0SVKjIxSmtaENqFxXyg/MXuIGNl+xpzhe7TgvZSM Q21myBbRmVRdErBBGxV/K1Ma6nnCjqQf0gP8q9gp7ya61kOF0+RRcj0F64jT7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715370024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jxWZdQT6YbyxZcycbqPt+mXP79iED4g2/m3HTnhCAwI=; b=a2uMHinbySlFwC5TZqK8AWO3FV7t251ZnqyIm8q6cvA2LGBoiFkRmEYaK3yTQl632m6HD6 /OmbFacHJ1SH8agGJ2b5Ogyq/Buy+JzWTZWfWPZTTXjvQZ5JV7rlCFeZLBHjnvhV+n3QXS NYxicKYa3s930OMnkTqKy8V5NXtYsaHL9MH0dMK1NC+1k18eCTrW4H1c9VUL2oa7YFVQbj 9jyefd9ROuPGamXlGDDkiCkhTQjnalHzA0TDm+tOO3saA1gcHTqcUofBcDzF46T+Plg863 E39ZmXXK27YSHHLKAuJY6B8mToJuk/zsqhyFg/c5gzVCcTaxfqyW8KSfzSJk/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VbfP44Lshzr3Y; Fri, 10 May 2024 19:40:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44AJeOhG021121; Fri, 10 May 2024 19:40:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44AJeOXu021118; Fri, 10 May 2024 19:40:24 GMT (envelope-from git) Date: Fri, 10 May 2024 19:40:24 GMT Message-Id: <202405101940.44AJeOXu021118@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 4e3286818327 - main - Increase IOAPIC_MAX_ID to 255 (from 254) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e3286818327453efd8e4c133928ba26a169567a Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=4e3286818327453efd8e4c133928ba26a169567a commit 4e3286818327453efd8e4c133928ba26a169567a Author: Ed Maste AuthorDate: 2024-05-10 17:40:59 +0000 Commit: Ed Maste CommitDate: 2024-05-10 19:40:18 +0000 Increase IOAPIC_MAX_ID to 255 (from 254) A test system provided by AMD panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is acceptable, so increase the limit. Reviewed by: jhb, kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45157 --- sys/x86/include/apicvar.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/x86/include/apicvar.h b/sys/x86/include/apicvar.h index 10016e291b9b..ac6a82659e34 100644 --- a/sys/x86/include/apicvar.h +++ b/sys/x86/include/apicvar.h @@ -78,7 +78,12 @@ #define MAX_APIC_ID 0x800 #define APIC_ID_ALL 0xffffffff -#define IOAPIC_MAX_ID xAPIC_MAX_APIC_ID +/* + * The 0xff ID is used for broadcast IPIs for local APICs when not using + * x2APIC. IPIs are not sent to I/O APICs so it's acceptable for an I/O APIC + * to use that ID. + */ +#define IOAPIC_MAX_ID 0xff /* I/O Interrupts are used for external devices such as ISA, PCI, etc. */ #define APIC_IO_INTS (IDT_IO_INTS + 16)