From nobody Fri May 10 16:41:44 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VbZQx40RZz5K2cb; Fri, 10 May 2024 16:41:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VbZQx0cfXz457y; Fri, 10 May 2024 16:41:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715359305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xmOEodQ9H7a0jOGVq58YUVnSQXdbv6DFcTrIAT9j2R0=; b=Lq/P6ltYZc2LuJpP5WFC+7fZkVBGlZ+VkSsnMHysT3vwUYvc2VcwAsJdcVDZAdZIj7ptlZ y1tIcVA1o18ozILRbjKIvFJ346vYpU9BFyXMHez0AKMjxysgn7fXFJtdKmEjDbtG7rq39w kNUkFw3YCrbYvXRetyxgi019D5wPDGJuN1EBA9nK8eeMN2CUXQrP+r2R26CZL2FMB4jVhP W0GR1MBlvVWff1EaLg/yhC07Is8QYPx9DN7DZD58bkbJMlfNGdtH8wMlhii9/5OyeU9ve0 T0hu+akMVNhny9v7kSW9DQAkvryFrvCX//rmsA45WDLbyVqu/D2+xy8Qe57XTg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715359305; a=rsa-sha256; cv=none; b=HFmcCtW3bJ0CejSrtkw9gJ2JSSVa54mZEzXKMsEgrziaSB4hU89/yfBIzXJBF2eMw0tyW+ /xlvrEUIvwGL1ov/9MNJiO/blQeIP8jV3wwF0oLQXQ7LJiWFoCMb8e5hKhGCcJpdXZWypw sfTfdQC6lQa8jvpfeCDMb/bjB8A/t3zYXszi9Q+YJhMt/QvCLqj0qkLuws3tWRmsuVDFrU lGPYL1gr8DABhch0ZjIZSVaxlvNMT1p8l6FDiHdKBoZNUDHuHAinOmlJT+yb22ResrkQAK 75NhgnnwMmQZ7zJ+G+zL2Ip2sYpEW7cF5FQNSedCTblJ0viDTlNJ4yfG0eCLAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715359305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xmOEodQ9H7a0jOGVq58YUVnSQXdbv6DFcTrIAT9j2R0=; b=snPjVLf/TJjmvxFhq67BCwEDJgRI1XW0dC1/y5YB3TqLQGCoIeOGIIHjREfRfuwCQH3WMP VkuULw4lbBbqfD+SWzRbkbw5TQrBP69LnjJlYfASCJM2snGePRzNZBJh6n/5AN4Och0zrZ xP2cLSkTI7UmMDGy1ywhmY0mLinm2+tqn+XS15R+aEhQX0sxoEdY4lKkQ6qNtpouFKz1a4 L8JXuXVAJ/FmPFZWYV3PJDgmnaNpOCK0R8fcY/IjR053lcaX7G9qd7g61EYGh2mItxy0cu G5LlxeM7cXPEvLQlEFjPBQbkm3ks+JCO/PXtaQQmDBEhi7Rra2FyaFpQe3fTGg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VbZQx04bczlQN; Fri, 10 May 2024 16:41:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44AGfiAi019059; Fri, 10 May 2024 16:41:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44AGfiRQ019043; Fri, 10 May 2024 16:41:44 GMT (envelope-from git) Date: Fri, 10 May 2024 16:41:44 GMT Message-Id: <202405101641.44AGfiRQ019043@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 50884a0b09a8 - main - nvmf_transport: Remove invalid assertion List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 50884a0b09a8e02f08d1083efc9722e49b49c71b Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=50884a0b09a8e02f08d1083efc9722e49b49c71b commit 50884a0b09a8e02f08d1083efc9722e49b49c71b Author: John Baldwin AuthorDate: 2024-05-10 16:12:03 +0000 Commit: John Baldwin CommitDate: 2024-05-10 16:13:40 +0000 nvmf_transport: Remove invalid assertion This is leftover from an earlier iteration of the code where 'nt' was not dynamically allocated but was the passed in 'ops' pointer so was always alive. Reported by: Coverity Scan CID: 1545042 Sponsored by: Chelsio Communications --- sys/dev/nvmf/nvmf_transport.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/nvmf/nvmf_transport.c b/sys/dev/nvmf/nvmf_transport.c index 14d526192270..ea4aee8cc7ae 100644 --- a/sys/dev/nvmf/nvmf_transport.c +++ b/sys/dev/nvmf/nvmf_transport.c @@ -292,8 +292,6 @@ nvmf_transport_module_handler(struct module *mod, int what, void *arg) prev = nt; } if (nt == NULL) { - KASSERT(nt->nt_active_qpairs == 0, - ("unregistered transport has connections")); sx_xunlock(&nvmf_transports_lock); return (0); }