From nobody Tue May 07 15:26:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VYhw334YLz5J3PR; Tue, 07 May 2024 15:26:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VYhw32Gfwz4Kgv; Tue, 7 May 2024 15:26:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715095619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=flJpnd8O1yOBP3FzikiMFIki2HYoUT/WazEpzbVO1Do=; b=q7M6K0zLBYXcfCB8ph6cwG1vUw2xXfAmOlImX4Qv7Z+V/Lx+JA7yc2ZjZD2w4DBAcwEhge aTiRoiyNRcAeSsAxnT/MIxlr8jhLRKfy62/ID5rHAg4zKbmEuZKM1Ff+WbSzgzwAirD3aV cweAdOvysaWn/ArrGrMnWgxxnIyuvUUpdPbd5sIW9ZSHPrg57W1DtJhLg0idAidqGeUQLl x8dBDj7UHztb6ZbjyLsRc5XizPNcZ6yJKoT3DSjq5wUR0LulbW/IVBTs53kXzGd5eMXCvF OtTJHVbi0NuBWJVusQH2e1L0cN1VRuMDz3Js6Fko1q0OXfg+kevAz1kvmiFyYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715095619; a=rsa-sha256; cv=none; b=adLL/inopKYvMWjqIJ1QKjAvgze73yts5Ti+cGdgbiLTfaARbxukVKpYBnoiwUkBWCbik/ PBLj34Y2QO7mnfLj6ZMJH9XwXPMWEroLXdf6eJzc/H8NWem2B1v0NATNGZjj1EPgoFE+Ly cTH+vpc7Q020jiXhp0k51MZREAY0kNKhllVHFbIh7gIAJxdFooeDnaqHW56GyfGGH95mrp /d5I1FkbDZ2a8B2mgWMmvT24+WrxsrhpGHyUqZtqztOu85XpPh8XRLbbWsy/UUhxptq5wQ y0Hpag9szby8p1W+alKZDlTdO1ZLYFHwc7KSREGdm3B02Oy4T71HhImu7DdUJQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715095619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=flJpnd8O1yOBP3FzikiMFIki2HYoUT/WazEpzbVO1Do=; b=uL69oJ+ARiedJM1rlxZZ9d1KQZsxgXAfrnhp9Mb82PsKJrsDZPvT2xlw4V8BTLejyNWJHg sxxr/Z7lmHijja34YXXdmxYDS8D0OCaKhxKRsEfztnGCN6MjxGRwqoFaZvmP00xqKAetrN eYzCAq/bTNwfInhsfjWNHkS4U6R8xQYW15rcW23RGqMKWn4P+qKeSZxp8oHIj9z2eq2IT7 yIpA7M5GScZE/qn0jwnHgFkeuo6xfjIBB7mAdsv/IGPC9gpTnQBJVyhJaDSSqn84L0uteX aUkbVMQUHuwf7C3rJ09vz1PJLmlreWcPZNA0EI2SuO4+Sr8tR8fAbTl6eb4Kpw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VYhw31SqYzlwh; Tue, 7 May 2024 15:26:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 447FQxEQ081473; Tue, 7 May 2024 15:26:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 447FQxjo081470; Tue, 7 May 2024 15:26:59 GMT (envelope-from git) Date: Tue, 7 May 2024 15:26:59 GMT Message-Id: <202405071526.447FQxjo081470@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Marko Zec Subject: git: 7a5de1d4cc6a - main - fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zec X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7a5de1d4cc6af84456cef03323f041652e84326b Auto-Submitted: auto-generated The branch main has been updated by zec: URL: https://cgit.FreeBSD.org/src/commit/?id=7a5de1d4cc6af84456cef03323f041652e84326b commit 7a5de1d4cc6af84456cef03323f041652e84326b Author: Marko Zec AuthorDate: 2024-05-07 15:22:00 +0000 Commit: Marko Zec CommitDate: 2024-05-07 15:22:00 +0000 fib_dxr: KASSERTs for chasing NULL ptr and runaway refcount suspects MFC after: 1 week --- sys/netinet/in_fib_dxr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/netinet/in_fib_dxr.c b/sys/netinet/in_fib_dxr.c index 3b2dc837d50b..5c5311068169 100644 --- a/sys/netinet/in_fib_dxr.c +++ b/sys/netinet/in_fib_dxr.c @@ -1280,6 +1280,9 @@ dxr_change_rib_batch(struct rib_head *rnh, struct fib_change_queue *q, da = dxr->aux; KASSERT(da != NULL, ("%s: NULL dxr->aux", __FUNCTION__)); + KASSERT(da->fd != NULL, ("%s: da->fd %p", __FUNCTION__, da->fd)); + KASSERT(da->refcnt > 0, ("%s: da->refcnt %d", __FUNCTION__, + da->refcnt)); FIB_PRINTF(LOG_INFO, da->fd, "processing %d update(s)", q->count); for (ui = 0; ui < q->count; ui++) {