From nobody Mon Mar 25 14:37:54 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V3FsW05S7z5F43Q for ; Mon, 25 Mar 2024 14:38:07 +0000 (UTC) (envelope-from mp@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V3FsV6ZDxz4K1J for ; Mon, 25 Mar 2024 14:38:06 +0000 (UTC) (envelope-from mp@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711377486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ut7GaqycjGSfOrj82kCEFZqvLci38qTgA4ft9m40OVA=; b=flgO/xb4HZIMgRH8cdZzFeJ4SW6CBvoLRnMrRMa+otzVeFPm2ziA0jHVUINHZS5OVx/UwN dLIGaAux6ApLHpMxg2JKFjBsJg7ReTOZYy8/2oHsgbakT1BIqLkOnY8fHLLpzFyp0mpPad xLvTnErmrq/fAXBHLDO8KFZ4HWyufO/F8YoBjACsm5LjQZYI05EN8VpN8JwVf9hrQV7Em1 16DDTS5hKuZprlDg8TAzipQsyPAF65ux7jksbjIGjLL0a2nye4rOC21/b4r/8bXLM3cr0G qHmqXnWi4jpsXsDUApp1wgz4sjvoVedIDaRo2keD/UCneNbF0mt3j/n6lD59aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711377486; a=rsa-sha256; cv=none; b=q05AgMrCgB7KBOMT7TcSkrlcrX1/vZeLN7X3dzq2hb0cZEW6DKVOWpP7gpEdUfffoVXwIT /vgDJJFj0WdgKolO7Fm7we+EzVDsrNOseAdK8yElyz9ahHm4+sauGFbWzGMGEtAED/60dm TWMxTvvZgTl62Z2qJB/FDj9q5NCNIQZ3O42iyTU3jJZT0V7dZSM0/osEYiCkM2lv9EXeFq sgO1lkvEPHoWAXOGbs4MGumFtoOJtv94c/AVD1J2OD9OcT1J1Af8TSQNFBEkHjwmOZB4wz bq9wdGzP6qQvJPmIwDw3JhtB83SW0lZr19bGzWhe5K8yOyDBqJAKm1UW2vDYFw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711377486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ut7GaqycjGSfOrj82kCEFZqvLci38qTgA4ft9m40OVA=; b=nvw75l799nQMZJybsT6SVwt8K3KJl5ee1oNZL2XRtWmbQwrjlzAhHff9hnCQOfCQ2dji2h lIEFQUeBLiObLSQCSkBxBo2zsGHDNOX7JVAh9n8viDlH+cQkkGj9/EteIrXePP++guEFn8 9qUoiXIWEHndgoMEq37ERnUKz5taOzEr55E+53BlVqRU7NsPfGnJMOf+IWa/D61Hy+Zqf2 kXrI0iXLmOdCaOovVpy74qMWL/L7kdUhqNnNVhTAXpPhHzPXyxp2V0Yedvg3xYCDpr4bF4 PJm5jAmVOs1kH7ZBR5mqoKlgIJawuaMarXCZTvKgbVc7Kaux9mZCdyCMsXb4cQ== Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: mp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V3FsV62pyzVKR for ; Mon, 25 Mar 2024 14:38:06 +0000 (UTC) (envelope-from mp@freebsd.org) Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-dcc4de7d901so3651076276.0 for ; Mon, 25 Mar 2024 07:38:06 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCW7aZ4V8wdDgk9EYhKnZR/mSKbzn5X/2XHiV9VK4B0gdFoKPftfEb8fV8pFkbO9DFq5r+zHQcewbFmTgccn9549L8m0i+zotiKv/TaMQO5xYQ== X-Gm-Message-State: AOJu0YzL+8H9japlqm9im6FTbwNrOhZbXwLZ9zTfYDGegNvb5KpV7ToY lR2uGZQ2G/C4RgS2mn60i9QotcblnuOFim6Cu55jzUQr6puv+OsECFMT4rz6AfyUDy97e9FpprF KpCzsBzhl4eYmoOHH1obHxzZHm9sUEEupJEImng== X-Google-Smtp-Source: AGHT+IEow38ZcQENt/QsxK/I1oUESao/wZa/thKnJFgJ21GCJxwaFCnKed5E9hSfeFBI0pr5Abd0gdsdMNjieTD9bgA= X-Received: by 2002:a25:ab0e:0:b0:dc6:de64:f74 with SMTP id u14-20020a25ab0e000000b00dc6de640f74mr5532604ybi.9.1711377486008; Mon, 25 Mar 2024 07:38:06 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202403241939.42OJdn3w018764@gitrepo.freebsd.org> <20240325100136.2a052359@ernst.home> In-Reply-To: <20240325100136.2a052359@ernst.home> From: Mark Peek Date: Mon, 25 Mar 2024 07:37:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 65904399db91 - main - efibootmgr: allow -u as a valid option To: garyj@gmx.de Cc: Mark Peek , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000217ac006147d1f01" --000000000000217ac006147d1f01 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 25, 2024 at 2:01=E2=80=AFAM Gary Jennejohn wrote= : > On Sun, 24 Mar 2024 19:39:49 GMT > Mark Peek wrote: > > > The branch main has been updated by mp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D65904399db9167b0970e42e14642e1d= 6bdbf6d3a > > > > commit 65904399db9167b0970e42e14642e1d6bdbf6d3a > > Author: Mark Peek > > AuthorDate: 2024-03-24 19:37:12 +0000 > > Commit: Mark Peek > > CommitDate: 2024-03-24 19:37:12 +0000 > > > > efibootmgr: allow -u as a valid option > > > > PR: 277907 > > Reported by: vsasjason@gmail.com > > MFC after: 1 week > > --- > > usr.sbin/efibootmgr/efibootmgr.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/usr.sbin/efibootmgr/efibootmgr.c > b/usr.sbin/efibootmgr/efibootmgr.c > > index 2bc79ee26f51..b919130d9c11 100644 > > --- a/usr.sbin/efibootmgr/efibootmgr.c > > +++ b/usr.sbin/efibootmgr/efibootmgr.c > > @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[]) > > int ch; > > const char *arg; > > > > - while ((ch =3D getopt_long(argc, argv, > "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:v", > > - lopts, NULL)) !=3D -1) { > > + while ((ch =3D getopt_long(argc, argv, > > + "AaBb:C:cdDe:EFfhk:L:l:NnOo:pTt:u:v", lopts, NULL)) !=3D -1) = { > > switch (ch) { > > case 'A': > > opts.set_inactive =3D true; > > > > -u is not documented in the man page for efibootmgr, although it was > already in the source. > > -- > Gary Jennejohn > Gary, I'm not sure I understand your comment. The man page was updated for -u in this commit: https://github.com/freebsd/freebsd-src/commit/9a7915299484a767fbffc7234b8dc= 45c29954cca And man shows this as: efibootmgr -u unix-path ... -u --efidev unix-path Displays the UEFI device path of unix-path. Mark --000000000000217ac006147d1f01 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Mar 25, 2024 at 2:01=E2=80=AFAM G= ary Jennejohn <garyj@gmx.de> wrot= e:
On Sun, 24 Mar 2024 19:39:49 GMT
Mark Peek <mp@FreeBSD.org> wrote:

> The branch main has been updated by mp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D65904399db9167b0970e42e14642e1d6bdbf6d3a<= /a>
>
> commit 65904399db9167b0970e42e14642e1d6bdbf6d3a
> Author:=C2=A0 =C2=A0 =C2=A0Mark Peek <mp@FreeBSD.org>
> AuthorDate: 2024-03-24 19:37:12 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Mark Peek <mp@FreeBSD.org>
> CommitDate: 2024-03-24 19:37:12 +0000
>
>=C2=A0 =C2=A0 =C2=A0efibootmgr: allow -u as a valid option
>
>=C2=A0 =C2=A0 =C2=A0PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= 277907
>=C2=A0 =C2=A0 =C2=A0Reported by:=C2=A0 =C2=A0 vsasjason@gmail.com
>=C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
> ---
>=C2=A0 usr.sbin/efibootmgr/efibootmgr.c | 4 ++--
>=C2=A0 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usr.sbin/efibootmgr/efibootmgr.c b/usr.sbin/efibootmgr/ef= ibootmgr.c
> index 2bc79ee26f51..b919130d9c11 100644
> --- a/usr.sbin/efibootmgr/efibootmgr.c
> +++ b/usr.sbin/efibootmgr/efibootmgr.c
> @@ -204,8 +204,8 @@ parse_args(int argc, char *argv[])
>=C2=A0 =C2=A0 =C2=A0 =C2=A0int ch;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0const char *arg;
>
> -=C2=A0 =C2=A0 =C2=A0while ((ch =3D getopt_long(argc, argv, "AaBb= :C:cdDe:EFfhk:L:l:NnOo:pTt:v",
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lopts, = NULL)) !=3D -1) {
> +=C2=A0 =C2=A0 =C2=A0while ((ch =3D getopt_long(argc, argv,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"AaBb:C:cdDe:EFfhk:L:l:NnOo:pT= t:u:v", lopts, NULL)) !=3D -1) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0switch (ch) { >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0case 'A'= :
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0opts.set_inactive =3D true;
>

-u is not documented in the man page for efibootmgr, although it was
already in the source.

--
Gary Jennejohn

Gary,
I'm = not sure I understand your comment. The man page was updated for -u in this= commit:
=C2=A0 =C2=A0 =C2=A0efiboo= tmgr -u unix-path
=C2=A0 =C2=A0 = =C2=A0...
=C2=A0 =C2=A0 =C2=A0-u = --efidev unix-path
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Displ= ays the UEFI device path of unix-path.

= Mark
--000000000000217ac006147d1f01--