From nobody Wed Mar 13 20:35:54 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tw2Mt4sGfz5DchL; Wed, 13 Mar 2024 20:35:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tw2Mt2f3Xz4hHd; Wed, 13 Mar 2024 20:35:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710362154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5OAUkMU6wzA6oiEDlMW/uy8rDtc6MMmpwUT7fFS/i3Y=; b=mK1EuQGr5/qQfFrJenTf5M/JaoQoHC6kSoY/a6gTNYxLzqc3iJAoBvi72mqcK8pLJPhPk+ 6pI+jV3EtV8I7Oc4jDo5GwyVTwGDjeAIBxEE/hLsGFC9KaTrxqQKkgc0b1gUjJlnxpBUnV M8uyAnpLe/AZM0etZ1F8cTgeX3Nv7eyIo4TjW8UAxezJ4BuJni/Qg9Ep7tSHrwb0OicteH 9E8m/Pwf88cUU8njqUvc32hU/YkpI8F4kWap8+MKRIXuaTCPnWoCCTUWh3rjjW0r4clH2R pWUr2nGDix7avjXX0Sl+u2KPtCpbd/wtz2xzed+e8ILXY8ewjF5q+4Mzf6sm0g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710362154; a=rsa-sha256; cv=none; b=sD16jHhUU5rOAjV3KntkPye/6LBN9fwAMgZwjIJbC306tlXWxW20eaQMFzrixQBooSgsMf nI74mrVGn+FD3fyUynYIQXNBmWI7v9CACPhRSbc1kbMr0Gk+t28aFUstzKohvC50igkLFh btakKSUjW7EXXHscqsJyqbOrTUE0IWKVILUgy9/+DrqW38JilIAMc9EROKk1ffV2hinDno Il6M21xDz54jOnpD2Fz6/gpygbynue446Abcluq1yeV5Ub8abkeVbU4UptIi8nIV3atBM8 GZwq0iNOFoUGrVCFcv6J8j2E98IZ8DQNzL/SULvPkcIALKbxcbwA6FWBbyZ8gw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710362154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5OAUkMU6wzA6oiEDlMW/uy8rDtc6MMmpwUT7fFS/i3Y=; b=rNrOQusydLT0wHrbiA0wB104X+6RQHFqwpTqGc15lHXd36Apa+Vc9IxZ8ptBcZO8wVudCB C4llpDwP7fCN1oP0EsZUdDTdWf2Kd6aO72uChfxPDcTKT9dsDxnkv/sIXVAsVxu+fjjUrn VuQ0BWZjU4d6ozkcHMQM5+O0zkgdHASX3fweH6qL+tKw9F0AtFs+4zcZxsEQZebHh1/YoH o5HczX7LjSP6kzDKoKmwpDj0MJH4jmLSsSwYztVWegKPX+TJhJIKINtf8JSdHkO1OMn5PH 4NMliJQmtcL+ZAoVpuGIiQ9b9zrCPDommHdPB+yqDuwcqUCunlD64hIyvYY3IA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tw2Mt2FWvzy5Q; Wed, 13 Mar 2024 20:35:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 42DKZsAL005586; Wed, 13 Mar 2024 20:35:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 42DKZs7Y005583; Wed, 13 Mar 2024 20:35:54 GMT (envelope-from git) Date: Wed, 13 Mar 2024 20:35:54 GMT Message-Id: <202403132035.42DKZs7Y005583@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: bf8a3a816d4b - main - libc/softfloat: we don't export _fp[gs]et* symbols List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: bf8a3a816d4b3ca79d78c437b60bb4d169e590ad Auto-Submitted: auto-generated The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=bf8a3a816d4b3ca79d78c437b60bb4d169e590ad commit bf8a3a816d4b3ca79d78c437b60bb4d169e590ad Author: Brooks Davis AuthorDate: 2024-03-13 20:34:46 +0000 Commit: Brooks Davis CommitDate: 2024-03-13 20:35:41 +0000 libc/softfloat: we don't export _fp[gs]et* symbols Remove attempts to use NetBSD __weak_alias macros to export _-prefixed versions of various fp[sg]et* symbols under softfloat. __weak_alias isn't defined so we didn't export them and thus the Symbol.map entries were wrong. Reviewed by: jhibbits Differential Revision: https://reviews.freebsd.org/D44327 --- lib/libc/arm/gen/fpgetmask_vfp.c | 4 ---- lib/libc/arm/gen/fpgetsticky_vfp.c | 4 ---- lib/libc/powerpc/Symbol.map | 1 - lib/libc/powerpc/gen/fpgetsticky.c | 4 ---- lib/libc/powerpc64/gen/fpgetsticky.c | 4 ---- lib/libc/powerpcspe/gen/fpgetsticky.c | 4 ---- lib/libc/softfloat/Symbol.map | 6 ------ lib/libc/softfloat/fpgetmask.c | 5 ----- lib/libc/softfloat/fpgetsticky.c | 5 ----- 9 files changed, 37 deletions(-) diff --git a/lib/libc/arm/gen/fpgetmask_vfp.c b/lib/libc/arm/gen/fpgetmask_vfp.c index a4ed8d1afbec..5e73a274dafa 100644 --- a/lib/libc/arm/gen/fpgetmask_vfp.c +++ b/lib/libc/arm/gen/fpgetmask_vfp.c @@ -28,10 +28,6 @@ #include #include -#ifdef __weak_alias -__weak_alias(fpgetmask,_fpgetmask) -#endif - #define FP_X_MASK (FP_X_INV | FP_X_DZ | FP_X_OFL | FP_X_UFL | FP_X_IMP) fp_except_t diff --git a/lib/libc/arm/gen/fpgetsticky_vfp.c b/lib/libc/arm/gen/fpgetsticky_vfp.c index 7d278c3ad849..651610dddf83 100644 --- a/lib/libc/arm/gen/fpgetsticky_vfp.c +++ b/lib/libc/arm/gen/fpgetsticky_vfp.c @@ -28,10 +28,6 @@ #include #include -#ifdef __weak_alias -__weak_alias(fpgetsticky,_fpgetsticky) -#endif - #define FP_X_MASK (FP_X_INV | FP_X_DZ | FP_X_OFL | FP_X_UFL | FP_X_IMP) fp_except diff --git a/lib/libc/powerpc/Symbol.map b/lib/libc/powerpc/Symbol.map index f836a08ae0d4..ccf74c1748e4 100644 --- a/lib/libc/powerpc/Symbol.map +++ b/lib/libc/powerpc/Symbol.map @@ -20,7 +20,6 @@ FBSD_1.3 { }; FBSDprivate_1.0 { - _fpgetsticky; __longjmp; signalcontext; __signalcontext; diff --git a/lib/libc/powerpc/gen/fpgetsticky.c b/lib/libc/powerpc/gen/fpgetsticky.c index d609586360fe..3512c97f8cf9 100644 --- a/lib/libc/powerpc/gen/fpgetsticky.c +++ b/lib/libc/powerpc/gen/fpgetsticky.c @@ -38,10 +38,6 @@ #include #ifndef _SOFT_FLOAT -#ifdef __weak_alias -__weak_alias(fpgetsticky,_fpgetsticky) -#endif - fp_except_t fpgetsticky() { diff --git a/lib/libc/powerpc64/gen/fpgetsticky.c b/lib/libc/powerpc64/gen/fpgetsticky.c index d609586360fe..3512c97f8cf9 100644 --- a/lib/libc/powerpc64/gen/fpgetsticky.c +++ b/lib/libc/powerpc64/gen/fpgetsticky.c @@ -38,10 +38,6 @@ #include #ifndef _SOFT_FLOAT -#ifdef __weak_alias -__weak_alias(fpgetsticky,_fpgetsticky) -#endif - fp_except_t fpgetsticky() { diff --git a/lib/libc/powerpcspe/gen/fpgetsticky.c b/lib/libc/powerpcspe/gen/fpgetsticky.c index 58bdc43cef38..a97c27296cab 100644 --- a/lib/libc/powerpcspe/gen/fpgetsticky.c +++ b/lib/libc/powerpcspe/gen/fpgetsticky.c @@ -37,10 +37,6 @@ #include #ifndef _SOFT_FLOAT -#ifdef __weak_alias -__weak_alias(fpgetsticky,_fpgetsticky) -#endif - fp_except_t fpgetsticky() { diff --git a/lib/libc/softfloat/Symbol.map b/lib/libc/softfloat/Symbol.map index 9c5229a18066..d412eb417765 100644 --- a/lib/libc/softfloat/Symbol.map +++ b/lib/libc/softfloat/Symbol.map @@ -1,15 +1,9 @@ FBSD_1.0 { - _fpgetmask; fpgetmask; - _fpgetround; fpgetround; - _fpgetsticky; fpgetsticky; - _fpsetmask; fpsetmask; - _fpsetround; fpsetround; - _fpsetsticky; fpsetsticky; }; diff --git a/lib/libc/softfloat/fpgetmask.c b/lib/libc/softfloat/fpgetmask.c index c417e163d770..86cf89020668 100644 --- a/lib/libc/softfloat/fpgetmask.c +++ b/lib/libc/softfloat/fpgetmask.c @@ -40,13 +40,8 @@ #include "milieu.h" #include "softfloat.h" -#ifdef __weak_alias -__weak_alias(fpgetmask,_fpgetmask) -#endif - fp_except fpgetmask(void) { - return float_exception_mask; } diff --git a/lib/libc/softfloat/fpgetsticky.c b/lib/libc/softfloat/fpgetsticky.c index 2d31d9149a21..f42c348784e1 100644 --- a/lib/libc/softfloat/fpgetsticky.c +++ b/lib/libc/softfloat/fpgetsticky.c @@ -40,13 +40,8 @@ #include "milieu.h" #include "softfloat.h" -#ifdef __weak_alias -__weak_alias(fpgetsticky,_fpgetsticky) -#endif - fp_except fpgetsticky(void) { - return float_exception_flags; }