From nobody Thu Jun 20 13:53:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W4hlY61K2z5Nqjh; Thu, 20 Jun 2024 13:53:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W4hlY2Pwgz4Ylq; Thu, 20 Jun 2024 13:53:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id KCPfskp0n2Ui5KIDwszpNK; Thu, 20 Jun 2024 13:53:12 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id KIDusOrwK9Cr4KIDvs5Dpy; Thu, 20 Jun 2024 13:53:12 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=etl8zZpX c=1 sm=1 tr=0 ts=66743448 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=T1WGqf2p2xoA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=g5aYd172q1L5E24Bq10A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A352B9EB; Thu, 20 Jun 2024 06:53:10 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A000A9C; Thu, 20 Jun 2024 06:53:10 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Baptiste Daroussin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0667538b888c - main - ee: fix wprintw usage (highlighted by ncurses 6.5) In-reply-to: <202406201344.45KDiqtm042956@gitrepo.freebsd.org> References: <202406201344.45KDiqtm042956@gitrepo.freebsd.org> Comments: In-reply-to Baptiste Daroussin message dated "Thu, 20 Jun 2024 13:44:52 +0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Thu, 20 Jun 2024 06:53:10 -0700 Message-Id: <20240620135310.A000A9C@slippy.cwsent.com> X-CMAE-Envelope: MS4xfPFT5c7t586GsU5oTDsFyxVh0rTUV3LczXpJZGTBLjqoabnV8xrxAd1Seln0ucWd5m792m7YgLoKyG2XnXJFwAsIX6xFxs/hHiYGVngIywvXOfx5Oaa6 04GqnxFHqmQzSgFoNBvAhUc39XgT9BiPqbsff3whYAYVLSkbWIyMpVgimJnyYaxCTp6r+BDSZv9iSm8+NWkmZbtCi9EiOzx6fgbwESxWgrhXvAo3hzVMcIl1 0+t8YqBiaXSXKP3jUE9OUtarG9KWl+NmgSHrSJfN0BTF+59xoop/GGlduIgo+SHyNkRyVc5sRqSgp890TtFy7fxCps4akb/MHKwBJZRGxU0= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4W4hlY2Pwgz4Ylq In message <202406201344.45KDiqtm042956@gitrepo.freebsd.org>, Baptiste Daroussi n writes: > The branch main has been updated by bapt: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0667538b888c1171932c6cf28b62fc19 > d393e119 > > commit 0667538b888c1171932c6cf28b62fc19d393e119 > Author: Baptiste Daroussin > AuthorDate: 2024-06-20 13:42:59 +0000 > Commit: Baptiste Daroussin > CommitDate: 2024-06-20 13:43:44 +0000 > > ee: fix wprintw usage (highlighted by ncurses 6.5) > > Reported by: cy > --- > contrib/ee/ee.c | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > diff --git a/contrib/ee/ee.c b/contrib/ee/ee.c > index 5576537f3fad..a14f9c0ead13 100644 > --- a/contrib/ee/ee.c > +++ b/contrib/ee/ee.c > @@ -591,11 +591,11 @@ main(int argc, char *argv[]) > { > wmove(com_win, 0, 0); > werase(com_win); > - wprintw(com_win, ree_no_file_msg); > + wprintw(com_win, "%s", ree_no_file_msg); > wrefresh(com_win); > edit_abort(0); > } > - wprintw(com_win, no_file_string); > + wprintw(com_win, "%s", no_file_string); > wrefresh(com_win); > } > else > @@ -615,7 +615,7 @@ main(int argc, char *argv[]) > if (!nohighlight) > wstandout(info_win); > wmove(info_win, 5, 0); > - wprintw(info_win, separator); > + wprintw(info_win, "%s", separator); > wmove(info_win, 5, 5); > wprintw(info_win, "line %d col %d lines from top %d ", > curr_line->line_number, scr_horz, absolute_li > n); > @@ -1668,7 +1668,7 @@ command_prompt(void) > if (result == 0) > wprintw(com_win, unkn_cmd_str, cmd_str); > else > - wprintw(com_win, non_unique_cmd_msg); > + wprintw(com_win, "%s", non_unique_cmd_msg); > > wrefresh(com_win); > > @@ -1744,7 +1744,7 @@ command(char *cmd_str1) > wmove(com_win, 0, 0); > wclrtoeol(com_win); > if (in_file_name == NULL) > - wprintw(com_win, no_file_string); > + wprintw(com_win, "%s", no_file_string); > else > wprintw(com_win, current_file_str, in_file_name); > } > @@ -2245,7 +2245,7 @@ get_file(char *file_name) > { > if ((errno == ENOTDIR) || (errno == EACCES) || (errno = > = EROFS) || (errno == ETXTBSY) || (errno == EFAULT)) > { > - wprintw(com_win, read_only_msg); > + wprintw(com_win, "%s", read_only_msg); > ro_flag = TRUE; > } > } > @@ -2282,7 +2282,7 @@ get_file(char *file_name) > wclrtoeol(com_win); > wprintw(com_win, file_read_lines_msg, in_file_name, curr_line-> > line_number); > if (ro_flag) > - wprintw(com_win, read_only_msg); > + wprintw(com_win, "%s", read_only_msg); > wrefresh(com_win); > } > else if (can_read) /* not input_file and file is non-zero size */ > @@ -2400,7 +2400,7 @@ finish(void) > if ((file_name == NULL) || (*file_name == '\0')) > { > wmove(com_win, 0, 0); > - wprintw(com_win, file_not_saved_msg); > + wprintw(com_win, "%s", file_not_saved_msg); > wclrtoeol(com_win); > wrefresh(com_win); > clear_com_win = TRUE; > @@ -2577,7 +2577,7 @@ search(int display_message) > { > wmove(com_win, 0, 0); > wclrtoeol(com_win); > - wprintw(com_win, searching_msg); > + wprintw(com_win, "%s", searching_msg); > wrefresh(com_win); > clear_com_win = TRUE; > } > @@ -3378,7 +3378,7 @@ menu_op(struct menu_entries menu_list[]) > { > wmove(com_win, 0, 0); > werase(com_win); > - wprintw(com_win, menu_too_lrg_msg); > + wprintw(com_win, "%s", menu_too_lrg_msg); > wrefresh(com_win); > clear_com_win = TRUE; > return(0); > @@ -3630,10 +3630,10 @@ paint_menu(struct menu_entries menu_list[], int max_w > idth, int max_height, > { > if (list_size > 1) > wprintw(menu_win, "%c) ", item_alpha[min((count > er - 1), max_alpha_char)]); > - wprintw(menu_win, menu_list[counter].item_string); > + wprintw(menu_win, "%s", menu_list[counter].item_string) > ; > } > else > - wprintw(menu_win, more_below_str); > + wprintw(menu_win, "%s", more_below_str); > } > else > { > @@ -3663,7 +3663,7 @@ help(void) > wrefresh(help_win); > werase(com_win); > wmove(com_win, 0, 0); > - wprintw(com_win, press_any_key_msg); > + wprintw(com_win, "%s", press_any_key_msg); > wrefresh(com_win); > counter = wgetch(com_win); > if (counter == -1) > @@ -3790,7 +3790,7 @@ file_op(int arg) > if ((string == NULL) || (*string == '\0')) > { > wmove(com_win, 0, 0); > - wprintw(com_win, file_not_saved_msg); > + wprintw(com_win, "%s", file_not_saved_msg); > wclrtoeol(com_win); > wrefresh(com_win); > clear_com_win = TRUE; > @@ -3925,7 +3925,7 @@ Format(void) > > wmove(com_win, 0, 0); > wclrtoeol(com_win); > - wprintw(com_win, formatting_msg); > + wprintw(com_win, "%s", formatting_msg); > wrefresh(com_win); > > /* > @@ -3971,7 +3971,7 @@ Format(void) > > wmove(com_win, 0, 0); > wclrtoeol(com_win); > - wprintw(com_win, formatting_msg); > + wprintw(com_win, "%s", formatting_msg); > wrefresh(com_win); > > /* > @@ -4046,7 +4046,7 @@ Format(void) > > wmove(com_win, 0, 0); > wclrtoeol(com_win); > - wprintw(com_win, formatting_msg); > + wprintw(com_win, "%s", formatting_msg); > wrefresh(com_win); > > /* > @@ -4270,7 +4270,7 @@ dump_ee_conf(void) > > if (option == 0) > { > - wprintw(com_win, conf_not_saved_msg); > + wprintw(com_win, "%s", conf_not_saved_msg); > wrefresh(com_win); > return; > } > @@ -4293,7 +4293,7 @@ dump_ee_conf(void) > init_file = fopen(file_name, "w"); > if (init_file == NULL) > { > - wprintw(com_win, conf_dump_err_msg); > + wprintw(com_win, "%s", conf_dump_err_msg); > wrefresh(com_win); > return; > } > @@ -4412,7 +4412,7 @@ spell_op(void) > command(shell_echo_msg); > adv_line(); > wmove(com_win, 0, 0); > - wprintw(com_win, spell_in_prog_msg); > + wprintw(com_win, "%s", spell_in_prog_msg); > wrefresh(com_win); > command("<>!spell"); /* send contents of buffer to command 'spell' > and read the results back into the editor */ > @@ -5001,7 +5001,7 @@ restrict_mode(void) > return(FALSE); > > wmove(com_win, 0, 0); > - wprintw(com_win, restricted_msg); > + wprintw(com_win, "%s", restricted_msg); > wclrtoeol(com_win); > wrefresh(com_win); > clear_com_win = TRUE; > I wonder if the editors/aee port might also want some tender loving care? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0