From nobody Wed Jun 19 06:43:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W3vG64dTHz5P48r; Wed, 19 Jun 2024 06:43:26 +0000 (UTC) (envelope-from lexi@le-fay.org) Received: from fuchsia.eden.le-Fay.ORG (fuchsia.eden.le-fay.org [81.187.47.195]) by mx1.freebsd.org (Postfix) with ESMTP id 4W3vG60DSWz3yj5; Wed, 19 Jun 2024 06:43:26 +0000 (UTC) (envelope-from lexi@le-fay.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=le-fay.org header.s=fuchsia header.b=l0dqClrp; dmarc=none; spf=pass (mx1.freebsd.org: domain of lexi@le-fay.org designates 81.187.47.195 as permitted sender) smtp.mailfrom=lexi@le-fay.org Received: from iris.eden.le-Fay.ORG (iris.eden.le-fay.org [IPv6:fd12:8247:3:1::7]) by fuchsia.eden.le-Fay.ORG (Postfix) with ESMTP id 34BA4200F7; Wed, 19 Jun 2024 06:43:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=le-fay.org; s=fuchsia; t=1718779405; bh=HueTPg5D/p4lEFMHVbpyfNhllx7RQA2mN5nEcXj9nVg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=l0dqClrpv5Mz2m+lfR2YQdOeuZxC0MKJN/H7e8ReYIcw4FqgnqjC0xtrQyFaDNwTR z73ns+kyE6Gv37BF4ZFMabtnIJx/8pD7rSO+e7QTleACslKI454vx1aFucZBpbkFgl 5MwY9aCkH/hEa+icxumzj5QCMO7huA5FGeNRR7/c= Received: from ilythia.eden.le-fay.org (ilythia.eden.le-fay.org [IPv6:2001:8b0:aab5:c003:3::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by iris.eden.le-Fay.ORG (Postfix) with ESMTPSA id 205622C046F; Wed, 19 Jun 2024 07:43:23 +0100 (BST) Date: Wed, 19 Jun 2024 07:43:24 +0100 From: Lexi Winter To: "Bjoern A. Zeeb" Cc: Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 50ecbc5142e1 - main - libipsec: make const-correct Message-ID: Mail-Followup-To: "Bjoern A. Zeeb" , Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202404230452.43N4qhYd063681@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bedbMt6zlDZY/qNY" Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.50 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.995]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip4:81.187.47.195:c]; R_DKIM_ALLOW(-0.20)[le-fay.org:s=fuchsia]; RCVD_NO_TLS_LAST(0.10)[]; ASN(0.00)[asn:20712, ipnet:81.187.0.0/16, country:GB]; DWL_DNSWL_NONE(0.00)[le-fay.org:dkim]; MISSING_XM_UA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[le-fay.org]; DKIM_TRACE(0.00)[le-fay.org:+] X-Rspamd-Queue-Id: 4W3vG60DSWz3yj5 --bedbMt6zlDZY/qNY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Bjoern A. Zeeb: > > commit 50ecbc5142e1c58f2132b351da19c5e4aa5f4e6a > > Author: Lexi Winter > > AuthorDate: 2024-04-22 21:56:24 +0000 > > Commit: Warner Losh > > CommitDate: 2024-04-23 04:36:34 +0000 > >=20 > > libipsec: make const-correct >=20 > I am surprised that this did not break ipsec-tools and/or other ports > for conflicting types for ipsec_set_policy(), ipsec_get_policylen() and > ipsec_dump_policy(). it did, actually. maybe this should be reverted, although the current situation is also bad since the non-const-correct prototypes cause issues in client code. in the specific case of ipsec-tools i feel like a better fix might be to update ipsec-tools to work with the new prototypes; it does seem to have support for this (using __ipsec_const), that just isn't enabled on FreeBSD and i didn't understand the automake logic enough to determine why. --bedbMt6zlDZY/qNY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCAAdFiEEuwt6MaPcv/+Mo+ftDHqbqZ41x5kFAmZyfgwACgkQDHqbqZ41 x5m7rQv+JVEAd3UN+GVdDtgQ3xiBjguu1Hxlbva0SL+vNsqlj0xOpIwRr3UEcrx8 aodY8Vf8dMGsH87Defv+qaqTwCqOTtbNuY6LUoXUgREccHreJTLNiCe2p4Gveloa Gsy6YqPmLHdpsc1g2TbyqgRRmUbUeyXd6N6fEHXLzWMyGQ6T+x+tIvo9qt1Y2nHJ dOZAT0Lzja0htcdg3Q/rrQnHP5+YtLfwARULht65N1C+ttDE1bDI2e1eyV1El3F3 cHUlfrh+tZpJRqOGM1NeNklc83nO6kgPlonW5XwRgyZz0ePkKkI8oso9N0HoM1BI 0ESY6uOqx6HB8ikGRAHWZiX3GNNFpgTALK2YjkTsOO2rOEL/s1hrfM8pwvf+SCml IMxPX+HKSdfQhJ0npapPxg/FHMl8JOhkhhxM+zrdMRihuNVTWNHlxqUKI21VUo3n Z4Kssuz5SBUpApI48heXElIj0fmEJ9zm8YZmxM3xspGMuOn+rqqeThmwiJ88NBG/ wrk29H2e =aNWt -----END PGP SIGNATURE----- --bedbMt6zlDZY/qNY--