From nobody Tue Jun 18 06:09:08 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W3GY06rVVz5NNrM; Tue, 18 Jun 2024 06:09:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W3GY06J4dz4fY6; Tue, 18 Jun 2024 06:09:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718690948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v1uUHwn+00McEVMvJVejIe7c34Fm11eexhOvYDcNIbE=; b=OfM0FOZgtXx4v94NrM8DH1no9iXKxbtv1iQCn6hwf8Mx11xVxmwmn+qDZPL7xa4vcI1MeX yd2og9aB8RYZZJtsZfvPPYOtXZ5Z9Gka6y73WGwNzILMLiq97JcbyWCbIUmiirAwv/Qil8 lzsrKYQ8s+ZDZyDCF7RuEt4nUL0Tdk1BVvK+jQdny3JShbhi/Y7Mjsrn5aD2C3NJjvWEWb AY65AxyibhvcHBmvQG4/2OKXkfoByceo8f0ltb1HoCuUTU790fCS3NFMibJ3StQ8PFa9VF jY+gUwlpnqeM+835HzoAoOTU0S6CwhCDO49XyJxECHz5JFrGawcB0JGAuNKdXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718690948; a=rsa-sha256; cv=none; b=ZZuxvh3AKUh0oQ2M/aCmF9s57FJeIsKaL8ay0Hsh2Bnk5JyjptleOuo/TY4bUuUyGb1hiT aIsb12DtY33lByK2HqyTxHluyNahPEQQBcSPWiAxQSj64ZNPuNiHOaJaGGFROfp/vGFAy0 sN3rWVRAHMLr3tH4OjzExsgKLcTJnqJOER8D1bU0jkp4mHcNRss+pE8hWZ9vWI5X4PDt2g iANOrwQxoVHk3TtoKmpaSHRfC8zBhrK1v+sgBlRn2LS/rOA5TyQrOTGM2uwpxX3nZhaB2U WhhTOBUo8opGlzXYJCLzYJq8Yh8N/CpIWznPwC5CB1ZmkxkC5WBSlXXmHXNAtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718690948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=v1uUHwn+00McEVMvJVejIe7c34Fm11eexhOvYDcNIbE=; b=awpAwsyPigJdWsTYJ9oJklT9CNZZQeCK0txsMlwo+o4jKBIc4MzSEzu/KU2pcdkkk3w71J UDSirNUp8/UdZwc97FEMsNXnuFwF1+oTLlUlQJ7kYOmeQnDv4mE5ul5ANW1jKdkVf4HXDS cqcpoD1AuOVwWKDnYhDagCotN8mBgf62BWCSW4K4yENCx7+lH+QbX7x40RMSNxALG3L3A8 jePp6J5LPVHL7IuAcDarlPj1utAMzLERyFSHEFN45Hwni85+FfLdwL33vfKl9hQj2SrTPt BYsQhevZ2TU5Aesy+PpUgzgjDVAwdXVOfxkcG0AiMGydTS/5HIwEbif0Ftc9aA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W3GY05nbSznKm; Tue, 18 Jun 2024 06:09:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 45I6983E089951; Tue, 18 Jun 2024 06:09:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 45I698Wr089948; Tue, 18 Jun 2024 06:09:08 GMT (envelope-from git) Date: Tue, 18 Jun 2024 06:09:08 GMT Message-Id: <202406180609.45I698Wr089948@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Xin LI Subject: git: b81cbb12410b - main - gve: Make gve_free_qpls idempotent List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b81cbb12410b000074483899e61e9e767ba3ec1d Auto-Submitted: auto-generated The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=b81cbb12410b000074483899e61e9e767ba3ec1d commit b81cbb12410b000074483899e61e9e767ba3ec1d Author: Shailend Chand AuthorDate: 2024-06-05 05:31:46 +0000 Commit: Xin LI CommitDate: 2024-06-18 06:08:31 +0000 gve: Make gve_free_qpls idempotent This fixes a panic caused by double free. PR: kern/279410 MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D45489 --- sys/dev/gve/gve_qpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/gve/gve_qpl.c b/sys/dev/gve/gve_qpl.c index 3c6d9af6feee..9a946a2a2f2d 100644 --- a/sys/dev/gve/gve_qpl.c +++ b/sys/dev/gve/gve_qpl.c @@ -182,6 +182,7 @@ gve_free_qpls(struct gve_priv *priv) for (i = 0; i < num_qpls; i++) gve_free_qpl(priv, i); free(priv->qpls, M_GVE_QPL); + priv->qpls = NULL; } }