From nobody Thu Jun 06 17:22:35 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VwB3b2qltz5NKNb; Thu, 06 Jun 2024 17:22:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VwB3b2KPwz4Lym; Thu, 6 Jun 2024 17:22:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717694555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=asRPVbxfLGu1I0sgbFji4fPXdFqXIljMSGc48UBvaNs=; b=p5CPAWfdKX/3dsJ9kUoklT4EVe3yao679eQRmrOlZBXzLcJWEqRXiZ/VF4yAJsI5l8XABK SMD/iZSmmgWGeVydrlEGNcyEM53U3X7LO+ygUBsCU/Y1yUVCDk3HbIiqO3fjXkG8LggLKe KM/wcuCQGD+11Rt3BYPgyjYVokw9qf+rtfLQjv4UsLPGNv4M+Ymg7n8qjVyfPWEFO3/udJ ftGLkLaxyA7Fb/NocsE+MiO9cdGsliTSERmRv7bVz0SVzUXGIQP5MzhNfJzg5XCcEwM6Fd Hz3toc5jRRDAttucQmGXXtLxsBQ7KkgH+yOuex5ewcRyiLUsE3Dj/s2duG8ptg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717694555; a=rsa-sha256; cv=none; b=hmHiCMZTh1xfgbDwk+VHPon/5ptlOHJy25pwqTSmJW3x5o36tetDm/ixh8ToStzTMyjvth l+EjOm/GxICQu1M5WW2gDYRNCfwLuy7VUmjPo7DwxJSWidU/0sGBTknpXLmow7qbVodIGs /Nl1WlvXx0Hdd4PClieZ3abQCuq3nsw1fI0EalbOweAzxDvoIuPgQ8irG56YJbUeVZsvxO x6nlV8kHeXEzdLYQT8/zWA2Omz0+6voNFZRA0issZ2LpBL99gqBp5dMG0HR/nUhj42NnX0 ysDKj79nR2xQr//XdrbyHXiZ4l6AI1nMm7cKLJdcquVX+OgFkgoYPqCumm30Aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717694555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=asRPVbxfLGu1I0sgbFji4fPXdFqXIljMSGc48UBvaNs=; b=ZNa8fgl3WAK2SvyMU2xGETJSb5Hy201mPhSjTFcaG9ZxEsmquJpqW1wUP6RTEMtNQ7ubVi V9s3FXJP9D6ld2pFY0hX6m7BhJoXMUKmeK2xBxj54P/ByyReHrbyo/qxk5fCATsKAlwN7c I7iyUEEUK4+/l/ISByoxLVVFoz/+6rXvEqXVWgISbvvdjI3ZYWNFEHGK3k8wUeOFJOb5f0 pK/daAj4bnYBRJOpFco1ZDTOvgk7lcDNatmQAPjYdsmR6AHfaqMwq6tl3F9vQK9CDUTNnW d9WfXi6vSR/z7CU/fllpl4MOGGBeFsVc7R3PLWHSCydnKGcEW0QDLcYpHYI3Vg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VwB3b1wZGzvv1; Thu, 6 Jun 2024 17:22:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 456HMZFU006816; Thu, 6 Jun 2024 17:22:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 456HMZe6006813; Thu, 6 Jun 2024 17:22:35 GMT (envelope-from git) Date: Thu, 6 Jun 2024 17:22:35 GMT Message-Id: <202406061722.456HMZe6006813@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: 60107d23d8f2 - main - ctladm.8: fix several errors in the "port" section List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 60107d23d8f2c05f418c024000a31a6148d2f7de Auto-Submitted: auto-generated The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=60107d23d8f2c05f418c024000a31a6148d2f7de commit 60107d23d8f2c05f418c024000a31a6148d2f7de Author: Alan Somers AuthorDate: 2024-06-05 20:13:04 +0000 Commit: Alan Somers CommitDate: 2024-06-06 17:22:06 +0000 ctladm.8: fix several errors in the "port" section * Document the "-d" option. * Add the "-c" and "-r" options to the summary. * Correct the list of required options. * Clarify that the "-t" option is only for use with "-o", "-w", and "-W" * Replace references to the nonexistent "-n" with "-p". Also, fix a few related error strings in the ctladm command. MFC after: 2 weeks Sponsored by: Axcient Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D45503 --- usr.sbin/ctladm/ctladm.8 | 32 ++++++++++++++++++++++++++++---- usr.sbin/ctladm/ctladm.c | 7 ++++--- 2 files changed, 32 insertions(+), 7 deletions(-) diff --git a/usr.sbin/ctladm/ctladm.8 b/usr.sbin/ctladm/ctladm.8 index 2c90e12ef924..b3af4b45ba26 100644 --- a/usr.sbin/ctladm/ctladm.8 +++ b/usr.sbin/ctladm/ctladm.8 @@ -35,7 +35,7 @@ .\" .\" $Id: //depot/users/kenm/FreeBSD-test2/usr.sbin/ctladm/ctladm.8#3 $ .\" -.Dd May 2, 2024 +.Dd June 5, 2024 .Dt CTLADM 8 .Os .Sh NAME @@ -162,6 +162,7 @@ .Nm .Ic port .Op Fl c +.Op Fl d Ar driver .Op Fl o Ar on|off .Op Fl w Ar wwpn .Op Fl W Ar wwnn @@ -598,6 +599,10 @@ The serial number is returned when the error is injected. Perform one of several CTL frontend port operations. Either get a list of frontend ports .Pq Fl l , +create a new frontend port +.Pq Fl c , +destroy a frontend port +.Pq Fl r , turn one or more frontends on or off .Pq Fl o Ar on|off , @@ -607,6 +612,8 @@ or World Wide Port Name .Pq Fl W Ar wwpn for a given port. One of +.Fl c , +.Fl r , .Fl l , .Fl o , or @@ -619,6 +626,18 @@ combined with enabling/disabling or listing ports. .Bl -tag -width 12n .It Fl c Create new frontend port using free pp and vp=0. +.It Fl d Ar driver +Specify the name of the frontend driver used by the +.Pq Fl c +or +.Pq Fl r +subcommands. +Valid driver names include +.Dq ioctl , +.Dq iscsi , +and +.Dq nvmf , +but more can be added by external kernel modules. .It Fl o Ar on|off Turn the specified CTL frontend ports on or off. If no port number or port type is specified, all ports are turned on or @@ -633,7 +652,12 @@ The port numbers can be found in the frontend port list. Remove port specified with .Pq Fl p Ar targ_port . .It Fl t Ar fe_type -Specify the frontend type. +Specify the frontend type used by the +.Pq Fl o , +.Pq Fl w , +and +.Pq Fl W +subcommands. Currently defined port types are .Dq fc (Fibre Channel), @@ -647,7 +671,7 @@ and .It Fl w Ar wwnn Set the World Wide Node Name for the given port. The -.Fl n +.Fl p argument must be specified, since this is only possible to implement on a single port. As a general rule, the WWNN should be the same across all ports on the @@ -655,7 +679,7 @@ system. .It Fl W Ar wwpn Set the World Wide Port Name for the given port. The -.Fl n +.Fl p argument must be specified, since this is only possible to implement on a single port. As a general rule, the WWPN must be different for every port in the system. diff --git a/usr.sbin/ctladm/ctladm.c b/usr.sbin/ctladm/ctladm.c index 688281238fb0..28f9a39386d3 100644 --- a/usr.sbin/ctladm/ctladm.c +++ b/usr.sbin/ctladm/ctladm.c @@ -546,7 +546,7 @@ cctl_port(int fd, int argc, char **argv, char *combinedopt) * we'll throw an error, since that only works on one port at a time. */ if ((port_type != CTL_PORT_NONE) && (targ_port != -1)) { - warnx("%s: can only specify one of -t or -n", __func__); + warnx("%s: can only specify one of -t or -p", __func__); retval = 1; goto bailout; } else if ((targ_port == -1) && (port_type == CTL_PORT_NONE)) @@ -630,7 +630,7 @@ cctl_port(int fd, int argc, char **argv, char *combinedopt) } case CCTL_PORT_MODE_SET: if (targ_port == -1) { - warnx("%s: -w and -W require -n", __func__); + warnx("%s: -w and -W require -p", __func__); retval = 1; goto bailout; } @@ -679,7 +679,8 @@ bailout: return (retval); bailout_badarg: - warnx("%s: only one of -l, -o or -w/-W may be specified", __func__); + warnx("%s: only one of -c, -r, -l, -o or -w/-W may be specified", + __func__); return (1); }