From nobody Wed Jun 05 05:16:38 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VvG0V0CFxz5Lcjv; Wed, 05 Jun 2024 05:16:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VvG0T53T3z54ND; Wed, 5 Jun 2024 05:16:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id ERH0sVEkj2Ui5Ej0qsNE4D; Wed, 05 Jun 2024 05:16:40 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id Ej0psvg5rByQrEj0qs239C; Wed, 05 Jun 2024 05:16:40 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=UOF+Hzfy c=1 sm=1 tr=0 ts=665ff4b8 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=T1WGqf2p2xoA:10 a=VxmjJ2MpAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=V4iLK-Bie_EAfCy7YhQA:9 a=CjuIK1q_8ugA:10 a=SwEc6Cqz2_MA:10 a=7gXAzLPJhVmCkEl4_tsf:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id F2F3F20E; Tue, 04 Jun 2024 22:16:38 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A862E117; Tue, 04 Jun 2024 22:16:38 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Cy Schubert cc: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 871b33ad65ba - main - pci: Consistently use pci_vf_* for suballocated VF memory resources In-reply-to: <20240605034733.42321112@slippy.cwsent.com> References: <202406042352.454NqFVj061328@gitrepo.freebsd.org> <20240605034733.42321112@slippy.cwsent.com> Comments: In-reply-to Cy Schubert message dated "Tue, 04 Jun 2024 20:47:33 -0700." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 04 Jun 2024 22:16:38 -0700 Message-Id: <20240605051638.A862E117@slippy.cwsent.com> X-CMAE-Envelope: MS4xfBKFqlAgTjdNXpu6gpWqh14LRUAfCJWgAxf5R1i7tdz3XWdIyxf7koryk9h9Mjb05ITYSrrAvhgEKXvIwUcLa9vIpjlOs58w2h8ByumotllR1CpvsJj5 bbb9alKP0ML2L1mzMCkKy2fOlvK1HTTxffVQmd6hDVYDLkzWPOlHW4a7fiTP8w4/Sn/aY3xEEaXyEb3Phrc72lsvN8rQ2K6/xc0UW0gqd/NP4ybXfe6cflFJ iQq8qsEcDkzfk6WQgayj0nscURGbLsazmNKUsaybNEtUwJ5J/U451S26z8NeJtIxwlBrZ8Rx35Y1p+emPbEtJuvCp6bn90q1PVOGpj0idUA= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4VvG0T53T3z54ND In message <20240605034733.42321112@slippy.cwsent.com>, Cy Schubert writes: > In message <202406042352.454NqFVj061328@gitrepo.freebsd.org>, John Baldwin wr > it > es: > > The branch main has been updated by jhb: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=871b33ad65baf07c92cce120a4fc19 > 78 > > c2ed7b3b > > > > commit 871b33ad65baf07c92cce120a4fc1978c2ed7b3b > > Author: John Baldwin > > AuthorDate: 2024-06-04 23:51:37 +0000 > > Commit: John Baldwin > > CommitDate: 2024-06-04 23:51:37 +0000 > > > > pci: Consistently use pci_vf_* for suballocated VF memory resources > > > > Some of the bus resource methods were passing these up to the parent > > which triggered rman mismatch assertions in INVARIANTS kernels. > > > > Reported by: kp > > Reviewed by: imp > > Tested by: kp (earlier version) > > Differential Revision: https://reviews.freebsd.org/D45406 > > --- > > sys/dev/pci/pci.c | 118 ++++++++++++++++++++++++++++++++++-- > > sys/dev/pci/pci_iov.c | 151 ++++++++++++++++++++++++++++++++++++++++++ > ++ > > ++ [...] > atapci0: port 0x1f0-0x1f7,0x3f6,0x17 > 0-0x177,0x376,0xfc00-0xfc0f at device 4.0 on pci0 > ata0: at channel 0 on atapci0 > > > Fatal trap 12: page fault while in kernel mode > cpuid = 2; apic id = 02 > fault virtual address = 0x54 > fault code = supervisor read data, page not present > instruction pointer = 0x20:0xffffffff804a76e2 > stack pointer = 0x28:0xffffffff81f0b6d0 > frame pointer = 0x28:0xffffffff81f0b700 > code segment = base 0x0, limit 0xfffff, type 0x1b > = DPL 0, pres 1, long 1, def32 0, gran 1 > processor eflags = interrupt enabled, resume, IOPL = 0 > current process = 0 (swapper) > rdi: fffff80004bf9000 rsi: fffff80004bf9000 rdx: fffff80004c2de00 > rcx: fffff80004a99000 r8: fffff80004c2c020 r9: fffffe000ec57540 > rax: 0000000000000000 rbx: fffff80004bf9000 rbp: ffffffff81f0b700 > r10: fffff80004bc2000 r11: ffffffff81f0b9fc r12: 0000000000000001 > r13: 0000000000000000 r14: fffff80004bf8600 r15: fffff80004c2de00 > trap number = 12 > panic: page fault > cpuid = 2 > time = 1 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffffff81f0b3c > 0 > vpanic() at vpanic+0x13f/frame 0xffffffff81f0b4f0 > panic() at panic+0x43/frame 0xffffffff81f0b550 > trap_fatal() at trap_fatal+0x40b/frame 0xffffffff81f0b5b0 > trap_pfault() at trap_pfault+0x46/frame 0xffffffff81f0b600 > calltrap() at calltrap+0x8/frame 0xffffffff81f0b600 > --- trap 0xc, rip = 0xffffffff804a76e2, rsp = 0xffffffff81f0b6d0, rbp = 0xfff > fffff81f0b700 --- > pci_activate_resource() at pci_activate_resource+0x22/frame 0xffffffff81f0b70 > 0 > bus_generic_rman_alloc_resource() at bus_generic_rman_alloc_resource+0xee/fra > me 0xffffffff81f0b740 > nexus_alloc_resource() at nexus_alloc_resource+0x99/frame 0xffffffff81f0b7a0 > acpi_alloc_resource() at acpi_alloc_resource+0x84/frame 0xffffffff81f0b860 [...] Removing PCI-IOV from the kernel config also works around this. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0