From nobody Tue Jul 30 14:00:04 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WYH1G5PkPz5S1rJ for ; Tue, 30 Jul 2024 14:00:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WYH1G3Wfpz4sKy for ; Tue, 30 Jul 2024 14:00:18 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42803bbf842so35261325e9.1 for ; Tue, 30 Jul 2024 07:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722348016; x=1722952816; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4CoTbLuFtoy8nnLvGrczbig3PEtsRB7OQ/dqT9/iLKQ=; b=H0A5lo/QXUDWBuYCmZdvk/on+hv1pDlyFIJJH08I5MY8chj+tfD2N9SOgMoL6Lu9PP +6MnZ5ndaKM6uDbP4tyR5fJyvuYDYhUDSBWm/ENajcV8vb24NKzNSKUApfCVl6djwLYt vKQgNrNYGI2eTDfh0wcpDHDl2Xcoxp1bVvMk0G9dupZdF6fGjxrnq7qXxVkKaGg8xUUg wunKW6wPTogZx3VtXJe4v1G09xHhNE+T4Sy+sIsYPcwPInp7b6MmvmJp0Yh+Z0wjmy4s Ncq5JZ64E2zoyyrOU+IgCxq+UFTWoefetoSCUXLlDzx1LxQk24XqrnzitxCl4ky+jR1G Z7zA== X-Forwarded-Encrypted: i=1; AJvYcCXZ0R4HECME8eJV4pCw7xu8oBamxsI0Pv52ERzLTd66qf8J8nG1yl/qS45Yzmcu4Sg1A3HwoDqp384wmaOeJGlRZhbelO6GlKLJhRYSQu76/A== X-Gm-Message-State: AOJu0YyNLJVS2HjHibI1jFmArD8t5ZJMSZgJYGhW9o7dkvj7hOcPkGh6 3oCmTmkOaopxAXhCWRBZhx489yYRIP5dw3a9jRDIRmCyO36IsB7ed2A/i0Dt08Q= X-Google-Smtp-Source: AGHT+IFP7OF9vJVSZP0S26azPSdGoErKGfA7zYLkZBy7c46OjfqCkYzEhFxm64I/xIKbDJ0sxcxFeg== X-Received: by 2002:a05:600c:4311:b0:428:111a:193 with SMTP id 5b1f17b1804b1-42811e0b9a7mr74960965e9.37.1722348016330; Tue, 30 Jul 2024 07:00:16 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428068cda0csm210329825e9.47.2024.07.30.07.00.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2024 07:00:15 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 From: Jessica Clarke In-Reply-To: Date: Tue, 30 Jul 2024 15:00:04 +0100 Cc: Warner Losh , Mark Johnston , Yuri Pankov , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> To: John Baldwin X-Mailer: Apple Mail (2.3774.600.62) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WYH1G3Wfpz4sKy On 30 Jul 2024, at 14:52, John Baldwin wrote: >=20 > On 7/29/24 15:18, Warner Losh wrote: >> Hey John, >> On Mon, Jul 29, 2024 at 11:55=E2=80=AFAM John Baldwin = wrote: >>> On 7/29/24 13:40, Warner Losh wrote: >>>> On Mon, Jul 29, 2024 at 10:39=E2=80=AFAM Mark Johnston = >>> wrote: >>>>=20 >>>>> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: >>>>>> Mark Johnston wrote: >>>>>>> The branch main has been updated by markj: >>>>>>>=20 >>>>>>> URL: >>>>>=20 >>> = https://cgit.FreeBSD.org/src/commit/?id=3D801c452795ac441523655eb3277051b7= b034becf >>>>>>>=20 >>>>>>> commit 801c452795ac441523655eb3277051b7b034becf >>>>>>> Author: Mark Johnston >>>>>>> AuthorDate: 2024-07-29 14:12:40 +0000 >>>>>>> Commit: Mark Johnston >>>>>>> CommitDate: 2024-07-29 14:17:04 +0000 >>>>>>>=20 >>>>>>> man9: Really complete the removal of MD5.9 >>>>>>>=20 >>>>>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now = inaccurate >>>>> kernel side manual page.") >>>>>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 = manual >>> page >>>>> from section 9.") >>>>>>> --- >>>>>>> ObsoleteFiles.inc | 2 ++ >>>>>>> share/man/man9/Makefile | 2 -- >>>>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>>>=20 >>>>>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >>>>>>> index b21778466800..01b4824e8692 100644 >>>>>>> --- a/ObsoleteFiles.inc >>>>>>> +++ b/ObsoleteFiles.inc >>>>>>> @@ -56,6 +56,8 @@ = OLD_FILES+=3Dusr/share/man/man9/ifaddr_byindex.9.gz >>>>>>>=20 >>>>>>> # 20240729: remove MD5(9) >>>>>>> OLD_FILES+=3Dusr/share/man/man9/MD5.9.gz >>>>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Init.9 >>>>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Transform.9 >>>>>>=20 >>>>>> This really needs to be smarter, but you have to specify .gz = suffix for >>>>>> man entries as we have compression enabled by default. >>>>>=20 >>>>> Sigh, who knew it was so difficult to remove a man page. >>>>>=20 >>>>=20 >>>> There is a pull request being worked on that will be smarter about = what's >>>> removed since we have compress (UFS) and uncompress (ZFS) setups >>>> now. >>>=20 >>> Does it just add an OLD_MAN helper variable to use instead of = OLD_FILES >>> and then try the various extension combinations for each OLD_MAN? >>>=20 >> https://github.com/freebsd/freebsd-src/pull/1295 >> was submitted a bit ago. the repetition is why I've not committed it. = Is an >> approach >> like that good, or should we move all the old man pages to OLD_MAN? >=20 > This is solving a different problem. This is dealing with removing = duplicate > copies e.g. when switching from WITH_MANCOMPRESS=3Dyes to = WITHOUT_MANCOMPRESS=3Dyes. >=20 > OLD_MAN would be orthogonal. It would be similar to how we use extra = logic > for OLD_LIBS where we look for debug symbols in /usr/lib/debug to = remove along > with the library. For OLD_MAN we would try to remove both $f and = $f.gz. list-old-files already has: -V "OLD_FILES:ts\n" -V "OLD_FILES:Musr/share/*.gz:R:ts\n=E2=80=9D So as long as you list the manpages with a .gz suffix it=E2=80=99ll = already handle the uncompressed version. Jess