From nobody Tue Jul 30 04:57:13 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WY2ys2w8yz5RBK5; Tue, 30 Jul 2024 04:57:25 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4WY2yr4tj4z4m3n; Tue, 30 Jul 2024 04:57:24 +0000 (UTC) (envelope-from gnn@neville-neil.com) Authentication-Results: mx1.freebsd.org; none Received: by mail.gandi.net (Postfix) with ESMTPSA id 0DB6840004; Tue, 30 Jul 2024 04:57:18 +0000 (UTC) From: George Neville-Neil To: Warner Losh Cc: John Baldwin , Mark Johnston , Yuri Pankov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 Date: Tue, 30 Jul 2024 11:57:13 +0700 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gnn@neville-neil.com X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] X-Rspamd-Queue-Id: 4WY2yr4tj4z4m3n On 30 Jul 2024, at 2:18, Warner Losh wrote: > Hey John, > > On Mon, Jul 29, 2024 at 11:55=E2=80=AFAM John Baldwin = wrote: > >> On 7/29/24 13:40, Warner Losh wrote: >>> On Mon, Jul 29, 2024 at 10:39=E2=80=AFAM Mark Johnston >> wrote: >>> >>>> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: >>>>> Mark Johnston wrote: >>>>>> The branch main has been updated by markj: >>>>>> >>>>>> URL: >>>> >> https://cgit.FreeBSD.org/src/commit/?id=3D801c452795ac441523655eb32770= 51b7b034becf >>>>>> >>>>>> commit 801c452795ac441523655eb3277051b7b034becf >>>>>> Author: Mark Johnston >>>>>> AuthorDate: 2024-07-29 14:12:40 +0000 >>>>>> Commit: Mark Johnston >>>>>> CommitDate: 2024-07-29 14:17:04 +0000 >>>>>> >>>>>> man9: Really complete the removal of MD5.9 >>>>>> >>>>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate >>>> kernel side manual page.") >>>>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual= >> page >>>> from section 9.") >>>>>> --- >>>>>> ObsoleteFiles.inc | 2 ++ >>>>>> share/man/man9/Makefile | 2 -- >>>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc >>>>>> index b21778466800..01b4824e8692 100644 >>>>>> --- a/ObsoleteFiles.inc >>>>>> +++ b/ObsoleteFiles.inc >>>>>> @@ -56,6 +56,8 @@ OLD_FILES+=3Dusr/share/man/man9/ifaddr_byindex.9= =2Egz >>>>>> >>>>>> # 20240729: remove MD5(9) >>>>>> OLD_FILES+=3Dusr/share/man/man9/MD5.9.gz >>>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Init.9 >>>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Transform.9 >>>>> >>>>> This really needs to be smarter, but you have to specify .gz suffix= for >>>>> man entries as we have compression enabled by default. >>>> >>>> Sigh, who knew it was so difficult to remove a man page. >>>> >>> >>> There is a pull request being worked on that will be smarter about wh= at's >>> removed since we have compress (UFS) and uncompress (ZFS) setups >>> now. >> >> Does it just add an OLD_MAN helper variable to use instead of OLD_FILE= S >> and then try the various extension combinations for each OLD_MAN? >> > > https://github.com/freebsd/freebsd-src/pull/1295 > > was submitted a bit ago. the repetition is why I've not committed it. I= s an > approach > like that good, or should we move all the old man pages to OLD_MAN? > As the person who screwed this up I think OLD_MAN would be super helpful.= Also as an OLD MAN I find this hilarious. Best, George