From nobody Mon Jul 29 20:18:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXqRc36Rtz5Rvc1; Mon, 29 Jul 2024 20:18:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXqRb6DnCz4gnh; Mon, 29 Jul 2024 20:18:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722284283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nJuV2nTlpyNDA397mIqHMAvoNaCgOlBm9+RrDWNA99Q=; b=hLbom74FW2KWrm6hQFoNGZqI+5uwVuqNvCCgxDn8lPnAH+Yau9gzw69wivMGk3c47g/4kZ yfejmGPV2/FHIC8jrer8HrzrfyDPbk8IWLNg9/ZsHY3LV0ojr/h8+7Cf6T5Hg7EnMMS4CM F6/XchZdk2kJOHrGEHtUSacxYKXmV1LIGqTQxRBTmj9SegPCzTKPgj0O69YYMDKZWHKC6S rKPCYV8b4plTCIsJnwTk5nmL+QkaOM8PX2z2INK6Ua5peXqtRBauOCaabzbHZZ9GfQxYXN h4i0QwSLM6wt2G7GayXGxY9UFEHTlWMAsrBnMF6Lx5Cjzs0uW9+X8QN7ZSeNWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722284283; a=rsa-sha256; cv=none; b=Kp/+oINE6px6r1rTyijtOkLbwQbsgyquZcD/naWvNFTJHiw8gCZN9LGFY6M0iF/O5Toeg1 I5SUAE2dCLdqvQ5PwNsMV87ZTk81NX652sum6vK7KS4t/sw2R2G2Irr9eg269RPwupBUVn N8dckZiuwOfCPlHTuyJL2DsVNgNu63Zoh/hIwoxB8dM553Sqlm4+ISeeEXPpHMJwwO2WYW LMTHSO0fC5eEjFuics+uiD+UcjW/OohLIrbs+edfVppYttm6K+u0aTuZSs+0B4XdsPNngc jpgc0pWt+OAmb0iyX/liAdI8+DN1QQYQ83ADXq+tZGAbBB9AhBEkd4oDZ79+fA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722284283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=nJuV2nTlpyNDA397mIqHMAvoNaCgOlBm9+RrDWNA99Q=; b=Xwrn1MEopmmQtah7H9J/5c8ZaZfEE9Xpi6QbZeqxwqsIzVfrhJ3mSSZPySiJvLTeJ9++9Q DK335htMFu+ZL0u1OVZLMmQKJUPsQhRGp6CnY49KinV6d66oHyOjz68Jg1FUCUDmf/wjzX SvvcPWD5gTx/m6kNr5DNW8e+PpGmHWtfP/S1ty9O3zhnkKjqYfxSRMiFK3Eo1CeFoEHwGs 4Sp9kTykOU5s1aZgaf2d8okwgXlrYafyhuu9l6eDjFdEBTOQURrNM9eCSMXAwOjd4YfAdD 7oRHefzSITLPay4I72o+BiSEykK5WkphIYv3bhwIs1LqDWcDSlETcVU3kEqcUw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WXqRb5pQnzp9b; Mon, 29 Jul 2024 20:18:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 46TKI3FP079143; Mon, 29 Jul 2024 20:18:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 46TKI3cW079140; Mon, 29 Jul 2024 20:18:03 GMT (envelope-from git) Date: Mon, 29 Jul 2024 20:18:03 GMT Message-Id: <202407292018.46TKI3cW079140@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 5f659bb0b63d - main - test(1): quote closing bracket in error message List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5f659bb0b63d0d0068645d70e1c39f7a26fafd63 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=5f659bb0b63d0d0068645d70e1c39f7a26fafd63 commit 5f659bb0b63d0d0068645d70e1c39f7a26fafd63 Author: Daniel Tameling AuthorDate: 2024-07-24 11:56:16 +0000 Commit: Warner Losh CommitDate: 2024-07-29 20:08:33 +0000 test(1): quote closing bracket in error message If test is called as [ and one forgets to close the bracket, the error message is currently [: missing ] To make it obvious that this is not something printed in brackets, quote the closing bracket in the message, which is what everybody else is doing: [: missing ']' Reviewed by: imp Pull Request: https://github.com/freebsd/freebsd-src/pull/1346 --- bin/test/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/test/test.c b/bin/test/test.c index af2783f0aee9..a35c5b424d3f 100644 --- a/bin/test/test.c +++ b/bin/test/test.c @@ -198,7 +198,7 @@ main(int argc, char **argv) p++; if (strcmp(p, "[") == 0) { if (strcmp(argv[--argc], "]") != 0) - error("missing ]"); + error("missing ']'"); argv[argc] = NULL; }