From nobody Mon Jul 29 19:18:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WXp7Q66bJz5Rp9d for ; Mon, 29 Jul 2024 19:18:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WXp7Q1nDrz4ZJZ for ; Mon, 29 Jul 2024 19:18:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2cf213128a1so2142302a91.2 for ; Mon, 29 Jul 2024 12:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1722280736; x=1722885536; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EivefK6cYbUK2GZOS47nur5ppQuoAdnWo4bEg4OCG6c=; b=HkPk7uWNnXnsy31rPkh8ufi8FY5r84pBtIPI0T83IINL8IvASn02l7d7/pvY95kKQK FLh0zAIn19zq9faPqz+/dY9/fYYm0molifC+UMkCYkAMbf7VHzHqnA3P4/nQDySnxp3o SFhCm0YcoLrVrxVtzET2ZabAx85hR3+57jUSAMHE1rkAVTaqL5PMXHedh3Y9Iint+40e yH1qWrj8yB5he+obmvyWhyJ2cTnTeICAON0il9BEtZ6SWNEp5MEuY5b/NJAZqdulIC0f 90ERpu13EzCeqU1zaKqAuX2XeqY7tO7XHXs4f6JgX55SRkQ/pGgVBhVCAxqP8maLfwkz E11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722280736; x=1722885536; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EivefK6cYbUK2GZOS47nur5ppQuoAdnWo4bEg4OCG6c=; b=Kd2LjUricpjKwUL9Sw72177AK6goNfV+bvWeSnRgTw9FWk/XKSKaP5B0B2cxhz5oJf CGcZBXIbWOonOrIqSO/hBa4PmPL4Damtuu+Z4XBPLUWosBmrzjkeq0EsOuWyks0ibzP6 Aedc+8vjsB0UP62WkO9gwunktpofk0M7ceipbQGcnhftPM43QKIj8KlbaCnhwcH4zbiV tz068rOFNs0TcznJcF1E1QCFuJwDfZWKYS5mP2Esx8cZ6yFvX4X2P/YpiBtuBy4JV2zV 6aK+WuDKIxklIs5qiIqfOUha/1UkqoTmuAEONiMwT52+NNQFygzMNBoAk0DLsxSjbF0b UEqA== X-Forwarded-Encrypted: i=1; AJvYcCVLkWCERvkZPuSk6tgQUMINXCEReE+vVwRTPl83eUkf3eHeG795HK151DnFpSIrnbv+Y41ygkZEWUNOeZiooNv+9fpuS1CCx0KIH5401LNMqg== X-Gm-Message-State: AOJu0Yx2e5t2czE+peSCmJExqhDV4EHPiGEmXgtLg8UBEq49TfK3M5K7 D9O2IJv2bYt2GapaHPK4c7TAvXAjwinPNY3clCDUZRxZMGzHXz2LUb36tPV7lvMzInNPMiem9k6 esPdfDZx0LCGJ96OraiH1OZm6q3Z9QrfbKL4Ptg== X-Google-Smtp-Source: AGHT+IGjDQ4feQc5Tbkoh5IQhs8FqmRkUDQIvVnj6a4//ISI2XBoNTn4kghZNx/RCfQ0HCtxGrE2n8iZni6kbGJntN0= X-Received: by 2002:a17:90a:9281:b0:2cb:51e4:3ed3 with SMTP id 98e67ed59e1d1-2cf7e1c84a1mr6961586a91.18.1722280736341; Mon, 29 Jul 2024 12:18:56 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202407291431.46TEVQow094080@gitrepo.freebsd.org> <63334eb1-7af6-439a-89a0-ba379428c5a6@aetern.org> In-Reply-To: From: Warner Losh Date: Mon, 29 Jul 2024 13:18:45 -0600 Message-ID: Subject: Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9 To: John Baldwin Cc: Mark Johnston , Yuri Pankov , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007e5a29061e67bba0" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WXp7Q1nDrz4ZJZ --0000000000007e5a29061e67bba0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hey John, On Mon, Jul 29, 2024 at 11:55=E2=80=AFAM John Baldwin wro= te: > On 7/29/24 13:40, Warner Losh wrote: > > On Mon, Jul 29, 2024 at 10:39=E2=80=AFAM Mark Johnston > wrote: > > > >> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote: > >>> Mark Johnston wrote: > >>>> The branch main has been updated by markj: > >>>> > >>>> URL: > >> > https://cgit.FreeBSD.org/src/commit/?id=3D801c452795ac441523655eb3277051b= 7b034becf > >>>> > >>>> commit 801c452795ac441523655eb3277051b7b034becf > >>>> Author: Mark Johnston > >>>> AuthorDate: 2024-07-29 14:12:40 +0000 > >>>> Commit: Mark Johnston > >>>> CommitDate: 2024-07-29 14:17:04 +0000 > >>>> > >>>> man9: Really complete the removal of MD5.9 > >>>> > >>>> Fixes: 46b0db2dbe9f ("Remove unnecessary and now inaccurate > >> kernel side manual page.") > >>>> Fixes: 36d68cb2ddd2 ("Complete the removal of the MD5 manual > page > >> from section 9.") > >>>> --- > >>>> ObsoleteFiles.inc | 2 ++ > >>>> share/man/man9/Makefile | 2 -- > >>>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc > >>>> index b21778466800..01b4824e8692 100644 > >>>> --- a/ObsoleteFiles.inc > >>>> +++ b/ObsoleteFiles.inc > >>>> @@ -56,6 +56,8 @@ OLD_FILES+=3Dusr/share/man/man9/ifaddr_byindex.9.g= z > >>>> > >>>> # 20240729: remove MD5(9) > >>>> OLD_FILES+=3Dusr/share/man/man9/MD5.9.gz > >>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Init.9 > >>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Transform.9 > >>> > >>> This really needs to be smarter, but you have to specify .gz suffix f= or > >>> man entries as we have compression enabled by default. > >> > >> Sigh, who knew it was so difficult to remove a man page. > >> > > > > There is a pull request being worked on that will be smarter about what= 's > > removed since we have compress (UFS) and uncompress (ZFS) setups > > now. > > Does it just add an OLD_MAN helper variable to use instead of OLD_FILES > and then try the various extension combinations for each OLD_MAN? > https://github.com/freebsd/freebsd-src/pull/1295 was submitted a bit ago. the repetition is why I've not committed it. Is an approach like that good, or should we move all the old man pages to OLD_MAN? Warner > -- > John Baldwin > > --0000000000007e5a29061e67bba0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey John,

On Mon, Jul 29, 2024 at 11:5= 5=E2=80=AFAM John Baldwin <jhb@freebs= d.org> wrote:
On 7/29/24 13:40, Warner Losh wrote:
> On Mon, Jul 29, 2024 at 10:39=E2=80=AFAM Mark Johnston <markj@freebsd.org> wrote= :
>
>> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote:
>>> Mark Johnston wrote:
>>>> The branch main has been updated by markj:
>>>>
>>>> URL:
>> https://c= git.FreeBSD.org/src/commit/?id=3D801c452795ac441523655eb3277051b7b034becf
>>>>
>>>> commit 801c452795ac441523655eb3277051b7b034becf
>>>> Author:=C2=A0 =C2=A0 =C2=A0Mark Johnston <markj@FreeBSD= .org>
>>>> AuthorDate: 2024-07-29 14:12:40 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Mark Johnston <markj@FreeBSD= .org>
>>>> CommitDate: 2024-07-29 14:17:04 +0000
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0 man9: Really complete the removal of M= D5.9
>>>>
>>>>=C2=A0 =C2=A0 =C2=A0 Fixes:=C2=A0 46b0db2dbe9f ("Remov= e unnecessary and now inaccurate
>> kernel side manual page.")
>>>>=C2=A0 =C2=A0 =C2=A0 Fixes:=C2=A0 36d68cb2ddd2 ("Compl= ete the removal of the MD5 manual page
>> from section 9.")
>>>> ---
>>>>=C2=A0 =C2=A0ObsoleteFiles.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0| = 2 ++
>>>>=C2=A0 =C2=A0share/man/man9/Makefile | 2 --
>>>>=C2=A0 =C2=A02 files changed, 2 insertions(+), 2 deletions(= -)
>>>>
>>>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
>>>> index b21778466800..01b4824e8692 100644
>>>> --- a/ObsoleteFiles.inc
>>>> +++ b/ObsoleteFiles.inc
>>>> @@ -56,6 +56,8 @@ OLD_FILES+=3Dusr/share/man/man9/ifaddr_b= yindex.9.gz
>>>>
>>>>=C2=A0 =C2=A0# 20240729: remove MD5(9)
>>>>=C2=A0 =C2=A0OLD_FILES+=3Dusr/share/man/man9/MD5.9.gz
>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Init.9
>>>> +OLD_FILES+=3Dusr/share/man/man9/MD5Transform.9
>>>
>>> This really needs to be smarter, but you have to specify .gz s= uffix for
>>> man entries as we have compression enabled by default.
>>
>> Sigh, who knew it was so difficult to remove a man page.
>>
>
> There is a pull request being worked on that will be smarter about wha= t's
> removed since we have compress (UFS) and uncompress (ZFS) setups
> now.

Does it just add an OLD_MAN helper variable to use instead of OLD_FILES
and then try the various extension combinations for each OLD_MAN?

=

was submitted a bit ago. the repetition is why I've= not committed it. Is an approach
like that good, or should we mo= ve all the old man pages to OLD_MAN?

Warner
<= div>=C2=A0
--
John Baldwin

--0000000000007e5a29061e67bba0--