From nobody Mon Jul 15 20:39:07 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNDZd38W0z5RcbH for ; Mon, 15 Jul 2024 20:39:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNDZd1Bvyz4j3r for ; Mon, 15 Jul 2024 20:39:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-706a1711ee5so3183665b3a.0 for ; Mon, 15 Jul 2024 13:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1721075959; x=1721680759; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EozCT/G+qHiCfkOJCIVheGyMLt1uyN/SsGhzb/hewYY=; b=QAka6FczISfIDb7rULCUzg7LBbIDIdFJo047OrssaQI3fzN0hTtitQKhXRV67NcgBF OfH60ZxbxnAnUUYSpjY7b2VkR/eNAMG98ZQdIIo6U9zNOMQoQNTAdzqTLQkpvkCrC191 6QJdIphfRprn3KyMpUkSWj2MnhI563vpN7zxRy6drOSmqi8qJaRFSqJdeYUZLiLR73ka 99USnOLJAZo+iZd3jQszT2DlYMZP2OFmVhy0N9ir36Kqv5leHens9n19jFiKsnDpiK/M corOSP5jEgiuXxmpXBA9zIBKpjDJtF8eAaGf0Bt8IamqJURiGtKGANopOEyth+N14ZWW p0ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721075959; x=1721680759; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EozCT/G+qHiCfkOJCIVheGyMLt1uyN/SsGhzb/hewYY=; b=mOAbNXRxrXsOf8+mzHj9DBVaoqI0bN56B7pBiNYAMYjjPRRaJiL9XMVFUwtoFN5uxu XcHMbsFUlzCJ9EXh2aDeQPqvfwbyzzPeuCSeLSgidTItxZ6VlsIdMomMr4X4GoZrDT3o BAc5ifDg+dfyBeOBpPAr2QdAl9HT8T8rBAKyKf9c4rI/hbqZz2pZMTA2Jv9e62Fths9j UnVmMjHPn16n6Pncs9ND2ODRJf0BsUU66roTeOJPRmWo6aNG2AI2YFaUTif81vj2ecHF Lqe5ADPi7H7mvyMcJ97pw8hgSdcyCdQfu0N7wm74w8zf4HBNM2lZAAs/uBGrV7eqMSY2 Ailg== X-Forwarded-Encrypted: i=1; AJvYcCXdzcTwa+xqBPEzjFJS7dzZ4OXVONrO7pBSfEDtcy0Aw4yIxxJHRYsFFVRgZVH3BZY5GRteRtozlvCwQCpLoKoDPobVKCYVNHE9q93ZpFw8Kw== X-Gm-Message-State: AOJu0YzN3f/k4IAkJ9eM0di0JjJYwlcx4PIELVltLj8r9GfHcVG0o9Rc 9SdcX2ot4tl42YlO8nCIk1Rlz8K/tn0pzP8tPtIhB84RIEtD/8TA03TUcaLsnI/kEwKDXsL0q/Z Oi7H5SFRqr3TJ94FLRnqLYBacCbKbcAXO43WuZw== X-Google-Smtp-Source: AGHT+IHY1iyZAUe6KJtPCTweyjkPmF4sOp4cDlRZOI3ZzFUMPOMgg2+F49xr89imsFigsyHJN7+Cy/caP1t8oM7mH/M= X-Received: by 2002:a05:6a00:3916:b0:706:6af8:e088 with SMTP id d2e1a72fcca58-70c1fb4a270mr281158b3a.3.1721075959420; Mon, 15 Jul 2024 13:39:19 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202407151915.46FJFr7L039362@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Mon, 15 Jul 2024 14:39:07 -0600 Message-ID: Subject: Re: git: 9cc06bf7aa28 - main - amd64 GENERIC: Switch uart hints from "isa" to "acpi" To: John Baldwin Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="0000000000003177a1061d4f39af" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WNDZd1Bvyz4j3r --0000000000003177a1061d4f39af Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 15, 2024, 1:20=E2=80=AFPM John Baldwin wrote: > On 7/15/24 15:15, John Baldwin wrote: > > The branch main has been updated by jhb: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D9cc06bf7aa2846c35483de567779bb8= afc289f53 > > > > commit 9cc06bf7aa2846c35483de567779bb8afc289f53 > > Author: John Baldwin > > AuthorDate: 2024-07-15 19:14:01 +0000 > > Commit: John Baldwin > > CommitDate: 2024-07-15 19:15:29 +0000 > > > > amd64 GENERIC: Switch uart hints from "isa" to "acpi" > > > > This causes these hints to be only used to wire device unit number= s > > for serial ports enumerated by ACPI but will not create ISA device > > nodes if ACPI doesn't enumerate them. Note that IRQ hints are not > > used for wiring so have been removed. > > > > PR: 270707 > > Reported by: aixdroix_OSS@protonmail.com, Michael Dexter > > Reported by: mfw_burn@pm.me, Hannes Hfauswedell < > h2+fbsdports@fsfe.org> > > Reported by: Matthias Lanter > > Reported by: William Bulley > > Reviewed by: imp > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D45945 > > --- > > sys/amd64/conf/GENERIC.hints | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/sys/amd64/conf/GENERIC.hints b/sys/amd64/conf/GENERIC.hint= s > > index 7c2a3f28b9ce..4f6121c7cf77 100644 > > --- a/sys/amd64/conf/GENERIC.hints > > +++ b/sys/amd64/conf/GENERIC.hints > > @@ -6,13 +6,11 @@ hint.psm.0.at=3D"atkbdc" > > hint.psm.0.irq=3D"12" > > hint.sc.0.at=3D"isa" > > hint.sc.0.flags=3D"0x100" > > -hint.uart.0.at=3D"isa" > > +hint.uart.0.at=3D"acpi" > > hint.uart.0.port=3D"0x3F8" > > hint.uart.0.flags=3D"0x10" > > -hint.uart.0.irq=3D"4" > > -hint.uart.1.at=3D"isa" > > +hint.uart.1.at=3D"acpi" > > hint.uart.1.port=3D"0x2F8" > > -hint.uart.1.irq=3D"3" > > hint.atrtc.0.at=3D"isa" > > hint.atrtc.0.port=3D"0x70" > > hint.atrtc.0.irq=3D"8" > > Warner would like to purge more of this file (almost all of it) which is > probably correct. Warner believes that the uart0 flags to set serial > console aren't needed for loaders from FreeBSD 9+ due to the hw.uart.* > tunables modern loaders set. I'm less certain about hints for "fixed" > devices such as attimer0, atrtc0, and atkbdc0. I feel like some systems > have failed to enumerate those in the past, though such systems may be > i386-only. The sc0 hints I think can go away once we fully deprecate > sc(4) in favor of only vt(4). > atkbdc likely needs to go. Legacy free systems don't have it and I've helped at least one person in the past whose system hung after accessing ports 60 and 61. attimer is unused on modern systems that have several other options. It likely can go. atrtc isn't needed for uefi, since efirt can get the time much faster. I think it is in acpi but I'm not entirely sure. Sc is unused by and large and is set for removal :) people using it may have to take extra actions... I've chosen to leave i386 alone as there's still some ancient i386 cruft, > but on amd64 we have a higher bar (e.g. ACPI is de facto required for > amd64). Also, i386 kernels have one foot in the grave already. > > This commit is also somewhat narrow in scope as I plan to merge it back > to 13 and 14. > Sounds like a plan. We have time. Warner --=20 > John Baldwin > > --0000000000003177a1061d4f39af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Jul 15, 2024, 1:20=E2=80=AFPM John Baldwin <= ;jhb@freebsd.org> wrote:
On 7/15/24 15:15, John Baldwin wrote:
> The branch main has been updated by jhb:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=3D9cc06bf7aa2846c35483de567779bb= 8afc289f53
>
> commit 9cc06bf7aa2846c35483de567779bb8afc289f53
> Author:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2024-07-15 19:14:01 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2024-07-15 19:15:29 +0000
>
>=C2=A0 =C2=A0 =C2=A0 amd64 GENERIC: Switch uart hints from "isa&qu= ot; to "acpi"
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 This causes these hints to be only used to wire de= vice unit numbers
>=C2=A0 =C2=A0 =C2=A0 for serial ports enumerated by ACPI but will not c= reate ISA device
>=C2=A0 =C2=A0 =C2=A0 nodes if ACPI doesn't enumerate them.=C2=A0 No= te that IRQ hints are not
>=C2=A0 =C2=A0 =C2=A0 used for wiring so have been removed.
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 PR:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0270707
>=C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 aixdroix_OSS@pr= otonmail.com, Michael Dexter
>=C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 mfw_burn@pm.me, Hannes H= fauswedell <h2+fbsdports@fsfe.org>
>=C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 Matthias Lanter <fr= eebsd@lanter-it.ch>
>=C2=A0 =C2=A0 =C2=A0 Reported by:=C2=A0 =C2=A0 William Bulley <web@umich.= edu>
>=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 imp
>=C2=A0 =C2=A0 =C2=A0 MFC after:=C2=A0 =C2=A0 =C2=A0 1 week
>=C2=A0 =C2=A0 =C2=A0 Differential Revision:=C2=A0 h= ttps://reviews.freebsd.org/D45945
> ---
>=C2=A0 =C2=A0sys/amd64/conf/GENERIC.hints | 6 ++----
>=C2=A0 =C2=A01 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/sys/amd64/conf/GENERIC.hints b/sys/amd64/conf/GENERIC.hin= ts
> index 7c2a3f28b9ce..4f6121c7cf77 100644
> --- a/sys/amd64/conf/GENERIC.hints
> +++ b/sys/amd64/conf/GENERIC.hints
> @@ -6,13 +6,11 @@ hint.psm.0.at=3D"atkbdc"
>=C2=A0 =C2=A0hint.psm.0.irq=3D"12"
>=C2=A0 =C2=A0hint.sc.0.at=3D"isa"
>=C2=A0 =C2=A0hint.sc.0.flags=3D"0x100"
> -hint.uart.0.at=3D"isa"
> +hint.uart.0.at=3D"acpi"
>=C2=A0 =C2=A0hint.uart.0.port=3D"0x3F8"
>=C2=A0 =C2=A0hint.uart.0.flags=3D"0x10"
> -hint.uart.0.irq=3D"4"
> -hint.uart.1.at=3D"isa"
> +hint.uart.1.at=3D"acpi"
>=C2=A0 =C2=A0hint.uart.1.port=3D"0x2F8"
> -hint.uart.1.irq=3D"3"
>=C2=A0 =C2=A0hint.atrtc.0.at=3D"isa"
>=C2=A0 =C2=A0hint.atrtc.0.port=3D"0x70"
>=C2=A0 =C2=A0hint.atrtc.0.irq=3D"8"

Warner would like to purge more of this file (almost all of it) which is probably correct.=C2=A0 Warner believes that the uart0 flags to set serial<= br> console aren't needed for loaders from FreeBSD 9+ due to the hw.uart.*<= br> tunables modern loaders set.=C2=A0 I'm less certain about hints for &qu= ot;fixed"
devices such as attimer0, atrtc0, and atkbdc0.=C2=A0 I feel like some syste= ms
have failed to enumerate those in the past, though such systems may be
i386-only.=C2=A0 The sc0 hints I think can go away once we fully deprecate<= br> sc(4) in favor of only vt(4).

atkbdc likely needs to go. Legacy free systems= don't have it and I've helped at least one person in the past whos= e system hung after accessing ports 60 and 61.

<= /div>
attimer is unused on modern systems that have severa= l other options. It likely can go.

atrtc isn't needed for uefi, since efirt can get the time mu= ch faster. I think it is in acpi but I'm not entirely sure.

Sc is unused by and large and is se= t for removal :)=C2=A0 people using it may have to take extra actions...

I've chosen to leave i386 alone as there's still some ancient i386 = cruft,
but on amd64 we have a higher bar (e.g. ACPI is de facto required for
amd64).=C2=A0 Also, i386 kernels have one foot in the grave already.

This commit is also somewhat narrow in scope as I plan to merge it back
to 13 and 14.

Sounds like a plan. We have time.

<= /div>
Warner

--
John Baldwin

--0000000000003177a1061d4f39af--