From nobody Wed Jan 31 20:59:41 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQDty3566z58H56 for ; Wed, 31 Jan 2024 20:59:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQDty0s2Fz4pJ9 for ; Wed, 31 Jan 2024 20:59:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40f02b8d176so2187395e9.1 for ; Wed, 31 Jan 2024 12:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1706734792; x=1707339592; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NrcCEmiADp66qPIs9y2DA9yR4Pa7Z8E7WZcZhOdgqzc=; b=zRnfusijo/KBzSufTofDl3InJcG4KWUQQtEk7ZjpfJYEFbHC4ukGrUXDFqYxFBLxTC 5pEibghXDj9gcSBSPbmutyqSAKr0i5mknSWrBvejqF/OVrxydNsFSFFkb/vWCXMq2ZIL HuuP2eRWe/aRlJuQeD/jPKwrF49OQhp4kqsFjl1Wn8DNle84+5MLmRE/B2B+D4FrsggP eEoM2AYgsaZDCXCN8vGTVta+Sm8Ha/RgMVMOtJo7B/rkV6hudMrBUfHTnuVgDa44sCZ+ WzGumh2GBtzFf7+Hf2Nqp24M5IK0lzym5B+RbwaXdcb4hnCyVkm/7MMZ48R83HKekP8P lb5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706734792; x=1707339592; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrcCEmiADp66qPIs9y2DA9yR4Pa7Z8E7WZcZhOdgqzc=; b=U0NWMpJQ58xVVhkZgUzT884/BGeIm3MRXsSG0N7vkXiJIlYTK+Eg10ZigFJVV5k9po cYCfvjMbBXLAdy0h7rKAwqTzyiBsBHMM26Sdutv0yfYPAAkrmNLBAjZXHNkIGTLM1Tn/ JZTnp8IFtO3PPf6X+EJ0qSrw6xlESMBdcQUKmz2T/A3XcFI6hcVjygz3IXp4jTSSedu5 OE+3sPH/6uPdhHunp1ZqKifyV2ta77HSGOjzBAfH/YxWGs/j+ogZyrgr3kEPzJgVA0K3 ROFTnNjGCBGLQEy9JgY1jE6ZaPmLFwnE4AkVGlEdK/Pv/bFPBR8dXWTAGEnas3/buUVE bb4w== X-Gm-Message-State: AOJu0Yw4iZFlokMJml762iDOI7yA3av5Aj0qQkK5OMrAq/04SsnOYlC7 GUSunft4JqKDxnS88RIEUHrhQX2WcOc9m08AeravqJF1pq8FAbxe2Zv1cSMNPL0TESGcUOGVOAu 0k4nqbOlSwL4/GeyVSBqvzaPq45nV5ixVct0bdQ== X-Google-Smtp-Source: AGHT+IENc1u2nSpWBhQCzH6yYP7XLYVFt07DQvtw13THW+rgdyQsgk8mDdPvCrZe4wXdfJwD4KifHrFXNJubRrFMt9U= X-Received: by 2002:adf:fd82:0:b0:33b:1275:21e7 with SMTP id d2-20020adffd82000000b0033b127521e7mr209984wrr.1.1706734792296; Wed, 31 Jan 2024 12:59:52 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> <20240131204355.9EA2B19F@slippy.cwsent.com> In-Reply-To: <20240131204355.9EA2B19F@slippy.cwsent.com> From: Warner Losh Date: Wed, 31 Jan 2024 13:59:41 -0700 Message-ID: Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 To: Cy Schubert Cc: Andriy Gapon , Jung-uk Kim , Baptiste Daroussin , src-committers , "" , "" , Dmitry Salychev Content-Type: multipart/alternative; boundary="0000000000000560d10610442914" X-Rspamd-Queue-Id: 4TQDty0s2Fz4pJ9 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --0000000000000560d10610442914 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert wrote: > In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy > Gapon > wri > tes: > > On 31/01/2024 19:40, Cy Schubert wrote: > > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, > Jung-uk Kim > > > writ > > > es: > > >> On 24. 1. 31., Baptiste Daroussin wrote: > > >>> Hello, > > >>> > > >>> Either this one or the previous import is breaking arm64 build > > >>> > > >>> --- acpi_iort.o --- > > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error= : > fiel > > d > > >>> 'data' with variable sized type 'union (unnamed union at > > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 > > >>> )' not at the end of a struct or class is a GNU extension > > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] > > >>> 103 | } data; > > >>> | ^ > > >> > > >> Sorry for the breakage. I will fix it soon. > > >> > > >> BTW, this code was added by this: > > >> > > >> https://reviews.freebsd.org/D31267 > > >> > > >> It seems struct iort_named_component was a hack, which duplicated > > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field > DeviceName[32]. > > >> Is it really necessary? > > > > > > Though they incorporated the WOL patch I've been using, they've broke= n > > > poweroff. > > > > The poweroff issue could be because of 9cdf326b4f > > Thanks. I clued into that a while ago after taking a break to read the ML= . > > This smelled of the original WOL problem I had last year that required > pulling the plug to allow the NIC to see the magic packet, but worse. > Hence > I was barking up the wrong tree. > On an semi-related issue... mind if I do a proper merge commit to catch up and not leave hidden landmines for the future? Warner > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=3D0 > > > --0000000000000560d10610442914 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 31, 2024, 1:44=E2=80=AFPM Cy Schubert <= Cy.Schubert@cschubert.com&= gt; wrote:
In message <737703f2-= 26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy Gapon
wri
tes:
> On 31/01/2024 19:40, Cy Schubert wrote:
> > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org&g= t;, Jung-uk Kim
> > writ
> > es:
> >> On 24. 1. 31., Baptiste Daroussin wrote:
> >>> Hello,
> >>>
> >>> Either this one or the previous import is breaking arm64 = build
> >>>
> >>> --- acpi_iort.o ---
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:10= 3:4: error: fiel
> d
> >>> 'data' with variable sized type 'union (unnam= ed union at
> >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98= :2
> >>> )' not at the end of a struct or class is a GNU exten= sion
> >>> [-Werror,-Wgnu-variable-sized-type-not-at-end]
> >>>=C2=A0 =C2=A0 =C2=A0103 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0} data;
> >>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0^
> >>
> >> Sorry for the breakage.=C2=A0 I will fix it soon.
> >>
> >> BTW, this code was added by this:
> >>
> >> https://reviews.freebsd.org/D31267 > >>
> >> It seems struct iort_named_component was a hack, which duplic= ated
> >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field Devic= eName[32].
> >> Is it really necessary?
> >
> > Though they incorporated the WOL patch I've been using, they&= #39;ve broken
> > poweroff.
>
> The poweroff issue could be because of 9cdf326b4f

Thanks. I clued into that a while ago after taking a break to read the ML.<= br>
This smelled of the original WOL problem I had last year that required
pulling the plug to allow the NIC to see the magic packet, but worse. Hence=
I was barking up the wrong tree.

On an semi-related issue... mind if I do a = proper merge commit to catch up and not leave hidden landmines for the futu= re?

Warner

--
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:=C2=A0 <cy@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 ht= tps://FreeBSD.org
NTP:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<cy@nwtime.org>=C2=A0 =C2= =A0 Web:=C2=A0 https://nwtime.org

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 e^(i*pi)+1=3D0


--0000000000000560d10610442914--