From nobody Wed Jan 31 20:43:55 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQDXZ5dJLz58Fx3; Wed, 31 Jan 2024 20:43:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQDXZ3PJsz4mVd; Wed, 31 Jan 2024 20:43:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id VCOCrXvudxDxGVHR7rIbyg; Wed, 31 Jan 2024 20:43:57 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id VHR6rCRRV9Cr4VHR6r3GKw; Wed, 31 Jan 2024 20:43:57 +0000 X-Authority-Analysis: v=2.4 cv=etl8zZpX c=1 sm=1 tr=0 ts=65bab10d a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=dEuoMetlWLkA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=S-cxxyXkFpmfPYfbDscA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id A87913B1; Wed, 31 Jan 2024 12:43:55 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 9EA2B19F; Wed, 31 Jan 2024 12:43:55 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Andriy Gapon cc: Cy Schubert , Jung-uk Kim , Baptiste Daroussin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dmitry Salychev Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 In-reply-to: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> Comments: In-reply-to Andriy Gapon message dated "Wed, 31 Jan 2024 22:36:28 +0200." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 31 Jan 2024 12:43:55 -0800 Message-Id: <20240131204355.9EA2B19F@slippy.cwsent.com> X-CMAE-Envelope: MS4xfAKIu5oasPJIEYFpS2orRQl44m6PAudgRZ+789yv99kNitxFav7Qe6wAznVtsQkKJb0tQUYkfNuvsAZ9xEO7sPutMaOjPQXLOJ16nwqgo3IeEiLyQAca eWklq0nZabFIeB51OLWJLcEmiZ2j2gm5PgLMX4+92GT8IHH2iAY9tr7Aj3qX1vLq6qhMe1J/vL1Emi7MwQQsLMrg35HLMKPqANmKk89rEWwVtwGDj2xHb7SA dWgOP0sbyDcYei78eq5Fy9vGVTnX/K0C6b63Qa+4mqRCgXoSg2bW4LQjuB7M3zR60R6CjH5WDZEnUk/NJ+ZWsERHQNHfew0bGlGWQiTrSDRVqxjpoVVg33O8 kKUgxGAzbdIIMpL9xFQDFv/74CI7zvo6O2nDT8tvJ1Xs5bF8yxk= X-Rspamd-Queue-Id: 4TQDXZ3PJsz4mVd X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy Gapon wri tes: > On 31/01/2024 19:40, Cy Schubert wrote: > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, Jung-uk Kim > > writ > > es: > >> On 24. 1. 31., Baptiste Daroussin wrote: > >>> Hello, > >>> > >>> Either this one or the previous import is breaking arm64 build > >>> > >>> --- acpi_iort.o --- > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error: fiel > d > >>> 'data' with variable sized type 'union (unnamed union at > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 > >>> )' not at the end of a struct or class is a GNU extension > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] > >>> 103 | } data; > >>> | ^ > >> > >> Sorry for the breakage. I will fix it soon. > >> > >> BTW, this code was added by this: > >> > >> https://reviews.freebsd.org/D31267 > >> > >> It seems struct iort_named_component was a hack, which duplicated > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field DeviceName[32]. > >> Is it really necessary? > > > > Though they incorporated the WOL patch I've been using, they've broken > > poweroff. > > The poweroff issue could be because of 9cdf326b4f Thanks. I clued into that a while ago after taking a break to read the ML. This smelled of the original WOL problem I had last year that required pulling the plug to allow the NIC to see the magic packet, but worse. Hence I was barking up the wrong tree. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0