From nobody Wed Jan 31 17:40:30 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TQ8Sy4Bn5z58x8G; Wed, 31 Jan 2024 17:40:34 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TQ8Sy017Yz4KnY; Wed, 31 Jan 2024 17:40:33 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id V5kKrXhqExDxGVEZdrHvXo; Wed, 31 Jan 2024 17:40:33 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id VEZbrBMza9Cr4VEZcr2ocS; Wed, 31 Jan 2024 17:40:33 +0000 X-Authority-Analysis: v=2.4 cv=etl8zZpX c=1 sm=1 tr=0 ts=65ba8611 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=dEuoMetlWLkA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=TY5y7QwLGcO0zdUOPHQA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id AC45620E; Wed, 31 Jan 2024 09:40:30 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 8787610F; Wed, 31 Jan 2024 09:40:30 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jung-uk Kim cc: Baptiste Daroussin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Dmitry Salychev Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 In-reply-to: <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org> References: <202401310406.40V46B9a000876@gitrepo.freebsd.org> <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org> Comments: In-reply-to Jung-uk Kim message dated "Wed, 31 Jan 2024 11:28:56 -0500." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 31 Jan 2024 09:40:30 -0800 Message-Id: <20240131174030.8787610F@slippy.cwsent.com> X-CMAE-Envelope: MS4xfACdP3xL0AmS+MNKUSBMshFGGPU1dPSXgW5xuse6natYa0LDNgjqnDZNfxTXrd94EOqxYteWSntia0r4As4itUezSChNGhZ0bR9Dw8h/aYbKyHzKXgxK fm/Htde/bJHiq/U+Y6YykLHLAOnbEu5tUnGiXq95Dta9CX49ZVbVOnvPd+AYiZNU0ZRDwp7ykXcB2n5up4cGJM5HpbLwoVGwV5Tlz91LYVnvtUc0PjSCnJCd brJFWGPU68T1Qh2tSgbsPPqAQPG78x3SzdZl4nR/nPXF5fWdtDTvCetaWo5Il1zm1bHi61Zs1bh+NAgPMffqke8lLOv4Rn8gU1aFBCLJMwV85YCDv6iYjksE 11P/fvg3q6W+qT8xsgzZeTzVUMb8Sg== X-Rspamd-Queue-Id: 4TQ8Sy017Yz4KnY X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, Jung-uk Kim writ es: > On 24. 1. 31., Baptiste Daroussin wrote: > > Hello, > > > > Either this one or the previous import is breaking arm64 build > > > > --- acpi_iort.o --- > > /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error: field > > 'data' with variable sized type 'union (unnamed union at > > /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 > > )' not at the end of a struct or class is a GNU extension > > [-Werror,-Wgnu-variable-sized-type-not-at-end] > > 103 | } data; > > | ^ > > Sorry for the breakage. I will fix it soon. > > BTW, this code was added by this: > > https://reviews.freebsd.org/D31267 > > It seems struct iort_named_component was a hack, which duplicated > ACPI_IORT_NAMED_COMPONENT but with a fixed length field DeviceName[32]. > Is it really necessary? Though they incorporated the WOL patch I've been using, they've broken poweroff. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0