From nobody Mon Jan 29 22:32:16 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TP32T0xPWz57Z0m; Mon, 29 Jan 2024 22:32:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TP32S5bRrz4gCr; Mon, 29 Jan 2024 22:32:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706567536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/8EBSJgSzl6E4vxJ/GktvMD9bT8YgMqcc8zpYjlIIEA=; b=Eu2YxxztWAGHbsQ6BZtw4u9eYzrm3HYjGyuZoUPEQTpa0/p3Bp8amDXMBG9Q2kI5I1C0Wt Ko4d1BoGgXxfooXeHySc0Yx5DqsY3ZghB19/QfmPxjKqjeM+dq/GvwKBX6zRRwcGg+Jl+o +eyCJ9QgPC73UhZmH1S3FCQMPBX0HsnhlzRZQS2MDVkMXxgOrCZpqLt8uOymst9GODTdFU YU7yMuoj+sfZ8P0Mb/wdnH05kc3uyvj/qiUG5ALJiL1c/ACtLB5vPYHWyGMTkj6qGAWqBS dceBmoB8xIECCXUaheV1SetZuS8t9gYJN+Z/FEwqhV3spJOJJgjXrA7G8fCFww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706567536; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/8EBSJgSzl6E4vxJ/GktvMD9bT8YgMqcc8zpYjlIIEA=; b=FHqXkzBRPT/iA5JIsg4IjRFZQw3JnnyTiEb+kI9SwDgvsy2AdIQM4CfUcj6zl6We79ynnw yqY6JtBiJTVWk53KbW78EwcpzhyXLz2yAb7BxhiQvhP04bOX8Mkz9Z0FZkEwONarWKFZPM kHYbwLksfUjo56EGfU0OqDa/2EDxbIhBGpT9s33XiK/p16prAVa0stNlS5DOx4ttBRK8+O Xs88XEMAtuXes+HAG16kleF44xHNfP80UmW/WxF7KpQrVabIj4JiRkVgR147/mU568DkDT zI5BQ2sisZRaW3WCendOkgAsA+9FmuPUa3zoQtEWBqKMrd59Dd1Xi3VApv2Ieg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706567536; a=rsa-sha256; cv=none; b=WAIOpe1Gn3RQ4OFwEtTbpPXIrIectp4Zesvz+vbsrGMDd6Q/jCeJmgrveriUCG72+gVS1S v3VkWSz4z/M6ck4bAiTbKAMMTkPNWCLxJswOOoLtQgae58rEhCYWTuG/CJ0QL8np/hcsoN oSpjw0PLv1YEAJS0lejHFeI6E0Eq5orCskH0Kg2ecgWjyZAXED6ykYtBIkt6vSFn3bvpMk +MHiqSKPUC/R7MMkRzclqdYN7Xi2bxLPkE71YqgX73RGpYEE00ZCKittX6DiLx4gVbW6Ge dFPr4Wmg9izLlK9JWACXV8QH4e7rsjPBPWRIHhlNzIWFiTOvNOnFFiCUPfzcyg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TP32S4jFrz197M; Mon, 29 Jan 2024 22:32:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40TMWGqZ013730; Mon, 29 Jan 2024 22:32:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40TMWGmq013727; Mon, 29 Jan 2024 22:32:16 GMT (envelope-from git) Date: Mon, 29 Jan 2024 22:32:16 GMT Message-Id: <202401292232.40TMWGmq013727@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 7b94ec550ef6 - main - setusercontext(): Move priority setting in new setclasspriority() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7b94ec550ef6e7b75d608e125e9b78478197d4e7 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=7b94ec550ef6e7b75d608e125e9b78478197d4e7 commit 7b94ec550ef6e7b75d608e125e9b78478197d4e7 Author: Olivier Certner AuthorDate: 2023-05-29 17:09:36 +0000 Commit: Olivier Certner CommitDate: 2024-01-29 21:58:08 +0000 setusercontext(): Move priority setting in new setclasspriority() In preparation for setting priorities from '~/.login_conf' and to ease reading of setusercontext(). No functional change. Reviewed by: emaste Approved by: emaste (mentor) MFC after: 3 days Sponsored by: Kumacom SAS Differential Revision: https://reviews.freebsd.org/D40350 --- lib/libutil/login_class.c | 97 +++++++++++++++++++++++++---------------------- 1 file changed, 52 insertions(+), 45 deletions(-) diff --git a/lib/libutil/login_class.c b/lib/libutil/login_class.c index 269349a49dad..d36926d70224 100644 --- a/lib/libutil/login_class.c +++ b/lib/libutil/login_class.c @@ -455,6 +455,56 @@ setlogincontext(login_cap_t *lc, const struct passwd *pwd, unsigned long flags) } +/* + * Private function to set process priority. + */ +static void +setclasspriority(login_cap_t * const lc, struct passwd const * const pwd) +{ + const rlim_t def_val = LOGIN_DEFPRI, err_val = INT64_MIN; + rlim_t p = login_getcapnum(lc, "priority", def_val, err_val); + int rc; + + if (p == err_val) { + /* Invariant: 'lc' != NULL. */ + syslog(LOG_WARNING, + "%s%s%sLogin class '%s': " + "Invalid priority specification: '%s'", + pwd ? "Login '" : "", + pwd ? pwd->pw_name : "", + pwd ? "': " : "", + lc->lc_class, + login_getcapstr(lc, "priority", "", "")); + /* Reset the priority, as if the capability was not present. */ + p = def_val; + } + + if (p > PRIO_MAX) { + struct rtprio rtp; + + rtp.type = RTP_PRIO_IDLE; + p += RTP_PRIO_MIN - (PRIO_MAX + 1); + rtp.prio = p > RTP_PRIO_MAX ? RTP_PRIO_MAX : p; + rc = rtprio(RTP_SET, 0, &rtp); + } else if (p < PRIO_MIN) { + struct rtprio rtp; + + rtp.type = RTP_PRIO_REALTIME; + p += RTP_PRIO_MAX - (PRIO_MIN - 1); + rtp.prio = p < RTP_PRIO_MIN ? RTP_PRIO_MIN : p; + rc = rtprio(RTP_SET, 0, &rtp); + } else + rc = setpriority(PRIO_PROCESS, 0, (int)p); + + if (rc != 0) + syslog(LOG_WARNING, + "%s%s%sLogin class '%s': " + "Setting priority failed: %m", + pwd ? "Login '" : "", + pwd ? pwd->pw_name : "", + pwd ? "': " : "", + lc ? lc->lc_class : ""); +} /* * setusercontext() @@ -489,51 +539,8 @@ setusercontext(login_cap_t *lc, const struct passwd *pwd, uid_t uid, unsigned in flags &= ~(LOGIN_SETGROUP | LOGIN_SETLOGIN | LOGIN_SETMAC); /* Set the process priority */ - if (flags & LOGIN_SETPRIORITY) { - const rlim_t def_val = LOGIN_DEFPRI, err_val = INT64_MIN; - rlim_t p = login_getcapnum(lc, "priority", def_val, err_val); - int rc; - - if (p == err_val) { - /* Invariant: 'lc' != NULL. */ - syslog(LOG_WARNING, - "%s%s%sLogin class '%s': " - "Invalid priority specification: '%s'", - pwd ? "Login '" : "", - pwd ? pwd->pw_name : "", - pwd ? "': " : "", - lc->lc_class, - login_getcapstr(lc, "priority", "", "")); - /* Reset the priority, as if the capability was not present. */ - p = def_val; - } - - if (p > PRIO_MAX) { - struct rtprio rtp; - - rtp.type = RTP_PRIO_IDLE; - p += RTP_PRIO_MIN - (PRIO_MAX + 1); - rtp.prio = p > RTP_PRIO_MAX ? RTP_PRIO_MAX : p; - rc = rtprio(RTP_SET, 0, &rtp); - } else if (p < PRIO_MIN) { - struct rtprio rtp; - - rtp.type = RTP_PRIO_REALTIME; - p += RTP_PRIO_MAX - (PRIO_MIN - 1); - rtp.prio = p < RTP_PRIO_MIN ? RTP_PRIO_MIN : p; - rc = rtprio(RTP_SET, 0, &rtp); - } else - rc = setpriority(PRIO_PROCESS, 0, (int)p); - - if (rc != 0) - syslog(LOG_WARNING, - "%s%s%sLogin class '%s': " - "Setting priority failed: %m", - pwd ? "Login '" : "", - pwd ? pwd->pw_name : "", - pwd ? "': " : "", - lc ? lc->lc_class : ""); - } + if (flags & LOGIN_SETPRIORITY) + setclasspriority(lc, pwd); /* Setup the user's group permissions */ if (flags & LOGIN_SETGROUP) {