From nobody Mon Jan 29 16:41:34 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TNvFp4n7wz59196; Mon, 29 Jan 2024 16:41:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TNvFp2s8gz4qP7; Mon, 29 Jan 2024 16:41:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706546494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R26wf6CH90qyDmY9tIxuJM0L0XFbpOcNORXIfwMhbmE=; b=TfIMOqFfQe8m20kXVGRAlCz1/0oeIDQ0usN15CAe2rkG5iz6gLPzNA3eKmgSO2IKUVFdmF vv7vg97tiKRt9rdY2Wzr4XMQNmh2TrSsfgd18qEhZYAw6EU3rP3TbtFEmeeDNOO1RnOFT8 9bcqEKUPeSI4/LlWQuTe8YsTl9uXXicy2MUzjPuW5umt9uMAIuhTJYInsQ/TJZKpf9qSAK FcfKfEDJtgY9wZIaRD0b9GvqClFiFFZpw60dyh/2mCNzGeLZbs4dIjgwME4tF763B9/uV3 F47/F18P87X+2kpnnsFQTTILjOq6yIYB2u27LKTD0d60er14VOjUe5JSe1wqNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706546494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=R26wf6CH90qyDmY9tIxuJM0L0XFbpOcNORXIfwMhbmE=; b=fa5V8nu+cFISRwfQn96GwbTzIlmNfDl5ucaMC1ZQgKGsxp3qsO2zdgIeArgVGX1+lTYw+F 4kKYbG/8SG1DYg/y/rLVQ33YmPmFhrb8I8nLH5pgMeUZg0lG6lN/oMtI6mEyyap+qVO5mI RlGABASQ1TyC9IO39k1poDDa5KBbGzKYAvkMuZpeP4QA27ysGScOVQl/pPppvR2wOGQfmd MAkr+xoaQt9KoVWunbLMWF4uIxDJvnaVw7aNUaZea3y5jhdMlEnbS3NRIS4KtUVbHxxjJn 7LG8IMy7pOW0+HrU46ytUd0z6YbvdiUA4WbxxRd8RmHNwV95T7XqCP8QfPU78Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706546494; a=rsa-sha256; cv=none; b=naiRVSaV9geue1+gV9JfaBi1k+nghZaeTww4f1y+o3HUaxQtfzzS10ln+HcQnj4FZxzxtM W/2aKEhKi8sdBAlleWOzmzVFjskVaStn+qML5g6gpg+nSDJEfG0ykmasSdqW8YNmiP8p/S VepdqFtXhtu3VYT88kVGJqVPB3iNoeb9PDFeOKhyoi9c3mC2rvfo8CarCXLt0/ooV+KtOq 3GRNMKQeOAgIsRb6Oi46yo1b/TY4KalfmGWzG7RicUw4VolRbOjdZS3lq7dXKuPaD+IDpt DanHdecsI7sh5trZ68I4v9hT9Lq/MvbcA4iKk2/elzLT286db60OKRRs5Ksu9g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TNvFp1xGSzyl0; Mon, 29 Jan 2024 16:41:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40TGfYjp018249; Mon, 29 Jan 2024 16:41:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40TGfYFr018246; Mon, 29 Jan 2024 16:41:34 GMT (envelope-from git) Date: Mon, 29 Jan 2024 16:41:34 GMT Message-Id: <202401291641.40TGfYFr018246@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 7e77089dccd7 - main - linuxkpi: remove invalid KASSERT from hash_add_rcu List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7e77089dccd702eb767350a8bd3d20102c4fb591 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=7e77089dccd702eb767350a8bd3d20102c4fb591 commit 7e77089dccd702eb767350a8bd3d20102c4fb591 Author: Ed Maste AuthorDate: 2024-01-29 14:25:40 +0000 Commit: Ed Maste CommitDate: 2024-01-29 16:40:17 +0000 linuxkpi: remove invalid KASSERT from hash_add_rcu hash_add_rcu asserted that the node's prev pointer was NULL in an attempt to detect addition of a node already on a list, but the caller is not required to provide a zeroed node. Reported in https://github.com/freebsd/drm-kmod/issues/282 Reviewed by: bz, manu Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D43645 --- sys/compat/linuxkpi/common/include/linux/hashtable.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/hashtable.h b/sys/compat/linuxkpi/common/include/linux/hashtable.h index 5703d6282ad7..55755c354959 100644 --- a/sys/compat/linuxkpi/common/include/linux/hashtable.h +++ b/sys/compat/linuxkpi/common/include/linux/hashtable.h @@ -92,8 +92,6 @@ __hash_node_type_assert(struct hlist_node *node) #define hash_add_rcu(ht, node, key) do { \ struct lkpi_hash_head *__head = &(ht)[hash_min(key, HASH_BITS(ht))]; \ __hash_node_type_assert(node); \ - KASSERT(((struct lkpi_hash_entry *)(node))->entry.cle_prev == NULL, \ - ("node is already on list or was not zeroed")); \ CK_LIST_INSERT_HEAD(&__head->head, \ (struct lkpi_hash_entry *)(node), entry); \ } while (0)