From nobody Thu Jan 25 01:24:26 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TL35h64Rlz57Mtg for ; Thu, 25 Jan 2024 01:24:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TL35h2LqVz45ZF for ; Thu, 25 Jan 2024 01:24:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-55a9008c185so529385a12.1 for ; Wed, 24 Jan 2024 17:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1706145878; x=1706750678; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9rFrH/GduqaqGzGXG4Hs2ikT1P45SEPiCsjVb6USA30=; b=qwiMpeLWmW3he30NnpisnUakgc8GMolu6yHaBSGqM4gDW3AN7Oti4s6bg571oLF2L6 iBOu9+wnZoNYdScZX/1d4YX7cVBmiVd2tnw0kycLSgLK7Aod2oJVJD5ezuE4JbZj3aAD lltlR/Ue945Yl70pctPHZ2uTakzgmACaExewHnX2bMb+8kJOlCQwvUMzrOpAXWH+SDhe Ixn0uwlKQ+UDJn5IKUGCRxxWKehU6oatpbt9l/SuAWy6L+UhgJTLdDyHyfKpe2ifnuf3 CaeRk/8LxI8kMsZZkYVzc7gtYdxHFywxbeZpY9vQRcfPXoCj9/PdlLBWq7+6DK2vBUGQ B0oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706145878; x=1706750678; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9rFrH/GduqaqGzGXG4Hs2ikT1P45SEPiCsjVb6USA30=; b=iRfmbNCWx/7aGGTTnvW9/Cm/63dtTlHLcqlTEPX2QPr25HgFcVePKZTar8h5qwmnol u2ojElRGev2O8jci+gtTGamsrBuLY5CTy1Z7s7QqbVk3J7dgUnhs64ySuutS9ChHc5aK ozCK+Ex7ieB9pv9mVfCd9J1Ftk1awaG5uaNkUsnWA0n4npY+87negrGBhcgqsYkJ3ZgQ rVkV5nWSKSsV8CEpOIGRDFEWf1QgvECpjVD+cVpEZnB5rGTaj6KjXLhV+QrTm5r+UcMT Z7qxYVNT2Q693qd9BIRU/gueYwrXIgfHK9B2LViyFASg77nTHVfX5XXv249KmEUttsp1 Nyfg== X-Gm-Message-State: AOJu0YynJYsbBbT/qLPf5tPiGkhd8j8eTiFkBwsH8qvK26QzAyrcEE0C 6FhSJP8zzQH67k/bPry1RyFDbAXIWCJL6nOtYcSMSV2OEsZpc2dhpG/lMMhCrWfHIy+vo0BrQp0 bYKjwMA+k++bOtiBloWbv0CY/VbjWDeguMFZCCgqQWEtiIfk7 X-Google-Smtp-Source: AGHT+IH7CPOqRE/1D7xSeBEebIEja07kpnS40xT/3I6z4r5vPuuyB2f+5bo7V2ewGrPUhi7t97R5LdCa/QQVUT5TehY= X-Received: by 2002:aa7:d94c:0:b0:55c:ffe4:9771 with SMTP id l12-20020aa7d94c000000b0055cffe49771mr109613eds.33.1706145877629; Wed, 24 Jan 2024 17:24:37 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org> In-Reply-To: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org> From: Warner Losh Date: Wed, 24 Jan 2024 18:24:26 -0700 Message-ID: Subject: Re: git: 820401bf1769 - main - nl_types.h: explicitly include cdefs.h To: Ed Maste Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000f8abb3060fbb0aa2" X-Rspamd-Queue-Id: 4TL35h2LqVz45ZF X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000f8abb3060fbb0aa2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This was one of the things i wanted to comment on the that review. This change should be done as a special Linux sys/param.h that includes ctypes.h and then includes the next sys/param.h. A large number of the changes from that review are similar and i wanted yo think through the right solution. This is fragile: I'm likely to remove it again because it violates style(9) and has no docs around it. Warner On Wed, Jan 24, 2024, 3:05=E2=80=AFPM Ed Maste wrote: > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41091d2e4190aded= 12a966b1d > > commit 820401bf176996e41091d2e4190aded12a966b1d > Author: Val Packett > AuthorDate: 2024-01-16 18:42:26 +0000 > Commit: Ed Maste > CommitDate: 2024-01-24 21:59:18 +0000 > > nl_types.h: explicitly include cdefs.h > > This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping from > Linux/musl, they were missing. > > Sponsored by: https://www.patreon.com/valpackett > Pull Request: https://github.com/freebsd/freebsd-src/pull/1066 > --- > include/nl_types.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/nl_types.h b/include/nl_types.h > index 120d1911631f..6ba15132126d 100644 > --- a/include/nl_types.h > +++ b/include/nl_types.h > @@ -34,6 +34,7 @@ > #ifndef _NL_TYPES_H_ > #define _NL_TYPES_H_ > > +#include > #include > > #ifdef _NLS_PRIVATE > --000000000000f8abb3060fbb0aa2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This was one of the things i wanted to comment on the tha= t review.

This change should b= e done as a special Linux sys/param.h that includes ctypes.h and then inclu= des the next sys/param.h.

A large number of the changes from that review are similar and i wanted y= o think through the right solution.

This is fragile: I'm likely to remove it again because it v= iolates style(9) and has no docs around it.

Warner

On Wed, Jan 24, 2024, 3:05=E2=80=AFPM Ed Ma= ste <emaste@freebsd.org> wr= ote:
The branch main has been updat= ed by emaste:

URL: ht= tps://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41091d2e4190aded12a9= 66b1d

commit 820401bf176996e41091d2e4190aded12a966b1d
Author:=C2=A0 =C2=A0 =C2=A0Val Packett <val@packett.cool>
AuthorDate: 2024-01-16 18:42:26 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-01-24 21:59:18 +0000

=C2=A0 =C2=A0 nl_types.h: explicitly include cdefs.h

=C2=A0 =C2=A0 This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping = from
=C2=A0 =C2=A0 Linux/musl, they were missing.

=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0https://www.pat= reon.com/valpackett
=C2=A0 =C2=A0 Pull Request:=C2=A0 =C2=A0h= ttps://github.com/freebsd/freebsd-src/pull/1066
---
=C2=A0include/nl_types.h | 1 +
=C2=A01 file changed, 1 insertion(+)

diff --git a/include/nl_types.h b/include/nl_types.h
index 120d1911631f..6ba15132126d 100644
--- a/include/nl_types.h
+++ b/include/nl_types.h
@@ -34,6 +34,7 @@
=C2=A0#ifndef _NL_TYPES_H_
=C2=A0#define _NL_TYPES_H_

+#include <sys/cdefs.h>
=C2=A0#include <sys/types.h>

=C2=A0#ifdef _NLS_PRIVATE
--000000000000f8abb3060fbb0aa2--