From nobody Fri Jan 05 14:22:04 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T65Hz5pKTz57C8Y; Fri, 5 Jan 2024 14:22:07 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T65Hz5K3Lz4dpQ; Fri, 5 Jan 2024 14:22:07 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704464527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/ar81L9MBaFmeo9CZAe5hICKp9fiBJASznnSq4WOfM=; b=n0xswhyVZQkF8+9aThslsdfCsAVzKYXq1+75kI232fJ/yZgcGyMuvVpwqyrRdfMVXpn4uE Ts0YFZ5QUTQaHs0Ugop6Z7iUAJdjd26TqpW8z7in6m25kSLR1YFhRxOIEBHVAE82Bf1Rst rha/CFvsYRFHYqokPl3iUf9etDZfSIQRqFSPIwnN1kwCjYE12NVdzMFXRFzAIlK/KCp+OR 1lCqH6/t6ltiikGZ37zEu5XArzRRtcEEq9iOM8IdjU9hCV/R7BsSMTd43zEEZnbsbUKs2/ MQwuc7/3Joo5Ubgq2dOf6QrDE9ciy59/ymlu/sTt5zOOIJfS5AynFWFRwNEk4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704464527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I/ar81L9MBaFmeo9CZAe5hICKp9fiBJASznnSq4WOfM=; b=Am9vqlRlyYUg63tLsQL7uiPTk8raK88+Bu47UDWm3EqoQx70iea+98z3CEAETdCUzbMg9O 5LmHCAbQRtKws/P6iJFDgaoECN/EK2r7zt+3GpXchk42Mu+qm6r/y59jIsiKYevryOpsy4 WRSRhuuqV2tCFDqbmp4kQZUzdGN3JAM4rBHMh/Ry0+6weA5bI330RTgZlsBNO+KPOlfWW1 Sd8D45rLlMF2Cp0PJS2mPjfDtdTtmnxliP6zyyGZaeIsDPpH9EgxhHN2FSwnlg5pq55U68 7UdahUIxNufgifJYhv+8uemKjIlp8EQEQ/xXcqaRe2rO2wgZE5D1q/VbHL2SMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704464527; a=rsa-sha256; cv=none; b=EXD2GM5AR4fPop8QMSmCsrWAXH4xGRnjG0OmqDNk1nnkTcTIU8jQ6BPHdFuuUIL8woV+um lF/JjOEKUVCA5+iE2ttkLBa4HIB76nDyOsinnhlSKKiJh8BBnlUDg1pKd5qMgK8Rix6lBT PEKgsrMjdtAMsrw060jjaa6uYDUuzehFeZHHRaD2Gw8Zb2pf8RJoz8xYno/9T8hEupaTN9 nCe3xdG3UTY4iOaVXK1g1IZzaWYY8eTFDbN7/yB+hru3l0bSrZ4NcKN4KwWBgXHQwr7aMh /74PaD3K3TNy7E6MQ3GrCeISGnbfI0OBE+ux1YxUuFooQ1RDMlm6XdJaXJRQUA== Received: from ravel.localnet (lfbn-nic-1-525-172.w90-118.abo.wanadoo.fr [90.118.140.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T65Hz0btQzV4Z; Fri, 5 Jan 2024 14:22:06 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bd61c1e89dc4 - main - libthr: thr_attr.c: Clarity, whitespace and style Date: Fri, 05 Jan 2024 15:22:04 +0100 Message-ID: <4872425.Cjmsv3J8Qz@ravel> In-Reply-To: References: <202401041044.404AiIN0046997@gitrepo.freebsd.org> <2782916.iL6vRArjjl@ravel> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1885913.vR5SVPPSqJ"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart1885913.vR5SVPPSqJ Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Olivier Certner To: Konstantin Belousov Date: Fri, 05 Jan 2024 15:22:04 +0100 Message-ID: <4872425.Cjmsv3J8Qz@ravel> In-Reply-To: MIME-Version: 1.0 Hi, > Also we usually discourage plain style changes or tweaks unless they are > preparations for more substantial change. Yes, I'm aware of that. It's a fixture of most projects, and generally a good one IMHO. Besides D43006, there will be several other changes to 'thr_attr.c' (and to 'libthr' more generally). > Can you show the place where it happens? Because the canonical style is > reverse, non-bool values must be explicitly tested instead of relying on > the implicit conversion to bool. I was referring to D40626 and D40642, but it may be considered a different situation because, there, an integer, whatever its actual numerical value, is used as a boolean flag as a whole and there is no '&' to extract a particular bit. Please have a look at the small series starting at D43327 (up to D43330) for the modifications you suggested and a few additional ones of mine. Thanks and regards. -- Olivier Certner --nextPart1885913.vR5SVPPSqJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmWYEIwACgkQjKEwQJce JiezGRAAhegMijLauFoK/gPL9JV+/nesiusddm9J9Sk+Y7WdusscK5J7eUjwMsQX WpBJ3L3kUHiP7bGCKb1MLN14nSH/FKCxIFFCwq8/eYeM74fFZijp3HWDlNSKD+TZ q7DGSjrXbLR2UyzfspeYCG9J6qS6fYc3lKI6zRB6aI0uAKRNizdoL4e8bsb1YgcU lBPMyao/M9vUufPrOcFBApt8BKeAXiudOjs80MKno6UjfDuXQHx/LnKekHZfpPg6 WTTZJIoV+pDDG5r3fDAioz9P0cp5vaLrxcZU7qH/PSEZsgtlSl6725I9cmlF2/hw btZ4eajBeFUX3di+yfmOfp677VP+w9TJZMMkQOb1s8Jk0BexqUCerZPy9E3FKn6P H5E9TKlqEKoUlKAyM4hShBwfE92tuNp23D0e4EhBi01mz+caFIf5g98WQKdgnHhC mrM+7oUOLX3gVkoy3ddD2Jyr8SUlHTfQ7LhDGxU1pHWagzxMalH/RK/VzIoDbQjA qcLVM3Xg0RLseRD9wuzmvkBZMiWvSzaN+O4nPFyUB6KcppYr4XyvH001/UWtcnfL HOHKgQeTLa1bj1phzpznSKBt8fIxCjqhst8BFZKFnfwSpqFHIEhBDWd0J2Pqz8mb +3tjr4LRJBX48rhdzENLAlt/QN5UUEZSCVvApBsVPi0/pQuj35Y= =I0sI -----END PGP SIGNATURE----- --nextPart1885913.vR5SVPPSqJ--