From nobody Fri Jan 05 05:00:50 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T5rrM1rDSz56HXF; Fri, 5 Jan 2024 05:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T5rrM0hxfz4WnP; Fri, 5 Jan 2024 05:00:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704430851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YxdqCWCynH0i92fhZUKVGcit+lHZfTLaxq4AqhVVxsY=; b=xJrRfBl4wUACAze9iUKS7igwzFzEUWn0a2Tb6T4ZuSsonrbumnifESlZrdPrgkDlW62qdG dUMDXnkJtvgbHYv7D5smKuhLobrW8kM1Yje3r7V9TfeOeQOq7fgYAoQJfE3QO5bqm6jwj1 AKZEf8lWiA30ck8LRfqQ7CWaPfo745ks+9vKtMushbCO9HMmDKpw7cdzwFXNP2jGiHOKBt j5M4MMu4S+HZifNbs05Zzfy1WBO+a2kSbQ9K2tALDU1KaWZs24uITKp4uNp8MHUo9MmvdZ IfP3BRvEU/6ML+/DRGAkQOfkWYPyaY1t8Py4DNEjWye9fc59MjjABa9QOa7iXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704430851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YxdqCWCynH0i92fhZUKVGcit+lHZfTLaxq4AqhVVxsY=; b=UcCVKitC2tGHQD6AWzC0J2/sZSz31xrgmWxu/33EnSnesjSUxW1JwzHQnGynN59UlSWdui /Z7qeM0y718qIPODGUqPQ9eRjc+Yn2KRyjpMKBA2zXMjg2/H0MJRGuFNktI+kXpcNUJJVR 1PJvEH4t15IIDHdDAYPJSQXbD0An5ROPI/6ByVmpoAFfBjObrox5o5QnfyWPffWPnvnyi1 1kZnm23kE5AMlRICFJFc68/cM8LMWXok0nhho1XqiA6GggOnu8ZPA2JJbKSeP9vmExzWdm uihmZ11o+C39nW3nqQ6yMKNJjJ2YM590kb+Z094oeIjDjP6GLo3yS49aEM9mQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704430851; a=rsa-sha256; cv=none; b=HSpBN2HKVVSyYQxr2cKcaUplP4c0Box31keHdkxVwgyyOfsbwpgbT48qPmP5GCgCZF0bcF SyEo88yJnXoCM3qR88f4TElYMdqoSLG2tPZs5svHtIiJ5Cz2iNCboWtgneVryxtAjHZrZr QTDaTT/nWm67zkmwwDlAnID+WPUw9PTy4gEVGseUwMEV3sAujZPV/TSLLNu3hMWkmB5JjC 5ZwoXXaL/cM4kcFSZUWwTXMqJ89UCDZpSbbqhwaGHPmF5HnvhYlqajmSWjQhcgIzGEBT3a EV+IyA/EqWzspeOgO/oMbrEd77xV2qstOI+0QAH629Qe3w0zGPg2s3/OOlafSQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T5rrL6rLYzk49; Fri, 5 Jan 2024 05:00:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 40550omd090348; Fri, 5 Jan 2024 05:00:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 40550o5P090345; Fri, 5 Jan 2024 05:00:50 GMT (envelope-from git) Date: Fri, 5 Jan 2024 05:00:50 GMT Message-Id: <202401050500.40550o5P090345@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 2d33ad48bd37 - main - vtruncbuf: improve the check for meta buffer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2d33ad48bd37f27925e4c46c798f8f2d23a2b501 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=2d33ad48bd37f27925e4c46c798f8f2d23a2b501 commit 2d33ad48bd37f27925e4c46c798f8f2d23a2b501 Author: Konstantin Belousov AuthorDate: 2023-12-31 20:46:53 +0000 Commit: Konstantin Belousov CommitDate: 2024-01-05 04:58:50 +0000 vtruncbuf: improve the check for meta buffer Revision e99215a614675 reorganized the code in vtruncbuf(), and moved the logic to flush meta buffers into a dedicated loop. While doing it, the condition was changed from bp->b_lblkno < 0 (to handle) into bp->b_lblkno > 0 (to skip), which causes buffer at lblkno to needlessly flush. Reviewed by: chs, markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D43261 --- sys/kern/vfs_subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 2e2457f59f60..e18c34656af4 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -2554,7 +2554,7 @@ restart_unlocked: */ restartsync: TAILQ_FOREACH_SAFE(bp, &bo->bo_dirty.bv_hd, b_bobufs, nbp) { - if (bp->b_lblkno > 0) + if (bp->b_lblkno >= 0) continue; /* * Since we hold the vnode lock this should only