From nobody Tue Feb 27 19:45:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tkny76p0Yz5CJpp; Tue, 27 Feb 2024 19:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tkny76J9bz56yw; Tue, 27 Feb 2024 19:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709063103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U76g92ywWRar5mGhxmlFx6m2Irk7kWZq6CkfH7BOZIg=; b=tl/ZVYbn34cxjOompjgZOeUXSsYw+sykAJuDOxFBbACsJS6IFqJNdD4++/lkhq+4wRCJyl KtJ72roGnuIwBl0Rw6FlS4lAgVA2fXJ4DkeweZjT7huGG06gR/nqv821bJZUpN0xbWtDuA SgMFfYNZLez9Mpvn/8VpOfiDHrMNdfeDV8VZb5MrXjsG3AYBajjDdjusZyaIaz/dnQieeM iZr0H6YHSjxrfJ932W5qKZ9TUMxfaN0LNqFT+K048z6WtrM/mpkurlPooWmcJ0/6oK1PvL YSYZA/+fok3Mtr10qpuEFXUh9asihLsQK0U4x3qLCO0Guu4hchezz9EV5058fw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709063103; a=rsa-sha256; cv=none; b=UB3tYwJq7sMhlzk+ppIij43W77wv2qVThjvZJ2KM8C0hqO4tfri69awRROkRLiX1ogSWd/ h1aJtB2flsoPPaj/LJfuC9RsFlMcuagYF7V7jiCikaluWeQz9jhRVvi57jtUvSAY4FnlJI /SlnqJZEJvvJCPG9RcCqJlSnPhCAgwU0dZ2/eA7KIUCZQMLaVqFi/zvJXXfM6ArJKFPHT4 L1/xqaJbOkfYLsL18qFcp8HDLFYXqrK3Vekbmxx7mdyEB9YJ+SQ4vVzUjFOXpeLLOKecoB ndzdd6OozZKEQzEs29E/VWWjDD7dP53QrGjnvYnw7lvGMnDG4RhK1zIYfMCipg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709063103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U76g92ywWRar5mGhxmlFx6m2Irk7kWZq6CkfH7BOZIg=; b=HgbakhKEejMIDQKl/xE6gKlIuW0Xpn0G3XWGgkhHPp1BbTkQk7vd8G2SAB4QO8M2gW4+7Z fkyzDWHLT6BS0QNqSRhOW6KA7GZFzPqGerlKpGSqEkxY+CcAJ7hvhosgPIVD8CPXzjaq5C y1GdIRd0kSS3b0JuWNrVQ3ciE11WzWSSOkZdHrdZR9TqaulfDYBbfLfBSrghS9MHxWf/fY p6qNlETpmKdch7/78u/ubhHrPY1JSV3NkImwMMSepPVEnUBG1UBasAzik7g4Pl29CQiv+F 2OFFJQZmSj1NUKxxtmQim7+GW93oovJMVcQ/AdcaHkwyrr4Tbihg4yatmf/n/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tkny75MKszQbs; Tue, 27 Feb 2024 19:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41RJj3v7092924; Tue, 27 Feb 2024 19:45:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41RJj3d4092921; Tue, 27 Feb 2024 19:45:03 GMT (envelope-from git) Date: Tue, 27 Feb 2024 19:45:03 GMT Message-Id: <202402271945.41RJj3d4092921@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 04fc3fb8fcf6 - main - rman: Remove rman_set_start/end List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 04fc3fb8fcf631889ec9a181504e6ae1daebd3cd Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=04fc3fb8fcf631889ec9a181504e6ae1daebd3cd commit 04fc3fb8fcf631889ec9a181504e6ae1daebd3cd Author: John Baldwin AuthorDate: 2024-02-27 19:43:34 +0000 Commit: John Baldwin CommitDate: 2024-02-27 19:43:34 +0000 rman: Remove rman_set_start/end These functions are not safe as the rman implementation assumes that all regions (including allocated resources) are sorted by address in the internal linked-list. Differential Revision: https://reviews.freebsd.org/D43936 --- sys/kern/subr_rman.c | 14 -------------- sys/sys/rman.h | 2 -- 2 files changed, 16 deletions(-) diff --git a/sys/kern/subr_rman.c b/sys/kern/subr_rman.c index 90a35ef885bf..792d03726c74 100644 --- a/sys/kern/subr_rman.c +++ b/sys/kern/subr_rman.c @@ -808,13 +808,6 @@ rman_make_alignment_flags(uint32_t size) return(RF_ALIGNMENT_LOG2(i)); } -void -rman_set_start(struct resource *r, rman_res_t start) -{ - - r->__r_i->r_start = start; -} - rman_res_t rman_get_start(struct resource *r) { @@ -822,13 +815,6 @@ rman_get_start(struct resource *r) return (r->__r_i->r_start); } -void -rman_set_end(struct resource *r, rman_res_t end) -{ - - r->__r_i->r_end = end; -} - rman_res_t rman_get_end(struct resource *r) { diff --git a/sys/sys/rman.h b/sys/sys/rman.h index bb63c4dfb100..9e8e3b878c5a 100644 --- a/sys/sys/rman.h +++ b/sys/sys/rman.h @@ -153,11 +153,9 @@ struct resource *rman_reserve_resource_bound(struct rman *rm, rman_res_t start, void rman_set_bushandle(struct resource *_r, bus_space_handle_t _h); void rman_set_bustag(struct resource *_r, bus_space_tag_t _t); void rman_set_device(struct resource *_r, device_t _dev); -void rman_set_end(struct resource *_r, rman_res_t _end); void rman_set_irq_cookie(struct resource *_r, void *_c); void rman_set_mapping(struct resource *, struct resource_map *); void rman_set_rid(struct resource *_r, int _rid); -void rman_set_start(struct resource *_r, rman_res_t _start); void rman_set_virtual(struct resource *_r, void *_v); extern struct rman_head rman_head;