From nobody Sun Feb 25 00:58:33 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tj53G0Pblz5BxWD; Sun, 25 Feb 2024 00:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tj53F4VSFz4tRj; Sun, 25 Feb 2024 00:58:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708822713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BsNpsB2kxZUuoTKBear28XPj1Q8/+0ID0NyyZPrf4jA=; b=pNm5MFEqqKTDYlBGRlxK2n3yp8gz91rm1N1LhtX+MniXVhbRQkurqGpPSBMeCgYJfh56Sc 4Am7PzoXExkHjsIR8qisqOJevkvyFGOjuqDke7oDLw0rIMir4RpHTthAus0HLM8pKM4eQR 0adSf3KGaU8SCvjewvBqRg7FjBmSCaIbuG8nTsttDb3dKdDHweIZPmh4bPzTfLLLSmCLWQ DC1YzaQV0BufmL0Ut26OngapH/wWlIwD2kzXUVSLy2Zr2cZI44GVfjBLOaQxRQk4NMbBrc 6wCQdby/k0IbvtQ77Mp3INI+bXdWsyNmNS9xVVryqNTJHJO9CjiGyx1UtHNyqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708822713; a=rsa-sha256; cv=none; b=RrGfdkjtrI6TtmB32/tE3f4I+Oekv0hREGHeBVdFu9nLxpKIV1KK1fohToYblKZtmLYwzM jCZvmJG2JL5nn2zLwmdERvbFapRXqopgDjblM7obTfO9pGHo66gmEb8OTugerwhC0xRC3g a5GEisANXUBnQwqBku4thE+Tlivd849XG95lug2rNREkd/EvbjDc5qZZjDuDMPg8KuBagu 4hysQlomeHJ3iMvqcB4WzeKwCCPRmAKMkfaJCVM3rDBMFi5B7tmkrUCQGpM4O6JtLEpBai 9AIfIPlc2vRHLVIxMygChFsI258EfLUX5k08VbLC47JBErVidO0kY49lvKkhhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708822713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BsNpsB2kxZUuoTKBear28XPj1Q8/+0ID0NyyZPrf4jA=; b=nOHJPoHjkAmpucYbvS5tQRNAExGTFhPhAIMyoLEG9gXK5cR/vYgaXVc6bZ8s+TMLJMMJBW FzsGefP4NajoASK2dqe951XafYtDI0KtXM7kASUicWWR7JQAilDgmHpQ3azXDivIlCKv3s GWgKKabzVT/cDfAXuUlJ+777YsjKUi1wlwF5++y0PkgwrC3Oh10Bi3w6X9BdPpjgX7jwQZ onlPHli1+zneqtYWu3fKdi5WMUUEYozPsKWQoMjISPOknUHFAejU05egGdLwDH+r7MYdAL weYsWWACqxggnUfbucKNhN91pO4SaiF4Y/W7MTWCnZ4Pej+B989mAvQlPalfnw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tj53F3c6SzN4w; Sun, 25 Feb 2024 00:58:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41P0wX10081747; Sun, 25 Feb 2024 00:58:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41P0wXNb081744; Sun, 25 Feb 2024 00:58:33 GMT (envelope-from git) Date: Sun, 25 Feb 2024 00:58:33 GMT Message-Id: <202402250058.41P0wXNb081744@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: d024bc7ff5e8 - main - loader/efi: Linker sets not needed. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d024bc7ff5e80537438b4556810782e9a8257b44 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=d024bc7ff5e80537438b4556810782e9a8257b44 commit d024bc7ff5e80537438b4556810782e9a8257b44 Author: Warner Losh AuthorDate: 2024-02-25 00:57:04 +0000 Commit: Warner Losh CommitDate: 2024-02-25 00:57:04 +0000 loader/efi: Linker sets not needed. We don't need linker sets listed as sections. They are explicitly included in the objcopy we use to create the .efi file. This practice was added in 2002 by peter@ in a6d81d83a280 to make ia64 builds self-hosted. However, it was added back to the objcopy in 2010 by rpaulo in 8df7a05edd36 for i386 EFI support, though the ldscript file then retained them needlessly. The gcc/binutils bug having been fixed in the interim. We've not needed them since then, but the redundancy didn't matter. Sponsored by: Netflix Reviewed by: tsoome, kevans Differential Revision: https://reviews.freebsd.org/D44061 --- stand/efi/loader/arch/amd64/amd64.ldscript | 11 ----------- stand/efi/loader/arch/arm/arm.ldscript | 10 ---------- stand/efi/loader/arch/arm64/arm64.ldscript | 11 ----------- stand/efi/loader/arch/riscv/riscv.ldscript | 11 ----------- 4 files changed, 43 deletions(-) diff --git a/stand/efi/loader/arch/amd64/amd64.ldscript b/stand/efi/loader/arch/amd64/amd64.ldscript index 57014aefc025..0e620654ea81 100644 --- a/stand/efi/loader/arch/amd64/amd64.ldscript +++ b/stand/efi/loader/arch/amd64/amd64.ldscript @@ -34,17 +34,6 @@ SECTIONS *(COMMON) } . = ALIGN(4096); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(4096); __gp = .; .sdata : { *(.got.plt .got) diff --git a/stand/efi/loader/arch/arm/arm.ldscript b/stand/efi/loader/arch/arm/arm.ldscript index 13affe12bbba..7b5c2af399c9 100644 --- a/stand/efi/loader/arch/arm/arm.ldscript +++ b/stand/efi/loader/arch/arm/arm.ldscript @@ -42,16 +42,6 @@ SECTIONS *(.got.plt .got) *(.sdata*.sdata.* .gnu.linkonce.s.*) } - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } __gp = .; .plt : { *(.plt) } .reloc : { *(.reloc) } diff --git a/stand/efi/loader/arch/arm64/arm64.ldscript b/stand/efi/loader/arch/arm64/arm64.ldscript index bacb81b5032f..18aead05cb49 100644 --- a/stand/efi/loader/arch/arm64/arm64.ldscript +++ b/stand/efi/loader/arch/arm64/arm64.ldscript @@ -39,17 +39,6 @@ SECTIONS __bss_end = .; } . = ALIGN(16); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(16); __gp = .; .sdata : { *(.got.plt .got) diff --git a/stand/efi/loader/arch/riscv/riscv.ldscript b/stand/efi/loader/arch/riscv/riscv.ldscript index 342ec62cf03e..63b71c3bd702 100644 --- a/stand/efi/loader/arch/riscv/riscv.ldscript +++ b/stand/efi/loader/arch/riscv/riscv.ldscript @@ -35,17 +35,6 @@ SECTIONS __bss_end = .; } . = ALIGN(16); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(16); .sdata : { /* * u-boot expects the gp register to be untouched by the EFI payload, so we