From nobody Fri Feb 23 03:03:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tgvvz6vqHz5BWYb; Fri, 23 Feb 2024 03:03:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tgvvz6NMMz4cTx; Fri, 23 Feb 2024 03:03:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708657391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OcB2M9ArEpaqembiDfA7urJAqb0nlxUPgejda14ZYd4=; b=dxtULVoiewuUTyIlzIob7/WZ0wDfCSZIx3uVNnKujBSqzOqzSVM+WapCuEL8q/aAZkl9JR gUJKqVorRjyrxcNkm5u6PS6rdpLueLdoIRScwyR/Cd6UOsG/BhaQZht5/MDuylY6PfKlR1 A3OnTOvKBF/0lMkqGLYabGer9Okt2uZlVKb8DnylRduYR5t8AtM9fjIcRWHxYdauUZ0equ 7km1iiEFJPV3RRcRDH5EHgVfi++TDqBC0vNNIlmykTobtsZ/ZmHnxhH014fhGyUxjzNW32 2E3yLCJ+GdgSMoHFs4T1OO5xnCUFfOR21XLD3RkRGTjq5T6haQXU95fvZY8QTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708657391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OcB2M9ArEpaqembiDfA7urJAqb0nlxUPgejda14ZYd4=; b=bXzl2ZyNtgbPHrvBDqlq8Ti8bWhVy8YXHzUHdz9HRWkHOFOKpQyMTuUnfrqd/w4Ct9ceKA LeGnsvSvGROOv3lsOJpJQ6sB9X9EO+xkedW/vAa2gjv3qm5VxoP5ToRr0KDhswizqfMkG+ 8+zZW83pXJuAtTe94jqIUqADoO80fALRcuOub8Sxv49QRATVHWGxjsQeZ3MWUX6XVZt6MJ CTlhH+jsPbXuput2bwkBsAVcT9ILbon22LOLvmEltw9zmLUtm2UnUa1BnywOpCOjO9OdXO yIEfNc2ddJPShKBzB+0XiVvQZ5KrC6YJ+hD0ydjUz9P2alJ87iTHfbd4bnzgLA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708657391; a=rsa-sha256; cv=none; b=Nr0r6kJIIG+Pchs4Y3fskAqbKOrUZeBPMo4T21KJKzBCgxwVXMeAqRkbEgrbTrYDClFr91 KWrAFt3qL6os8wKimuiVZxDN9NcKfzALVNIlzTNbUWfXL7EmLqONTvPHB8Dh5qu4q0tJyQ 2yyM/n2cpKQd26zgWPlaXhiZqyUTFGCS/T7WQHCUs7ZLFM1kRUVKEBRDTWSVhSwg9YoewM HFNoEQNFmPxWncA/yvYRlZ/OJfM955zuvzr1y0ZQWzqOT5NZAljYGgnmOBS+fwD6KshPyz Np9ZnjS5AHb8DbWdoIS9Z84+qj+xcw2w1X2Wr+eQXj0hxOKtoZVA7B1mxgSZrA== Received: from [IPV6:2601:644:937f:4c50:9110:97a:5df4:795c] (unknown [IPv6:2601:644:937f:4c50:9110:97a:5df4:795c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Tgvvz1r5wzTVj; Fri, 23 Feb 2024 03:03:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <7fb66c83-7382-4053-b6c6-27ee0ae03274@FreeBSD.org> Date: Thu, 22 Feb 2024 19:03:09 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 47e073941f4e - main - Import the kernel parts of bhyve/arm64 Content-Language: en-US To: Warner Losh Cc: Andrew Turner , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202402211855.41LItsm2033633@gitrepo.freebsd.org> <23101a96-4901-4086-bdbf-dfbab2b66e49@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/22/24 12:10 PM, Warner Losh wrote: > On Thu, Feb 22, 2024 at 11:30 AM John Baldwin wrote: > >> On 2/21/24 10:55 AM, Andrew Turner wrote: >>> The branch main has been updated by andrew: >>> >>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=47e073941f4e7ca6e9bde3fa65abbfcfed6bfa2b >>> >>> commit 47e073941f4e7ca6e9bde3fa65abbfcfed6bfa2b >>> Author: Andrew Turner >>> AuthorDate: 2024-01-09 15:22:27 +0000 >>> Commit: Andrew Turner >>> CommitDate: 2024-02-21 18:55:32 +0000 >>> >>> Import the kernel parts of bhyve/arm64 >>> >>> To support virtual machines on arm64 add the vmm code. This is >> based on >>> earlier work by Mihai Carabas and Alexandru Elisei at University >>> Politehnica of Bucharest, with further work by myself and Mark >> Johnston. >>> >>> All AArch64 CPUs should work, however only the GICv3 interrupt >>> controller is supported. There is initial support to allow the GICv2 >>> to be supported in the future. Only pure Armv8.0 virtualisation is >>> supported, the Virtualization Host Extensions are not currently >> used. >>> >>> With a separate userspace patch and U-Boot port FreeBSD guests are >> able >>> to boot to multiuser mode, and the hypervisor can be tested with the >>> kvm unit tests. Linux partially boots, but hangs before entering >>> userspace. Other operating systems are untested. >>> >>> Sponsored by: Arm Ltd >>> Sponsored by: Innovate UK >>> Sponsored by: The FreeBSD Foundation >>> Sponsored by: University Politehnica of Bucharest >>> Differential Revision: https://reviews.freebsd.org/D37428 >> >> FYI, sys/arm64/vmm/vmm.c shares a fair bit of code with sys/amd64/vmm/vmm.c >> and looks to be derived from the amd64 file, so I think it should preserve >> NetApp's copyright line in addition to Mihai's. >> > > In general, the advice I've been giving is that one should retain > copyrights when > there's at least 10%-20% remaining of the original work. And one should > hesitate to add > them unless you've contributed 10%-20% or more to the work (ideally more, > but sometimes > that's gets squishy because the underlying law is based on words like > substantial > and de-minimus, which don't translate well to line counts, and for large > works what > is substantial can be a bit subjective). > > If they share so much, maybe we should also look at sharing directly, > rather than by > cut and paste in the future. Jessica has already mentioned sharing some of the code in at least vmm_dev.c in the future so I think that will likely happen in some future refactoring. Several files that share code and were clearly derived from the amd64 bits already have NetApp, etc. copyrights in this commit, it's just vmm.c that I think needs updating. -- John Baldwin