From nobody Tue Feb 13 01:10:39 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYjv11kldz59Nlm for ; Tue, 13 Feb 2024 01:10:53 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYjv1009Vz4mB6 for ; Tue, 13 Feb 2024 01:10:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-33cd57b86bfso83490f8f.1 for ; Mon, 12 Feb 2024 17:10:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707786651; x=1708391451; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fb/uUO8FPzpUrO0oHAni5GsafTpkd6TwxJBwIjwz1cw=; b=Wbomi6X9gUx3OvQSL0NxCGjM+5YFRcKNKpe628m7MLNatbJDl+iDWgIwxKqjSJpiTF xoMRb6PcOhL1aEez9C+zVNVGXR3ZAVgc3KLVAAe1n7gQf5gkvAwQ3xm7KZh/7O6CC1hN jdX2fKUUWa9UWoY6PjFEoXXk15gL8JtrU6+/hcPvGZtCj2fFm2aNXIKe4J2VF4RaoXlJ ZmeK21NY0sjgOyCDQs18qt9O2t0KlPKcolTQdeK5dShgJ5UM/T7ul2Z2r3lSpAXlyGft T5JvAOTDvm697QjP2H/1nFqXsbvfyOhdhR4KfIOsM8ngl1ap2kmx6nqzstuPxdGjD4FI rUqw== X-Forwarded-Encrypted: i=1; AJvYcCU5+aaZDi0hkbXwOk3jMpXKQhdHmdKCl5YnpfhtR+dJIEMCi+Gs5OH5+HhjImMGDzgCbKqM6N6kSTlxIlp+Ml+QMZoS6Rz1XS2KOkK28DvewA== X-Gm-Message-State: AOJu0Yzask4h1U/6OdjyBiuQKfOuEpV+KhzNLHgd1spUV4VTiStjIrr0 BrxQNY1PdgqMX5BIe4kbCwH7WvmOEQlmTFL0SlBp9NR6CPstN2csMCcZfkEEtDg= X-Google-Smtp-Source: AGHT+IHEi2mgGj1QdxgXLYI7U8QEpck9e0YBVJuxVy6TuOebfBE2ysu9u6qMLTUpcKg6w61ovmp23g== X-Received: by 2002:a05:6000:11ca:b0:33b:61b3:4bd8 with SMTP id i10-20020a05600011ca00b0033b61b34bd8mr6066994wrx.67.1707786650924; Mon, 12 Feb 2024 17:10:50 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUAigU5rGLsyaJnF/Fy6/1uSOxja02DmsTk7rMYgQcHYQgbjtdBDl66FL6Adh6YVhQbhutg6aMXWK0kaK/jsenteHHrbCH3FzgHU0ro/cEOdWtEY6NozUjXBckN3VepHCflxcl0QWky2aEeOdkEQ7E+wg== Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id m18-20020a5d56d2000000b0033b60bad2fcsm8016717wrw.113.2024.02.12.17.10.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Feb 2024 17:10:50 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 0df5f65908dd - main - reboot: Implement zfs support From: Jessica Clarke In-Reply-To: <202402121853.41CIrfdp030604@gitrepo.freebsd.org> Date: Tue, 13 Feb 2024 01:10:39 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202402121853.41CIrfdp030604@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4TYjv1009Vz4mB6 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 12 Feb 2024, at 18:53, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D0df5f65908dd1913212535e6c4dd4c73= ce19c305 >=20 > commit 0df5f65908dd1913212535e6c4dd4c73ce19c305 > Author: Warner Losh > AuthorDate: 2024-02-12 18:45:37 +0000 > Commit: Warner Losh > CommitDate: 2024-02-12 18:45:37 +0000 >=20 > reboot: Implement zfs support >=20 > Implement full support for ZFS -k support. For ZFS, we have to set = a > property that gets cleared by the boot loaeder for whether or not = to > process nextboot.conf. Do this using system("zfsbootcfg..." rather = than > coding the small subset of that program inline to avoid CDDL > contamination of reboot and the complications of disabling CDDL = and/or > ZFS. The few bytes needed to implement reboot for systems with zfs = is > not worth saving for systems w/o ZFS. Can we at least use posix_spawn rather than system? The asprintf+system combo may in practice be safe, especially given the nature of this tool, but I don=E2=80=99t think it=E2=80=99s a great idea to be writing = system-using code in 2024 when it=E2=80=99s easy to avoid. That way nobody needs to = stop and think carefully about whether the code is safe, because it is by construction. Jess