From nobody Sat Feb 10 21:36:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TXPDS1Br4z5BPc5 for ; Sat, 10 Feb 2024 21:36:24 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TXPDS0n9hz4bWn for ; Sat, 10 Feb 2024 21:36:24 +0000 (UTC) (envelope-from truckman@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707600984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=LeaOqra0iF8ixVV0/ATPPu1LUtyn+uErxpwH+JUmXX8=; b=uRpjNAYtESIN+iwamF38qv8FM2N456ngoP+cgt2vEqg5OoYTfb49f+3UezPgNJXF1RNMpc /UpqjnhgPYWWRXPsR8r80NqrgfM985YkmBr/WrqnWuHoA84TMBbh1Ry8a2oQyjC5RGpjS/ tbLmeFISf2KB6VUzWi47gqzYOfIuu7MpwW4fnUY4Wn3MvDEC5bmzMN/jXXzcvI7RaTqPT8 srBp5LIP69YSGfbA5UIPug5kuPMOXa6nMvQlmpkD08lhtS7eBC881JbHqC3ReqGip4/qfa Rv3NfitJD2K9R7WkMG54JzfruHXVWgYFlrNWVisn+o5GXi9bqrwBQrRc1VGEwg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707600984; a=rsa-sha256; cv=none; b=hsCktNliQQzaqN1/pgVQ8+sLRf4ykoRMRoteSjbh7x+fMqZ5y/twQT29p23HIk7P4FhXnK hFa8XDDtuHikOkFdMQIXPPi9FSPw/ltGODyBh3Fzn8DqMs7+f4BMgvAfLpwywAotVFwMMC WGE+5cuBCWZMC/b/UKtvioNT/7z2laP+OdppyuOzvWEblnwzyKJQQmaT+IRIWH2buelSNE iLM7lnh5D06x+7gtPbH/zqiekkCU7i1ppO+hU8lGjAUzAN0irIaxSUJGwLLa/sLMDQj0te pgNeOSS/BQm3y95KaJzgBN7RgwXxiOoQbAUTVvu3yMKnHImtfaj1oNsAQRIDHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707600984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: references:references; bh=LeaOqra0iF8ixVV0/ATPPu1LUtyn+uErxpwH+JUmXX8=; b=AJN1Ra8oS00mioJbj2EiPzZYWVWVUVf+C0yZM5LtlaDl0OD96UB140X9chZDpH3SC+tfrc GQyYg7Wrlfc6ElrNt2JCpgx0WKFGecoVubQ6k6RWLbk2d12R1xR0+Y7F7MtOFmy2B3XS1B YPKw9fNsWSVGfIOXvaCwvRyb9JayXnWGAjrecJHjHRvWGFzqEtxo9blxVLmhu5uzj7e7iG aKJbgBqTwvSakvFYbWLSxIjFPKxl2k28OPt7nxFMSPKShb2+HaNZ7BZHotiIOCG7LqSQJo X8t63n6GoB2KQreUpym/krTsYDTzOPZG++wAn7pwaaMa3QY+7xEGsLhIJVWGUg== Received: from gw.catspoiler.org (unknown [IPv6:2602:304:cd45:5b11::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: truckman) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TXPDR4fHvzbq8 for ; Sat, 10 Feb 2024 21:36:23 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from dl (uid 1001) (envelope-from truckman@FreeBSD.org) id 232f9f by gw.catspoiler.org (DragonFly Mail Agent v0.13 on mousie.catspoiler.org); Sat, 10 Feb 2024 13:36:20 -0800 Date: Sat, 10 Feb 2024 13:36:19 -0800 (PST) From: Don Lewis Subject: Re: git: 49d684369c66 - main - libthr: filter rather than link with libsys To: Brooks Davis cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Message-ID: References: <202402071951.417JpRgf034979@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; CHARSET=us-ascii Content-Disposition: INLINE On 7 Feb, Brooks Davis wrote: > The branch main has been updated by brooks: > > URL: https://cgit.FreeBSD.org/src/commit/?id=49d684369c6682eebca325c55a6c96b7c03f5aeb > > commit 49d684369c6682eebca325c55a6c96b7c03f5aeb > Author: Brooks Davis > AuthorDate: 2024-02-07 19:38:16 +0000 > Commit: Brooks Davis > CommitDate: 2024-02-07 19:50:47 +0000 > > libthr: filter rather than link with libsys > > The allows gcc + GNU ld to link programs with -m32 -pthread without > erroring out due to _umtx_op_err being undefined (unless -lsys is added > to the link command. > > We now always link _umtx_op_err into libthr (not just when it's static) > and filter it with libsys so we call that implementation. The dynamic > implementations (at least the assembly ones) should likely become stubs > as a further refinement. Thanks! I ran into this problem early this week when lang/gcc12 stopped bulding and I spent a bunch of time bisecting.