From nobody Tue Feb 06 21:23:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TTx7K6PVbz5B0jh for ; Tue, 6 Feb 2024 21:23:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TTx7K4YHfz4bMl for ; Tue, 6 Feb 2024 21:23:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-55cca88b6a5so7254261a12.1 for ; Tue, 06 Feb 2024 13:23:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1707254602; x=1707859402; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=l+YTDtqNw6DIl7W/bJ4qF0z1c3TPUb7WjXTt7T/w9nQ=; b=JqtVQl3ljmrFzEjimwv5xLYJHNghZW94tnjIP8dJ6zkJIaQcvqk2hFro12xJdeDxIn JXc56tBB7vuhxyg1OYpglALTpuGmyfvoY9UMuBUpzOU6Sa/U2XgsClWuNKnH5r44FBwa hnaMeTHTCD1/GTqL8AYc34nzdr1zF1vYsQWG16ndSO+Yubs89WIVhY2kQUBb6kmOrbfz tIszIKV1Wi539270DyaOQ06CWtfa4jDHRnzlLKwdgS5CxC+6Ug2meP+wm89dWsZt59ZQ lZqVVdlS4QuWIwNeBhya/iker2sVrLTTXy9j0J+8vSgZUb0Y2/fh3xQWTg8s616Z9DYx rOVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707254602; x=1707859402; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l+YTDtqNw6DIl7W/bJ4qF0z1c3TPUb7WjXTt7T/w9nQ=; b=ivfpNJRQO2PTryRHa3fmUwBzmp18oDHp2VYnQfgWrvy8HaLBQPwIDjnIKhiGUFYa4u xrWK2q/kV0C3rHo/MnGogNuZlUNVBQkkIhLWiflXasa1C/kgJMlik8GKc+MxM2sFDoNK A1nDVPPRyNWZ3ZYSOpETI1Uq6YMPRWLZ1FdIy5ziZiwRUGIWOFc7szBdzTbjYcRxJPDb elnPuFO2V2vznPnWz9YqdLDFtZ3N+tmZoR12AW/UjABXIUNRELG7FJkr9n2h6sibpDtn k95SlsMvbmdi0jfiQsKKrQ+ItRwwYICihHAlLwQkhI5/51qCXglWXrZSL3Ir6W0ExI9d 05mg== X-Forwarded-Encrypted: i=1; AJvYcCVEpv0fTq8e5MFcxxJpqeAR0ZFUNvqntjyF8qquBsqcDPGzK/CMX/7hBRHKcwG91QScYtOKLTJDMD+xZNbhwbpkzD788ZnCB6/qXWQtKkXf3g== X-Gm-Message-State: AOJu0YyCCvHn/Q9MKmJo6arUME86NMVO2gLPKEiKonENiOkIatSq1Ga5 0MmCFsmkeDpz2NM2uPfUwjXIXHyFTt3UIFC99tMNDs6+qqCTyQai7RBHSiG3pl75XAD0ggmWfky aVEDP5cCPsqE++km8kLrxLhb//jnJpDskc+asuw== X-Google-Smtp-Source: AGHT+IG8GWz3eMbFYVFpUvdfco5RZxB+vKGtvrbq9B4ImPTx9thI5aJuI2Ke8g64twa7i4uM8Tt6a+OMbO/6Yx3E9A8= X-Received: by 2002:a05:6402:31f4:b0:55f:11cf:ee54 with SMTP id dy20-20020a05640231f400b0055f11cfee54mr2607129edb.32.1707254602333; Tue, 06 Feb 2024 13:23:22 -0800 (PST) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202402052119.415LJKSN037380@gitrepo.freebsd.org> <0A170E1B-4684-470F-9B4B-65B166191CEE@FreeBSD.org> In-Reply-To: <0A170E1B-4684-470F-9B4B-65B166191CEE@FreeBSD.org> From: Warner Losh Date: Tue, 6 Feb 2024 14:23:10 -0700 Message-ID: Subject: Re: git: 6d4a140acfdf - main - pf: Ensure that st->kif is obtained in a way which respects the r->rpool->mtx mutex To: Kristof Provost Cc: Mateusz Guzik , Gleb Smirnoff , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Igor Ostapenko , Kajetan Staszkiewicz Content-Type: multipart/alternative; boundary="0000000000001d183f0610bd30e5" X-Rspamd-Queue-Id: 4TTx7K4YHfz4bMl X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --0000000000001d183f0610bd30e5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 6, 2024 at 9:27=E2=80=AFAM Kristof Provost wro= te: > > I need to land my -c flag that automates git arc patch more... > > If that does what I think it does (i.e. commit the patch locally, rather > than just staging it) you do indeed need to land that. It=E2=80=99ll be v= ery > helpful. > Oh, I already landed it in 787cb30d20ac2031283c6dc2ec829f190997e581. And it does do what you think: It will use the phabricator APIs to scrape as much information as it can out of it (author, etc) and commit it so you can not have to worry about cut and pasting the wrong thing, retyping commit messages, etc. Give it a try, and let me know what screws up. Just add '-c' where you'd use 'git arc patch' today. I have some doodles for pulling the entire chain down as well, but got side tracked into just getting arc (archanist) to do that for me and see what the quality of the results are and I never was happy with the couple of patch trains that I tried. Warner --0000000000001d183f0610bd30e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Feb 6, 2024 at 9:27=E2=80=AFA= M Kristof Provost <kp@freebsd.org&= gt; wrote:
> I need to land my -c flag that automates git arc patch more...

If that does what I think it does (i.e. commit the patch locally, rather th= an just staging it) you do indeed need to land that. It=E2=80=99ll be very = helpful.

Oh, I already landed it in=C2= =A0787cb30d20ac2031283c6dc2ec829f190997e581. And it does do what you think:= It will use the phabricator APIs to scrape as much information as it can o= ut of it (author, etc) and commit it so you can not have to worry about cut= and pasting the wrong thing, retyping commit messages, etc.

=
Give it a try, and let me know what screws up. Just add '-c&= #39; where you'd use 'git arc patch' today. I have some doodles= for pulling the entire chain down as well, but got side tracked into just = getting arc (archanist) to do that for me and see what the quality of the r= esults are and I never was happy with the couple of patch trains that I tri= ed.

Warner
--0000000000001d183f0610bd30e5--